From 896bbdf6cefd1e49eeae76cf54e9fc55ab575f20 Mon Sep 17 00:00:00 2001 From: Shubham Mishra Date: Tue, 4 Nov 2025 20:33:45 +0530 Subject: [PATCH] clippy --- crates/client-api/src/lib.rs | 2 +- crates/core/src/db/relational_db.rs | 5 +++-- crates/core/src/host/module_host.rs | 1 - crates/core/src/host/wasm_common/module_host_actor.rs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/crates/client-api/src/lib.rs b/crates/client-api/src/lib.rs index d6c67dfa06..a21487f91b 100644 --- a/crates/client-api/src/lib.rs +++ b/crates/client-api/src/lib.rs @@ -85,7 +85,7 @@ impl Host { let sql_span = tracing::trace_span!("execute_sql", total_duration = tracing::field::Empty,); let _guard = sql_span.enter(); - let result = sql::execute::run(&db, &body, auth.clone(), Some(&module_host), auth.caller, &mut header) + let result = sql::execute::run(&db, &body, auth, Some(&module_host), auth.caller, &mut header) .await .map_err(|e| { log::warn!("{e}"); diff --git a/crates/core/src/db/relational_db.rs b/crates/core/src/db/relational_db.rs index 1b8cd142cf..a3dadbc21f 100644 --- a/crates/core/src/db/relational_db.rs +++ b/crates/core/src/db/relational_db.rs @@ -1517,7 +1517,8 @@ impl RelationalDB { /// 3. Deserializing the return value from the view execution /// 4. Inserting all rows from the return value into the view table, with the arg_id /// set to the inserted view argument's id. - /// The `typespace` is needed for deserializing the return value. + /// The `typespace` is needed for deserializing the return value. + #[allow(clippy::too_many_arguments)] pub fn evaluate_view( &self, tx: &mut MutTxId, @@ -1543,7 +1544,7 @@ impl RelationalDB { st_view_row.is_anonymous, ); - let arg_id = tx.get_or_insert_st_view_arg(&args.get_bsatn())?; + let arg_id = tx.get_or_insert_st_view_arg(args.get_bsatn())?; let input_rows = product![ if is_anonymous { diff --git a/crates/core/src/host/module_host.rs b/crates/core/src/host/module_host.rs index 49f9a79f28..9db0c693a8 100644 --- a/crates/core/src/host/module_host.rs +++ b/crates/core/src/host/module_host.rs @@ -440,7 +440,6 @@ pub fn create_table_from_view_def( module_def: &ModuleDef, view_def: &ViewDef, ) -> anyhow::Result<()> { - println!("Creating view table for view {:?}", &view_def); stdb.create_view(tx, module_def, view_def) .with_context(|| format!("failed to create table for view {}", &view_def.name))?; Ok(()) diff --git a/crates/core/src/host/wasm_common/module_host_actor.rs b/crates/core/src/host/wasm_common/module_host_actor.rs index 03b5021ad3..70c8648c15 100644 --- a/crates/core/src/host/wasm_common/module_host_actor.rs +++ b/crates/core/src/host/wasm_common/module_host_actor.rs @@ -712,7 +712,7 @@ impl InstanceCommon { WORKER_METRICS .wasm_instance_errors .with_label_values( - &caller_identity, + caller_identity, &self.info.module_hash, &caller_connection_id.unwrap_or(ConnectionId::ZERO), reducer_name,