From eeef4e9f135f4f1716685fec37186ac54f556983 Mon Sep 17 00:00:00 2001 From: Mario Montoya Date: Fri, 19 Sep 2025 13:59:19 -0500 Subject: [PATCH] Remove smoke test check for SSL support, let the defaults works (#3259) # Description of Changes As title says # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [x] Run smoke test --- smoketests/tests/pg_wire.py | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/smoketests/tests/pg_wire.py b/smoketests/tests/pg_wire.py index 89c7880c3..a3ee13a94 100644 --- a/smoketests/tests/pg_wire.py +++ b/smoketests/tests/pg_wire.py @@ -5,14 +5,12 @@ import tomllib import psycopg2 -def psql(identity: str, sql: str, extra=None) -> str: +def psql(identity: str, sql: str) -> str: """Call `psql` and execute the given SQL statement.""" - if extra is None: - extra = dict() result = subprocess.run( ["psql", "-h", "127.0.0.1", "-p", "5432", "-U", "postgres", "-d", "quickstart", "--quiet", "-c", sql], encoding="utf8", - env={**os.environ, **extra, "PGPASSWORD": identity}, + env={**os.environ, "PGPASSWORD": identity}, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True, @@ -267,16 +265,6 @@ en | se | sql_out = psql(token, "") self.assertEqual(sql_out, "") - # Connection fails when `ssl` is required - for ssl_mode in ["require", "verify-ca", "verify-full"]: - with self.assertRaises(Exception) as cm: - psql(token, "SELECT * FROM t_uints", extra={"PGSSLMODE": ssl_mode}) - self.assertIn("not support SSL", str(cm.exception)) - - # But works with `ssl` is disabled or optional - for ssl_mode in ["disable", "allow", "prefer"]: - psql(token, "SELECT * FROM t_uints", extra={"PGSSLMODE": ssl_mode}) - # Connection fails with invalid token with self.assertRaises(Exception) as cm: psql("invalid_token", "SELECT * FROM t_uints")