mirror of
https://github.com/clockworklabs/SpacetimeDB.git
synced 2026-06-29 01:09:09 -04:00
Jason Larabie
14f79910ee
# Description of Changes
- Migrated the C++ module-definition assembly path to V10-first
internals:
- Added v10_builder and module_type_registration systems.
- Switched Module::__describe_module__ to serialize RawModuleDef with
V10 payload.
- Updated macro registration pipeline to register through V10
- Added explicit naming support across macro surface (*_NAMED variants
for reducer/procedure/
view and field/index macros).
- Reworked multi-column index macros (FIELD_MultiColumnIndex,
FIELD_MultiColumnIndex_NAMED) with
migration alias.
- Added SPACETIMEDB_SETTING_CASE_CONVERSION(...) to support case
conversion policy
- Error-path hardening by adding explicit constraint-registration error
tracking and preinit validation
- Codegen updates:
- Updated C++ moduledef regen to V10 builder types.
- Adjusted C++ codegen duplicate-variant wrapper generation to emit
proper product-type
wrappers.
- Test/harness updates:
- type-isolation-test runner now defaults to focused V10 regression
checks; --v9 runs broader
legacy/full suite.
- Added focused modules for positive/negative V10 checks:
- test_multicolumn_index_valid
- error_multicolumn_missing_field
- error_default_missing_field
- Re-enabled C++ paths in sdks/rust/tests/test.rs procedure/view/test
suites.
# API and ABI breaking changes
- Refactor of the underlying module definition
- New *_NAMED variant macros for explicit canonical naming
- FIELD_NamedMultiColumnIndex renamed to FIELD_MultiColumnIndex
# Expected complexity level and risk
3 - Large set of changes moving over to V10 with underlying changes to
make future updates a little easier
# Testing
- [x] Ran the type isolation test and expanded it
- [x] Ran the spacetimedb-sdk test framework to confirm no more drift
between C++ and other module languages
- [x] Ran Unreal test suite though not really applicable
- [x] New app creation with `spacetime init --template basic-cpp`
- [x] Ran describe module tests against Rust + C# matching with C++ on
the /modules/sdk-test* modules to find any possible mis-alignment
# Review
- [x] Another look at the new features with C++
- [x] Thoughts on *_NAMED macros, I couldn't come up with a better
solution with C++20
57 lines
1.2 KiB
C++
57 lines
1.2 KiB
C++
#ifndef SPACETIMEDB_TEMPLATE_UTILS_H
|
|
#define SPACETIMEDB_TEMPLATE_UTILS_H
|
|
|
|
#include <cstddef>
|
|
#include <optional>
|
|
#include <tuple>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
namespace SpacetimeDB {
|
|
namespace Internal {
|
|
|
|
template<typename T>
|
|
struct function_traits;
|
|
|
|
template<typename R, typename... Args>
|
|
struct function_traits<R(*)(Args...)> {
|
|
static constexpr size_t arity = sizeof...(Args);
|
|
using result_type = R;
|
|
|
|
template<size_t N>
|
|
using arg_t = typename std::tuple_element<N, std::tuple<Args...>>::type;
|
|
};
|
|
|
|
template<typename T>
|
|
std::vector<T> view_result_to_vec(std::vector<T>&& vec) {
|
|
return std::move(vec);
|
|
}
|
|
|
|
template<typename T>
|
|
std::vector<T> view_result_to_vec(const std::vector<T>& vec) {
|
|
return vec;
|
|
}
|
|
|
|
template<typename T>
|
|
std::vector<T> view_result_to_vec(std::optional<T>&& opt) {
|
|
std::vector<T> result;
|
|
if (opt.has_value()) {
|
|
result.push_back(std::move(*opt));
|
|
}
|
|
return result;
|
|
}
|
|
|
|
template<typename T>
|
|
std::vector<T> view_result_to_vec(const std::optional<T>& opt) {
|
|
std::vector<T> result;
|
|
if (opt.has_value()) {
|
|
result.push_back(*opt);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
} // namespace Internal
|
|
} // namespace SpacetimeDB
|
|
|
|
#endif // SPACETIMEDB_TEMPLATE_UTILS_H
|