mirror of
https://github.com/clockworklabs/SpacetimeDB.git
synced 2026-05-10 01:30:37 -04:00
Shubham Mishra
de2b65fb8d
# Description of Changes - [x] : Store "accessor"s names in ModuleDef (for tables, columns, and indexes for now) and pass them to TableSchema as aliases. - [x] Create accessor system tables for each of them: `st_table_accessor`,`st_column_accessor`, `st_index_accessor` - [x] Update the SQL parsing logic to also consider alias names. Alias name stored will be same as actual names until we merge https://github.com/clockworklabs/SpacetimeDB/pull/4263 # API and ABI breaking changes NA # Expected complexity level and risk 3 This patch updates SQL name resolution which isn't a very complex change since table and column name resolution are each handled by their own helper method. It also adds new system tables which need to be handle correctly during restore/replay. We do have regression tests for this that should catch any incorrect handling or missing steps. I would say the main risk is that we don't populate cached table and column schemas with the alias/accessor name. Regression tests have been added to catch this, but there are edge cases around migrations and replay that currently aren't covered. # Testing Added SQL smoketests that use canonical/accessor table/column names. They currently fail because we're currently using the accessor name for both. They should pass once this is updated. --------- Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io> Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com> Co-authored-by: clockwork-labs-bot <bot@clockworklabs.com> Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
⚠️ Internal Crate ⚠️
This crate is intended for internal use only. It is not stable and may change without notice.