mirror of
https://github.com/clockworklabs/SpacetimeDB.git
synced 2026-05-19 22:22:57 -04:00
Phoebe Goldman
3afb8751ff
Out-of-band discussion resulted in a different syntax for registering RLS rules in module code. This PR implements that new syntax in Rust modules. C# modules, which did not have an implementation prior, are unaffected. The new macro's implementation is significantly simpler, with all the interesting work done by "runtime" code rather than in the macro. One effect of this is that SQL syntax errors are no longer detected at compile time. Instead, they will only be checked at `spacetime publish` time, when the filter query is processed by the SpacetimeDB host. I consider this reasonable, as even in the previous design, most "interesting" errors (e.g. name resolution, type checking) could only be detected at publish time anyways. The new macro could perform SQL syntax checking in the same way as the old one, but I consider the benefits of this to be outweighed by the added complexity in our macro code it would require. This commit also applies `#[doc(hidden)]` to everything RLS-related, with TODO comments to make them visible once RLS is fully implemented.