mirror of
https://github.com/bevyengine/bevy.git
synced 2026-05-06 06:06:42 -04:00
andriyDev
e9e15e516c
# Objective - Followup to #23663. - Make the nested loading API easier to understand (when reading from docs.rs). ## Solution - Remove the type-state stuff from `NestedLoader`. Make each way of calling load just be its own function. - Add override_unapproved to the `NestedLoader`. - Rename `NestedLoader` to `NestedLoadBuilder` (to match `LoadBuilder`). - Rename `.loader()` to `.load_builder()` just like `AssetServer::load_builder`. Some decisions: - I included `override_unapproved` to match LoadBuilder. We could remove this to say "loaders shouldn't be able to override", but I don't think that's problematic, and I'd rather have it for completeness. - I omitted `with_guard` from `NestedLoadBuilder`. This option doesn't really make sense, plus you could just use the async methods to do this instead. - Since we omitted the `with_guard` (since it really doesn't make sense in this context), I decided not to reuse `LoadBuilder` in any way here. Either way, we need to deal with dependencies, so we couldn't just use it directly anyway. - I just created all 9 load variants as separate methods. That's a lot compared to the 4 variants in LoadBuilder. We could reduce it to 6 load variants, if we kept the `with_reader` stuff as a type-state like we did with `NestedLoader`. I'm not a fan of how many variants we have, but I don't think there's a way to do this without opening up impossible configurations, like doing with_reader for a deferred call - this doesn't work!