gh-143923: Reject control characters in POP3 commands

This commit is contained in:
Seth Michael Larson
2026-01-20 14:46:32 -06:00
committed by GitHub
parent f25509e78e
commit b234a2b675
3 changed files with 11 additions and 0 deletions
+2
View File
@@ -122,6 +122,8 @@ class POP3:
def _putcmd(self, line):
if self._debugging: print('*cmd*', repr(line))
line = bytes(line, self.encoding)
if re.search(b'[\x00-\x1F\x7F]', line):
raise ValueError('Control characters not allowed in commands')
self._putline(line)
+8
View File
@@ -17,6 +17,7 @@ from test.support import socket_helper
from test.support import threading_helper
from test.support import asynchat
from test.support import asyncore
from test.support import control_characters_c0
test_support.requires_working_socket(module=True)
@@ -395,6 +396,13 @@ class TestPOP3Class(TestCase):
self.assertIsNone(self.client.sock)
self.assertIsNone(self.client.file)
def test_control_characters(self):
for c0 in control_characters_c0():
with self.assertRaises(ValueError):
self.client.user(f'user{c0}')
with self.assertRaises(ValueError):
self.client.pass_(f'{c0}pass')
@requires_ssl
def test_stls_capa(self):
capa = self.client.capa()
@@ -0,0 +1 @@
Reject control characters in POP3 commands.