cpython

mirror of https://github.com/python/cpython.git synced 2026-07-27 04:12:23 -04:00

Files

T

Mark Dickinson f5f047aa62 gh-96735: Fix undefined behaviour in struct unpacking functions (#96739 )

This PR fixes undefined behaviour in the struct module unpacking support functions `bu_longlong`, `lu_longlong`, `bu_int` and `lu_int`; thanks to @kumaraditya303 for finding these.

The fix is to accumulate the bytes in an unsigned integer type instead of a signed integer type, then to convert to the appropriate signed type. In cases where the width matches, that conversion will typically be compiled away to a no-op.
(Evidence from Godbolt: https://godbolt.org/z/5zvxodj64 .)

To make the conversions efficient, I've specialised the relevant functions for their output size: for `bu_longlong` and `lu_longlong`, this only entails checking that the output size is indeed `8`. But `bu_int` and `lu_int` were used for format sizes `2` and `4` - I've split those into two separate functions each.

No tests, because all of the affected cases are already exercised by the test suite.

2022-09-25 10:55:33 +01:00

_blake2

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_ctypes

gh-95324: Emit a warning if an object doesn't call PyObject_GC_UnTrack during deallocation in debug mode (#95325 )

2022-07-27 16:03:38 +01:00

_decimal

gh-89653: Use int type for Unicode kind (#92704 )

2022-05-13 12:41:05 +02:00

_io

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_multiprocessing

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_sha3

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_sqlite

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_sre

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_ssl

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

_testcapi

GH-91049: Introduce set vectorcall field API for PyFunctionObject (GH-92257)

2022-09-15 16:42:37 +01:00

_xxtestfuzz

bpo-29505: Add fuzzer for ast.literal_eval (GH-28777)

2021-10-06 16:22:09 -07:00

cjkcodecs

gh-90928: Improve static initialization of keywords tuple in AC (#95907 )

2022-08-13 12:09:40 +02:00

clinic

gh-93678: add _testinternalcapi.optimize_cfg() and test utils for compiler optimization unit tests (GH-96007)

2022-08-24 11:02:53 +01:00

expat

gh-97005: Update libexpat from 2.4.7 to 2.4.9 (gh-97006)

2022-09-22 21:25:05 +09:00

_abc.c

gh-95324: Emit a warning if an object doesn't call PyObject_GC_UnTrack during deallocation in debug mode (#95325 )

2022-07-27 16:03:38 +01:00

_asynciomodule.c

gh-95808: Add missing early returns in _asynciomodule.c (#95809 )

2022-08-15 16:32:40 -07:00

_bisectmodule.c

gh-96538: Fix refleak in _bisectmodule.c (gh-96619)

2022-09-06 19:37:18 -04:00

_bz2module.c

gh-94401: Remove unneeded bz2 module state (#94402 )

2022-06-29 17:51:36 +02:00

_codecsmodule.c

gh-90928: Statically Initialize the Keywords Tuple in Clinic-Generated Code (gh-95860)

2022-08-11 15:25:49 -06:00

_collectionsmodule.c

gh-91320: Use _PyCFunction_CAST() (#92251 )

2022-05-03 21:42:14 +02:00

_contextvarsmodule.c

…

_cryptmodule.c

…

_csv.c

gh-89653: Use int type for Unicode kind (#92704 )

2022-05-13 12:41:05 +02:00

_curses_panel.c

…

_cursesmodule.c

GH-94644: fix test_curses ref leak (GH-94647)

2022-07-07 03:57:45 -07:00

_datetimemodule.c

gh-69142: add %:z strftime format code (gh-95983)

2022-08-28 14:27:42 -07:00

_dbmmodule.c

GH-46412: More efficient bool() for ndbm/_gdbmmodule (#96692 )

2022-09-08 19:32:40 -07:00

_elementtree.c

gh-93741: Add private C API _PyImport_GetModuleAttrString() (GH-93742)

2022-06-14 07:15:26 +03:00

_functoolsmodule.c

gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642)

2022-09-07 20:13:07 +09:00

_gdbmmodule.c

GH-46412: More efficient bool() for ndbm/_gdbmmodule (#96692 )

2022-09-08 19:32:40 -07:00

_hashopenssl.c

DOC: correct bytesarray -> bytearray in comments (GH-92410)

2022-06-21 22:04:03 +02:00

_heapqmodule.c

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157)

2021-10-22 15:36:28 +02:00

_json.c

gh-95385 Fastpath for encoding dict to JSON (gh-95374)

2022-08-06 15:55:24 +09:00

_localemodule.c

bpo-47000: Add locale.getencoding() (GH-32068)

2022-04-09 09:54:54 +09:00

_lsprof.c

GH-95045: gc untrack _lsprof.Profiler before deallocating it (GH-95315)

2022-07-27 05:03:50 -07:00

_lzmamodule.c

bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module (GH-31683)

2022-03-05 01:38:56 +09:00

_math.h

bpo-45548: Remove _math.c workarounds for pre-C99 libm (GH-29179)

2021-10-25 01:25:27 -07:00

_opcode.c

gh-94216: add pseudo instructions to the dis/opcodes modules (GH-94241)

2022-07-01 15:33:35 +01:00

_operator.c

DOC: correct bytesarray -> bytearray in comments (GH-92410)

2022-06-21 22:04:03 +02:00

_pickle.c

GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup (GH-94298)

2022-06-28 10:01:43 +03:00

_posixsubprocess.c

gh-82616: Add Py_IS_TYPE_SIGNED() macro (#93178 )

2022-05-27 15:05:35 +02:00

_queuemodule.c

bpo-46613: Add PyType_GetModuleByDef to the public API (GH-31081)

2022-02-11 17:22:11 +01:00

_randommodule.c

gh-90928: Statically Initialize the Keywords Tuple in Clinic-Generated Code (gh-95860)

2022-08-11 15:25:49 -06:00

_scproxy.c

…

_ssl_data_111.h

…

_ssl_data_300.h

…

_ssl_data.h

…

_ssl.c

gh-95095: Use SSL_CTX_get_max_proto_version instead of SSL_CTX_ctrl (GH-95096)

2022-07-21 11:44:30 -07:00

_ssl.h

bpo-46541: remove usage of _Py_IDENTIFIER from _ssl module (GH-31599)

2022-03-02 00:38:21 +09:00

_stat.c

…

_statisticsmodule.c

Statistics inv_cdf sync with corresponding random module normal distributions (#95265 )

2022-07-26 02:23:33 -05:00

_struct.c

gh-96735: Fix undefined behaviour in struct unpacking functions (#96739 )

2022-09-25 10:55:33 +01:00

_testbuffer.c

gh-91320: Use _PyCFunction_CAST() (#92251 )

2022-05-03 21:42:14 +02:00

_testcapi_feature_macros.inc

gh-91324: List feature macros in the stable ABI manifest, improve tests (GH-32415)

2022-04-28 16:30:28 +02:00

_testcapimodule.c

gh-96821: Fix undefined behaviour in _testcapimodule.c (GH-96915)

2022-09-19 15:59:13 +08:00

_testimportmultiple.c

…

_testinternalcapi.c

GH-96237: Allow non-functions as reference-holder in frames. (GH-96238)

2022-08-25 10:16:55 +01:00

_testmultiphase.c

gh-91320: Use _PyCFunction_CAST() (#92251 )

2022-05-03 21:42:14 +02:00

_threadmodule.c

gh-95324: Emit a warning if an object doesn't call PyObject_GC_UnTrack during deallocation in debug mode (#95325 )

2022-07-27 16:03:38 +01:00

_tkinter.c

bpo-46996: Remove support of Tcl/Tk < 8.5.12 (GH-31839)

2022-03-17 13:05:52 +02:00

_tracemalloc.c

GH-96612: Skip incomplete frames in tracemalloc traces. (GH-96613)

2022-09-06 17:37:47 +01:00

_typingmodule.c

…

_uuidmodule.c

bpo-45847: Port _uuid to PY_STDLIB_MOD (GH-29741)

2021-11-24 10:20:37 +01:00

_weakref.c

bpo-46937: convert remaining functions to AC in _weakref (GH-31705)

2022-03-07 18:57:45 +09:00

_winapi.c

bpo-42658: Use LCMapStringEx in ntpath.normcase to match OS behaviour for case-folding (GH-32010)

2022-06-07 00:47:27 +01:00

_xxsubinterpretersmodule.c

gh-93937, C API: Move PyFrame_GetBack() to Python.h (#93938 )

2022-06-19 12:02:33 +02:00

_zoneinfo.c

gh-93741: Add private C API _PyImport_GetModuleAttrString() (GH-93742)

2022-06-14 07:15:26 +03:00

addrinfo.h

gh-95174: WASI: skip missing sockets functions (GH-95179)

2022-07-27 08:19:23 +02:00

arraymodule.c

gh-93741: Add private C API _PyImport_GetModuleAttrString() (GH-93742)

2022-06-14 07:15:26 +03:00

atexitmodule.c

fixes gh-96292: Fix Trivial Typo in cpython/Modules/atexitmodule.c (#96327 )

2022-08-26 22:33:29 -07:00

audioop.c

Deprecate audioop (GH-32392)

2022-04-07 12:27:35 -07:00

binascii.c

gh-93172: Remove unnecessary "if"s in binascii_a2b_qp_impl() from Modules/binascii.c (GH-93181)

2022-05-25 11:38:47 -04:00

cmathmodule.c

bpo-46656: Remove Py_NO_NAN macro (GH-31160)

2022-02-25 01:32:57 +01:00

config.c.in

…

errnomodule.c

gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006)

2022-08-16 20:20:15 +02:00

faulthandler.c

gh-96652: Fix faulthandler chained signal without sigaction() (#96666 )

2022-09-08 12:20:22 +02:00

fcntlmodule.c

gh-93475: Expose FICLONE and FICLONERANGE constants in fcntl (#93478 )

2022-06-06 23:21:58 +02:00

gc_weakref.txt

Fix links to old SF bugs (#95648 )

2022-08-04 18:12:35 +02:00

gcmodule.c

gh-94673: Recover Weaklist Lookup Performance (gh-95544)

2022-08-04 11:28:15 -06:00

getaddrinfo.c

gh-95174: WASI: skip missing sockets functions (GH-95179)

2022-07-27 08:19:23 +02:00

getbuildinfo.c

bpo-45532: Replace 'default' with 'main' as default in sys.version (GH-29100)

2021-10-21 02:09:03 +09:00

getnameinfo.c

gh-95174: WASI: skip missing sockets functions (GH-95179)

2022-07-27 08:19:23 +02:00

getpath_noop.c

bpo-45582: Port getpath[p].c to Python (GH-29041)

2021-12-03 00:08:42 +00:00

getpath.c

bpo-46890: Fix setting of sys._base_executable with framework builds on macOS (GH-31958)

2022-04-05 02:05:36 -04:00

getpath.py

gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006)

2022-08-16 20:20:15 +02:00

grpmodule.c

…

hashlib.h

hashlib: Fix old message about unicode objects. (GH-28653)

2021-10-01 14:38:49 +02:00

itertoolsmodule.c

bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293)

2022-02-15 09:02:21 +09:00

ld_so_aix.in

…

main.c

gh-90473: Check for HAVE_KILL in main.c:exit_sigint (GH-95165)

2022-07-23 12:29:00 +02:00

makesetup

gh-96269: Fix build dependency on AIX (GH-96304)

2022-08-26 12:31:58 +02:00

makexp_aix

…

mathmodule.c

Remove usage of _Py_IDENTIFIER from math module (#93739 )

2022-06-12 18:45:02 +09:00

md5module.c

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157)

2021-10-22 15:36:28 +02:00

mmapmodule.c

gh-94395: Remove unneeded module state from mmap (#94396 )

2022-06-29 07:20:53 +02:00

nismodule.c

gh-91320: Use _PyCFunction_CAST() (#92251 )

2022-05-03 21:42:14 +02:00

ossaudiodev.c

gh-91734: Fix ossaudio support on Solaris (GH-91735)

2022-04-20 13:46:08 +03:00

overlapped.c

gh-95417: Quick fix for "ULONG_PTR differs in levels of indirection from void *" (GH-95538)

2022-08-01 17:30:15 +01:00

posixmodule.c

gh-96143: Allow Linux perf profiler to see Python calls (GH-96123)

2022-08-30 10:11:18 -07:00

posixmodule.h

bpo-41498: Fix build on platforms without sigset_t (GH-29770)

2021-11-25 12:28:41 +01:00

pwdmodule.c

bpo-46670: Remove unused macros in the Modules directory (GH-31194)

2022-02-07 16:21:31 +01:00

pyexpat.c

gh-95853: Address wasm build and test issues (GH-95985)

2022-08-15 07:41:10 +02:00

readline.c

bpo-45434: pyport.h no longer includes <stdlib.h> (GH-28914)

2021-10-13 19:25:53 +02:00

README

…

resource.c

gh-94512: Fix forced arg format in AC-processed resource (GH-94515)

2022-07-29 12:48:11 +01:00

rotatingtree.c

…

rotatingtree.h

…

selectmodule.c

gh-95174: Handle missing dup() and constants in WASI (GH-95229)

2022-07-26 11:16:51 +02:00

Setup

gh-93939: Build C extensions without setup.py (GH-94474)

2022-07-14 00:51:49 -07:00

Setup.bootstrap.in

bpo-47152: Move sources of the _sre module into a subdirectory (GH-32290)

2022-04-04 10:53:26 +03:00

Setup.stdlib.in

gh-93649: Split unicode tests from _testcapimodule.c & add some more (GH-95819)

2022-08-10 09:10:25 +02:00

sha1module.c

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157)

2021-10-22 15:36:28 +02:00

sha256module.c

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157)

2021-10-22 15:36:28 +02:00

sha512module.c

bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157)

2021-10-22 15:36:28 +02:00

signalmodule.c

GH-96754: Check whether the interpreter frame is complete before creating frame object. (GH-96776)

2022-09-13 09:25:16 +01:00

socketmodule.c

gh-95174: WASI: skip missing sockets functions (GH-95179)

2022-07-27 08:19:23 +02:00

socketmodule.h

gh-92658: AF_HYPERV is only supported on Windows (#93192 )

2022-05-25 04:44:57 +02:00

spwdmodule.c

gh-91217: deprecate spwd (#91846 )

2022-04-23 14:48:17 -07:00

symtablemodule.c

…

syslogmodule.c

gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails (GH-95264)

2022-07-26 14:34:15 +03:00

termios.c

Remove trailing spaces. (GH-28706)

2021-10-03 16:58:14 +03:00

testcapi_long.h

…

timemodule.c

gh-93741: Add private C API _PyImport_GetModuleAttrString() (GH-93742)

2022-06-14 07:15:26 +03:00

tkappinit.c

…

tkinter.h

…

unicodedata_db.h

closes gh-96734: Update to Unicode 15.0.0. (GH-96809)

2022-09-13 15:45:12 -07:00

unicodedata.c

closes gh-96734: Update to Unicode 15.0.0. (GH-96809)

2022-09-13 15:45:12 -07:00

unicodename_db.h

closes gh-96734: Update to Unicode 15.0.0. (GH-96809)

2022-09-13 15:45:12 -07:00

winreparse.h

…

xxlimited_35.c

gh-90763: Modernise xx template module initialisation (#93078 )

2022-06-10 12:39:02 +02:00

xxlimited.c

gh-95324: Emit a warning if an object doesn't call PyObject_GC_UnTrack during deallocation in debug mode (#95325 )

2022-07-27 16:03:38 +01:00

xxmodule.c

gh-90763: Modernise xx template module initialisation (#93078 )

2022-06-10 12:39:02 +02:00

xxsubtype.c

gh-91320: Use _PyCFunction_CAST() (#92251 )

2022-05-03 21:42:14 +02:00

zlibmodule.c

bpo-38256: Fix binascii.crc32() when inputs are 4+GiB (GH-32000)

2022-03-20 12:28:15 -07:00

README

Source files for standard library extension modules,
and former extension modules that are now builtin modules.