diff --git a/configure.ac b/configure.ac index de57b3216..f239cd479 100644 --- a/configure.ac +++ b/configure.ac @@ -172,6 +172,13 @@ AC_ARG_ENABLE([gcc-warnings], && gl_gcc_warnings=yes])] ) +# clang is unduly picky about some things, even by default. +if test "$gl_cv_compiler_clang" = yes; then + gl_WARN_ADD([-Wno-format-extra-args]) + gl_WARN_ADD([-Wno-implicit-const-int-float-conversion]) + gl_WARN_ADD([-Wno-tautological-constant-out-of-range-compare]) +fi + if test $gl_gcc_warnings != no; then gl_WARN_ADD([-Werror], [WERROR_CFLAGS]) AC_SUBST([WERROR_CFLAGS]) @@ -232,21 +239,6 @@ if test $gl_gcc_warnings != no; then gl_WARN_ADD([-Wno-unused-parameter]) # Too many warnings for now gl_WARN_ADD([-Wno-format-nonliteral]) - # clang is unduly picky about some things. - AC_CACHE_CHECK([whether the compiler is clang], [utils_cv_clang], - [AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM([[ - #ifndef __clang__ - #error "not clang" - #endif - ]])], - [utils_cv_clang=yes], - [utils_cv_clang=no])]) - if test $utils_cv_clang = yes; then - gl_WARN_ADD([-Wno-format-extra-args]) - gl_WARN_ADD([-Wno-tautological-constant-out-of-range-compare]) - fi - gl_WARN_ADD([-fdiagnostics-show-option]) gl_WARN_ADD([-funit-at-a-time])