Commit Graph

3974 Commits

Author SHA1 Message Date
Jim Meyering c6ec144494 revert previous change 2003-09-18 19:39:12 +00:00
Jim Meyering 3280bf4b55 Update AUTHORS definition to be a comma-separated list of strings and/or update
the call to parse_long_options so that `AUTHORS, NULL' are the last parameters.
2003-09-18 18:22:23 +00:00
Jim Meyering e6a1dc4d4c (case_GETOPT_VERSION_CHAR): Append NULL to version_etc argument list. 2003-09-18 17:39:02 +00:00
Jim Meyering 2ca6722ca4 (main): Append NULL to version_etc argument list. 2003-09-18 17:38:47 +00:00
Jim Meyering df1f0a8083 (numcompare): Rename local, logb, to log_b to avoid
shadowing the math function name.  Also rename loga to log_a.
2003-09-18 16:28:47 +00:00
Jim Meyering b97f8bb5ce (print_factors): Give a separate diagnostic
for numbers that are too large, but otherwise valid.
2003-09-14 17:25:16 +00:00
Jim Meyering adc224e5b1 . 2003-09-10 09:35:07 +00:00
Jim Meyering f29d0b1c91 Alphabetize includes.
Remove duplicate inclusion of "same.h".
2003-09-09 17:25:02 +00:00
Jim Meyering cbd260b93d . 2003-09-09 07:14:03 +00:00
Jim Meyering f0a5c8d223 Add a comment. 2003-09-08 06:08:13 +00:00
Jim Meyering d477526690 (D_INO, ENABLE_CYCLE_CHECK) [D_INO_IN_DIRENT]:
Don't define.  These symbols are no longer used.
2003-09-07 17:33:42 +00:00
Jim Meyering b278b201b5 . 2003-09-07 16:57:30 +00:00
Jim Meyering 93b183e3ad (enum): Add ALLOW_MISSING_OPTION.
(parse_options): Give a diagnostic for (but still accept) the
deprecated --allow-missing option.
2003-09-06 08:49:37 +00:00
Jim Meyering 00b25daa96 . 2003-09-05 20:55:28 +00:00
Jim Meyering 1f4715e0e8 Don't ignore -S if input is a pipe. Bug report by Michael McFarland in
<http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00008.html>.

(sort_buffer_size): Omit SIZE_BOUND arg.  Compute the
size_bound ourselves. if an input file is a pipe and the user
specified a size, use that size instead of trying to guess the
pipe size.  This has the beneficial side effect of avoiding the
overhead of default_sort_size in that case.  All callers changed.
(sort): Remove static var size; now done by sort_buffer_size.
2003-09-05 20:53:08 +00:00
Jim Meyering 1061c70284 (elide_tail_lines_pipe): Don't assign 0 or SAFE_READ_ERROR to tmp->nbytes.
(struct linebuffer): Change nbytes and nlines
from unsigned int to size_t.  unsigned int is safe (after the
2003-09-03 patch) but size_t is cleaner.

Standardize on BUFSIZ as opposed to other macro names and values.
(BUFSIZE): Remove.  All uses changed to BUFSIZ.
2003-09-05 20:45:26 +00:00
Jim Meyering 968be3baa5 (pipe_lines, pipe_bytes): Don't assign 0 or SAFE_READ_ERROR to tmp->nbytes.
(struct linebuffer, struct charbuffer): Change nbytes and nlines from
unsigned int to size_t.  unsigned int is safe (after the 2003-09-03 patch)
but size_t is cleaner.
(pipe_bytes): Likewise for local variable 'i', which was 'int'.

Standardize on BUFSIZ as opposed to other macro names and values.

(BUFSIZ) [!defined BUFSIZ]: Remove. stdio.h has always defined it,
and other code already assumes it's defined.
2003-09-05 20:44:20 +00:00
Jim Meyering 51fe03e45c Standardize on BUFSIZ as opposed to other macro names and values.
(BUFSIZ) [!defined BUFSIZ]: Don't define.
(IO_BUF_SIZE): Remove; replace all uses with sizeof io_buf.
(io_buf): IO_BUF_SIZE -> BUFSIZ.
2003-09-05 14:27:27 +00:00
Jim Meyering 1ba2d9615e (step): Default to 1.
(print_numbers): Allow the output to be empty.
(main): The default step is 1, even if LAST < FIRST;
as per documentation.
2003-09-05 06:54:59 +00:00
Jim Meyering 221e569fbf This makes seq's --width (-w) option work properly even when the
endpoint requiring the largest width is negative and smaller than
the other endpoint.

(get_width_format): Include `-' in the set of bytes
allowed in a `simple' number (no decimal point, no exponent).
2003-09-04 22:21:25 +00:00
Jim Meyering 70293df29a (usage): Say "blanks" instead of "whitespace",
Similar fixes for many comments.
(TAB_DEFAULT): New constant, so that we can support NUL as
the field separator.
(tab): Now int, not char.  Initialize to TAB_DEFAULT.
(specify_sort_size): If multiple sizes are specified, use the largest.
(begfield, limfield): Support NUL tab char.
(set_ordering): Do not let -i override -d.
(main): Report an error if incompatible -o or -t options are given.
Report an error for "-t ''".  Allow "-t '\0'" to specify a NUL tab.
2003-09-04 22:12:59 +00:00
Jim Meyering 169a0a3f49 (elide_tail_lines_pipe): Don't truncate return value from safe_read. 2003-09-04 21:43:35 +00:00
Jim Meyering 7750d1ac2d (pipe_lines): Don't truncate return value from safe_read. 2003-09-04 21:43:12 +00:00
Jim Meyering 6f3fcc3168 (AUTHORS): Remove Larry McVoy's name, since the relatively
small amount of code from him was first moved to lib/human.c, and was
subsequently rewritten entirely.
2003-09-03 08:53:19 +00:00
Jim Meyering 7b1f0fa519 (split_3): Accept the BSD format for generic
message digest modes.  Currently works with BSD's MD5 and SHA1
formats since these are the two algorithms presently used in
coreutils.  Updated comments to reflect this change.
(bsd_split_3): Updated comments.
2003-08-31 11:11:10 +00:00
Jim Meyering a78c9ec4f0 Change meaning of -l from --lookup to --login, per POSIX.
who's -l option has been eliciting an unconditional warning about
this impending change since sh-utils-2.0.12 (April 2002).
2003-08-31 08:24:41 +00:00
Jim Meyering 27a8f1e732 (do_link): Use SAME_INODE rather than open-coding it. 2003-08-30 20:26:42 +00:00
Jim Meyering 97bf7dae4f When source and destination arguments refer to the same file, reside
on a partition (e.g. VFAT) on which distinct names may refer to the
same directory entry (often due to variations in case), and when the
link count for the file is 1, mv no longer unlinks the file.
FIXME: this is a band-aid fix.  If the file happens to have a link
count of 2 or greater, mv will still unlink it.

(same_file_ok): Invoke same_name (which might still
return false for names that refer to the same directory entry)
only if the link count is 2 or more.
2003-08-30 18:13:23 +00:00
Jim Meyering 5bd780f6a3 (paste_parallel): Don't output EOF' (aka -1) as a char'.
This would happen for nonempty files not ending with a newline.
2003-08-27 11:41:49 +00:00
Jim Meyering ddc3343bf9 . 2003-08-27 09:04:55 +00:00
Jim Meyering e37cd8f9f4 (print_it): Avoid buffer overrun that would occur
when the user-specified format string ends with `%'.
2003-08-27 08:55:01 +00:00
Jim Meyering 6bb625621f (main): Warn about use of deprecated `-l' option. 2003-08-25 07:39:26 +00:00
Jim Meyering c63799d99d (do_stat): For link count at end of line, use %h format,
instead of %-5h.  The latter would make stat emit trailing spaces.
2003-08-22 08:20:05 +00:00
Jim Meyering 941b28ec5b . 2003-08-19 21:05:04 +00:00
Jim Meyering 6a27043931 Include stdlib.h unconditionally,
as we're now assuming that part of hosted C89.
2003-08-19 10:07:33 +00:00
Jim Meyering 74ed024a23 (textdomain, bindtextdomain) [! ENABLE_NLS]: Define away,
to avoid warnings from gcc.
2003-08-18 12:09:42 +00:00
Jim Meyering afb16a5a4a . 2003-08-18 09:45:27 +00:00
Jim Meyering 4d863fd68b (strtoull): Remove unused declaration. 2003-08-17 17:48:14 +00:00
Jim Meyering f976fd6f38 Avoid unnecessary and sometimes time-consuming hostname lookups.
(print_user): Likewise.

This fixes a typo I introduced in who-users.c on 1996-02-23.
2003-08-17 16:04:00 +00:00
Jim Meyering 7cea884787 Avoid unnecessary and sometimes time-consuming hostname lookups.
(print_entry): Likewise.

This fixes a typo I introduced in who-users.c on 1996-02-23.
2003-08-17 16:03:42 +00:00
Jim Meyering 1ead947b79 . 2003-08-17 07:49:10 +00:00
Jim Meyering f6008be14a (tail_lines): Fix a potential (but very hard to exercise)
race condition bug.  The bug would be triggered when tailing a file
with file pointer not at beginning of file, and where the file was
truncated to have a length of less than the initial offset at just
the right moment (between the two lseek calls in this function).
2003-08-16 17:34:41 +00:00
Jim Meyering f4be51104a An invalid initial value for *read_pos would result in
`tail -n0 -f FILE' and `tail -c0 -f FILE' doing what amounted to a
busy-wait rather than sleeping between iterations.  The bug manifests
itself only when tailing regular files that are initially nonempty.

(tail_bytes): Set *read_pos to new file offset after
each xlseek call.
(tail_lines): Likewise, after lseek calls.
2003-08-16 17:28:33 +00:00
Jim Meyering dcdee393d7 . 2003-08-15 06:54:15 +00:00
Jim Meyering 4f6b3338a1 (ASSORT): New var.
(check-README, ../AUTHORS): Use it.
2003-08-15 06:53:02 +00:00
Jim Meyering 11d239448d . 2003-08-15 06:43:29 +00:00
Jim Meyering 31f092ff08 . 2003-08-11 18:25:04 +00:00
Jim Meyering d761e22b60 fold -s -wN would infloop for N < 8 with TABs in the input.
E.g., this would not terminate: printf 'a\tb' | fold -w2 -s

(fold_file): Move contents of `else'-block
out of conditional so it's used also for --spaces (-s).
2003-08-11 14:35:52 +00:00
Jim Meyering cc664579f8 [!NICE_PRIORITY]: Include <sys/resource.h> after
system.h so the types from time.h and sys/time.h are available.
It appears that this is necessary for OpenBSD, NetBSD, and
Darwin 6.5 (MacOS 10.2.5).  Reported by Nelson Beebe.
2003-08-10 17:50:11 +00:00
Jim Meyering 9b1bd49df2 Include utimens.h.
Set file timestamps with utimens, not utime.
2003-08-09 18:35:07 +00:00