Commit Graph

4240 Commits

Author SHA1 Message Date
Jim Meyering c9736bdff0 Remove xstat function pointer member. The way it was used was not
portable, since some systems (OSF V5.1, Solaris 2.5.1) provide static
inline `stat' and `lstat' functions, thus making the tests of
`xstat == lstat' in copy.c always fail.

(copy_dir): Set `.dereference' member, not .xstat.
(copy_internal): Use `XSTAT (x, ...)' in place of `*(x->xstat) (...)'.
Use `x->dereference == DEREF_NEVER' in place of `x->xstat == lstat'.
(valid_options): Remove now-obsolete FIXME comments.
2004-02-07 16:00:28 +00:00
Jim Meyering 5937c873e6 (human_time): Correct merge problem. 2004-02-05 13:46:41 +00:00
Jim Meyering ad669dfe92 Don't dump core if localtime returns NULL (possible on
hosts with 64-bit time_t and 32-bit int).

Print "??" if the current clock can't
be converted by localtime.  This won't happen until the year
2*31 + 1900, but we don't want to dump core even if the current
clock has the wrong value.
2004-02-05 09:51:49 +00:00
Jim Meyering c904b0cae6 Don't dump core if localtime returns NULL (possible on
hosts with 64-bit time_t and 32-bit int).

Include "inttostr.h".
(batch_convert, main):
If time conversion fails, exit with nonzero status.
(show_date): Return int to report conversion failure.
Print the time as an int if localtime fails.
2004-02-05 09:50:18 +00:00
Jim Meyering adc816c05a Include "inttostr.h".
(human_time): Print the date/time as a number of seconds since the
epoch if it can't be converted by localtime.  This is better than
just saying "invalid", and is consistent with what "ls" does.
Don't dump core if the year has more than 48 digits; this isn't
possible on any contemporary host, but we might as well do it right.
2004-02-05 09:47:01 +00:00
Jim Meyering e32369feb8 (human_time): Accept time rather than pointer-to-const-time parameter,
for clarity.  All callers changed.
2004-02-05 09:34:33 +00:00
Jim Meyering 143799aecc (ST_TIME_CMP_NS, ST_TIME_CMP): Remove definitions.
(ATIME_CMP, CTIME_CMP, MTIME_CMP, TIMESPEC_NS): Likewise.
Now, those are all defined in timespec.h.
Include timespec.h.
2004-02-05 09:26:52 +00:00
Jim Meyering f37f61b461 Don't include timespec.h, now that system.h does it. 2004-02-05 09:24:05 +00:00
Jim Meyering e8416c5e12 (print_numbers): Use 'double' for loop index, not
'int', to avoid problems with integer overflow.  On almost all
machines 'double' works in every case where 'int' works, and
it works on other cases besides.
2004-02-03 18:40:25 +00:00
Jim Meyering fa377fd8c1 (do_stat): Remove extra trailing newline from default formats. 2004-02-02 17:33:11 +00:00
Jim Meyering c057bb50b5 Print actual fractional seconds in time stamps, not just `.00000000'.
(human_time): Add and use new parameter, t_ns.
(print_stat): Update callers.
2004-02-02 07:59:58 +00:00
Jim Meyering dd42ad9e9c (TIMESPEC_NS): Define here, instead, now that stat.c also uses this macro. 2004-02-02 07:59:35 +00:00
Jim Meyering 19b1ba88d5 (TIMESPEC_NS): Remove definition. 2004-02-02 07:59:23 +00:00
Jim Meyering 058f602aeb Reword so as not to exclude the possibility that INCREMENT be zero. 2004-01-27 13:09:16 +00:00
Jim Meyering 395de8b154 . 2004-01-23 18:48:03 +00:00
Jim Meyering a28a8b7cef (paste_parallel): Declare local, chr, to be of type
`int', not `char', since it must hold EOF.  This bug would make
paste infloop on some systems.
2004-01-23 09:26:24 +00:00
Jim Meyering f915f22d85 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant assignments.
(TTY_FAILURE, TTY_WRITE_ERROR): New enum values;
substitute them for the corresponding integer constants.
2004-01-22 21:09:33 +00:00
Jim Meyering 5dd7058439 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(FATAL_ERROR, main): Exit with status EXIT_FAILURE, not 2, on errors.
2004-01-22 21:07:40 +00:00
Jim Meyering b8d43c9437 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(err): Now a boolean int, not a counter,
so that we don't have to worry about int overflow.  All uses changed.
2004-01-22 21:04:26 +00:00
Jim Meyering ae3cdb71e9 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant
assignments.
2004-01-22 21:03:13 +00:00
Jim Meyering 78ac13ca26 (initialize_exit_failure): New inline function.
Include exitfail.h here, since we refer to exit_failure.
All callers changed to not include exitfail.h.

(EXIT_FAIL, EXIT_CANNOT_INVOKE, EXIT_ENOENT): New enum values.
2004-01-22 21:02:22 +00:00
Jim Meyering bfa5295dc0 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Initialize exit_failure to EXIT_FAIL.

(main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
rather than roll-your-own symbols or integers.
2004-01-22 21:00:25 +00:00
Jim Meyering 6d524623b0 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Exit with status 1, not 2, on errors detected by stty proper.
2004-01-22 20:58:59 +00:00
Jim Meyering 0d9b52c3c2 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant
assignments.

Don't include <assert.h>.
(SORT_OUT_OF_ORDER,  SORT_FAILURE): Now enums, not macros.
(usage): Don't use 'assert'.
(main): Remove redundant assignment to exit_failure.
2004-01-22 20:55:26 +00:00
Jim Meyering 3d8656e3e2 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Likewise, to SETUIDGID_FAILURE.

(SETUIDGID_FAILURE): Renamed from FAIL_STATUS,
for consistency with other programs here.  All uses changed.
(main): Use 'error' to exit rather than invoking 'exit' here.
2004-01-22 20:53:55 +00:00
Jim Meyering faa1322508 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(print_numbers): Now returns void, not (zero) int.
All callers changed.
(main): Remove unused local variable 'errs'.  Always exit successfully
if we reach the end.
2004-01-22 20:51:09 +00:00
Jim Meyering fe09b6ce94 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(remove_parents): Don't set 'fail' to a negative number.
(main): Avoid integer overflow when seeing whether errors occurred.
2004-01-22 20:48:38 +00:00
Jim Meyering 57a460665c (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than setting
exit_failure directly; this optimizes away redundant assignments.

(PRINTENV_FAILURE): New constant.
(main): Exit with status PRINTENV_FAILURE, not EXIT_FAILURE, on
command-line syntax problems.
2004-01-22 20:44:15 +00:00
Jim Meyering bdb46518ee (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(FATAL_ERROR, main): Exit with status EXIT_FAILURE, not 2, on errors.
2004-01-22 19:49:47 +00:00
Jim Meyering d5c5ccc461 (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:50:20 +00:00
Jim Meyering 1a013f63f9 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:50:13 +00:00
Jim Meyering 68e999b21f (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:49:31 +00:00
Jim Meyering 36504c3b09 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:49:15 +00:00
Jim Meyering 7b9611e50e (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:47:48 +00:00
Jim Meyering 69e2df952e (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:47:17 +00:00
Jim Meyering 88a8689c36 (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:46:53 +00:00
Jim Meyering 7388206118 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:46:07 +00:00
Jim Meyering 4b5c8fe387 (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:45:53 +00:00
Jim Meyering d2692db85a (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:45:43 +00:00
Jim Meyering 623c8ae147 (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:45:21 +00:00
Jim Meyering eb844044d5 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:45:13 +00:00
Jim Meyering eb5ac5fa4a (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:44:47 +00:00
Jim Meyering 6618936d9d (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Don't assume EXIT_FAILURE == 1, as POSIX doesn't require it.
2004-01-21 23:39:34 +00:00
Jim Meyering 3e397c67aa (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:38:45 +00:00
Jim Meyering f1c86ce433 (usage): Use EXIT_SUCCESS, not 0, for clarity. 2004-01-21 23:38:15 +00:00
Jim Meyering c979cdc1e3 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:37:54 +00:00
Jim Meyering cdc257accd (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Initialize exit_failure to EXIT_FAIL.
(main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
rather than roll-your-own symbols or integers.
(NOHUP_FOUND_BUT_CANNOT_INVOKE): Remove; all uses
changed to EXIT_CANNOT_INVOKE.
2004-01-21 23:31:33 +00:00
Jim Meyering d2e7cd3b7a (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(main): Exit with status 1, not 2, on errors detected by nl proper.
2004-01-21 23:30:09 +00:00
Jim Meyering 11f893d2de (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Initialize exit_failure to EXIT_FAIL.
(main): Exit with status EXIT_FAIL, not EXIT_FAILURE,
on error; this is in case EXIT_FAILURE is unusual.
2004-01-21 23:28:19 +00:00
Jim Meyering efb59b228c (usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Don't assume EXIT_FAILURE == 1, as POSIX doesn't require it.
2004-01-21 23:23:14 +00:00