mirror of
git://git.sv.gnu.org/coreutils
synced 2026-05-07 15:39:34 -04:00
Collin Funk
2de1a28bcf
Previously the string from strerror would only be printed for some
algorithms:
$ cksum -a sha2 -l 256 /dev/null > /dev/full
cksum: write error: No space left on device
$ cksum -a sysv /dev/null > /dev/full
cksum: write error
This patch fixes it so that the error information is always printed:
$ ./src/cksum -a sha2 -l 256 /dev/null > /dev/full
cksum: write error: No space left on device
$ ./src/cksum -a sysv /dev/null > /dev/full
cksum: write error: No space left on device
* src/cksum.c (output_file): Don't check for a write error here.
(main): Check for it here instead.
* tests/misc/io-errors.sh: Add a 'cksum' invocation for each supported
algorithm.
https://github.com/coreutils/coreutils/issues/258
134 lines
3.9 KiB
Bash
Executable File
134 lines
3.9 KiB
Bash
Executable File
#!/bin/sh
|
|
# Make sure all of these programs diagnose write errors.
|
|
|
|
# Copyright (C) 2025-2026 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
|
|
print_ver_ env
|
|
getlimits_
|
|
|
|
if ! test -w /dev/full || ! test -c /dev/full; then
|
|
skip_ '/dev/full is required'
|
|
fi
|
|
|
|
echo foo > foo || framework_failure_
|
|
|
|
# Specific write paths to check in addition to --version.
|
|
# Note writers that may output data indefinitely
|
|
# are handled in write-errors.sh.
|
|
# Commands tagged with $generic are not checked for a specific error.
|
|
# First word in command line is checked against built programs
|
|
{
|
|
printf '%s' "\
|
|
cat foo
|
|
cksum -a sysv foo
|
|
cksum -a bsd foo
|
|
cksum -a crc foo
|
|
cksum -a crc32b foo
|
|
cksum -a md5 foo
|
|
cksum -a sha1 foo
|
|
cksum -a sha2 -l 256 foo
|
|
cksum -a sha3 -l 256 foo
|
|
cksum -a blake2b foo
|
|
cksum -a sm3 foo
|
|
comm foo foo
|
|
cut -c1- foo
|
|
cut -f1- foo
|
|
date +%s
|
|
dd status=none if=foo
|
|
expand foo
|
|
factor 1
|
|
fmt foo
|
|
fold foo
|
|
fold -b foo
|
|
fold -c foo
|
|
groups
|
|
head -n1 foo
|
|
id
|
|
join foo foo
|
|
nl foo
|
|
numfmt --invalid=ignore < foo
|
|
od -v foo
|
|
paste foo
|
|
pr foo
|
|
seq 1
|
|
tac --version; seq 10000 | tac
|
|
tail -n1 foo
|
|
tee < foo
|
|
tr . . < foo
|
|
unexpand foo
|
|
uniq foo
|
|
";
|
|
printf '%s --version $generic\n' $built_programs;
|
|
} |
|
|
sort -k 1b,1 > all_writers || framework_failure_
|
|
|
|
printf '%s\n' $built_programs |
|
|
sort -k 1b,1 > built_programs || framework_failure_
|
|
|
|
join all_writers built_programs > built_writers || framework_failure_
|
|
|
|
while read writer; do
|
|
|
|
# Skip edge cases
|
|
printf '%s' "$writer" | grep -E '^(test|false|true|install)' &&
|
|
{ echo "Skipping $writer" >&2; continue; }
|
|
|
|
# Check /dev/full diagnosed.
|
|
# Note we usually give a specific diagnostic (ENOSPC),
|
|
# but that's not guaranteed in the generic close_stream() handling.
|
|
# For e.g. with _IOLBF etc, stdio will discard pending data at each line,
|
|
# thus only giving a generic error upon ferror() in close_stream().
|
|
ere="$ENOSPC|$EBADF"
|
|
|
|
# musl writes the first line immediately when it should be fully buffered.
|
|
# As a result, when we print a single line there is no bytes buffered when
|
|
# we close the stream and errno is not set. See:
|
|
# <https://www.openwall.com/lists/musl/2026/04/02/1>.
|
|
case $host_os in
|
|
*-musl*) ere="$ere|" ;;
|
|
esac
|
|
|
|
printf '%s' "$writer" | grep 'generic' >/dev/null &&
|
|
{ ere="write error|$ere"; }
|
|
|
|
rm -f full.err || framework_failure_
|
|
timeout 10 env --default-signal=PIPE $SHELL -c \
|
|
"(env $writer 2>full.err >/dev/full)"
|
|
{ test $? = 124 || test $? = 0 || ! grep -E "$ere" full.err >/dev/null; } &&
|
|
{ fail=1; cat full.err; echo "$writer: failed to diagose ENOSPC" >&2; }
|
|
|
|
# Check closed stdout handling
|
|
rm -f closed.err || framework_failure_
|
|
timeout 10 env --default-signal=PIPE $SHELL -c \
|
|
"(env $writer 2>closed.err >&-)"
|
|
{ test $? = 124 || test $? = 0 || ! grep -E "$ere" closed.err >/dev/null; } &&
|
|
{ fail=1; cat closed.err; echo "$writer: failed to diagnose EBADF" >&2; }
|
|
|
|
# https://github.com/ksh93/ksh/issues/741
|
|
$SHELL -c 'test -n "$KSH_VERSION"' && continue
|
|
|
|
# Check closed pipe handling
|
|
rm -f pipe.err || framework_failure_
|
|
timeout 10 env --default-signal=PIPE $SHELL -c \
|
|
"(env $writer 2>pipe.err | :)"
|
|
{ test $? = 0 && compare /dev/null pipe.err; } ||
|
|
{ fail=1; cat pipe.err; echo "$writer: failed writing to closed pipe" >&2; }
|
|
|
|
done < built_writers
|
|
|
|
Exit $fail
|