Pádraig Brady 5e5d454037 shred: fix pattern selection for certain iteration counts ...

This was detected in about 25% of runs with gcc -fsanitize=address

  ERROR: AddressSanitizer: global-buffer-overflow on address ...
  READ of size 4 at 0x000000416628 thread T0
    #0 0x40479f in genpattern src/shred.c:782
    #1 0x4050d9 in do_wipefd src/shred.c:921
    #2 0x406203 in wipefile src/shred.c:1175
    #3 0x406b84 in main src/shred.c:1316
    #4 0x7f3454a1ef9f in __libc_start_main (/lib64/libc.so.6+0x1ff9f)
    #5 0x4025d8 (/tmp/coreutils-8.23/src/shred+0x4025d8)
  0x000000416628 is located 56 bytes to the left of
  global variable '*.LC49' from 'src/shred.c' (0x416660) of size 17
  0x000000416628 is located 12 bytes to the right of
  global variable 'patterns' from 'src/shred.c' (0x416540) of size 220
  SUMMARY: AddressSanitizer: global-buffer-overflow src/shred.c:782

* src/shred.c (gen_patterns): Restrict pattern selection
to the K available, which regressed due to v5.92-1462-g65533e1.
* tests/misc/shred-passes.sh: Add a deterministic test case.
* NEWS: Mention the bug fix.
Fixes http://bugs.gnu.org/20998

2015-07-07 03:26:58 +01:00

..

arch.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

base64.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

basename.pl

doc,maint: fix use of "i.e." in documentation and comments

2015-01-31 17:39:04 +01:00

cat-buf.sh

tests: cleanup background processes upon interruption

2015-05-11 23:02:16 +01:00

cat-proc.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

cat-self.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

chcon-fail.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

chcon.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

chroot-credentials.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

chroot-fail.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

close-stdout.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

comm.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

coreutils.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

csplit-1000.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

csplit-heap.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

csplit-suppress-matched.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

csplit.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

cut-huge-range.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

cut.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

date-next-dow.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

date-sec.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

date.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

dircolors.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

dirname.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

env-null.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

env.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

expand.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

expr.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

factor-parallel.sh

factor: avoid interspersed lines for parallel runs

2015-06-24 17:04:01 +01:00

factor.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

false-status.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

fold.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

groups-dash.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

groups-version.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

head-c.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

head-elide-tail.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

head-pos.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

head-write-error.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

head.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

help-version.sh

tests: avoid side effects of $SHELL environment variable

2015-07-03 13:02:21 +01:00

invalid-opt.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

join.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

ls-misc.pl

doc,maint: fix use of "i.e." in documentation and comments

2015-01-31 17:39:04 +01:00

ls-time.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

md5sum-bsd.sh

doc,maint: fix use of "i.e." in documentation and comments

2015-01-31 17:39:04 +01:00

md5sum-newline.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

md5sum-parallel.sh

tests: fix false failure in recent test adjustment

2015-06-06 14:27:54 +01:00

md5sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

mknod.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

mktemp.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

nice-fail.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

nice.sh

tests: use compare-vs-/dev/null instead of 'test -s'

2015-01-14 17:38:12 +01:00

nl.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

nohup.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

nproc-avail.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

nproc-positive.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

numfmt.pl

tests: avoid false failures on OpenBSD 5.7

2015-07-02 19:15:08 +01:00

od-endian.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

od-float.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

od-j.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

od-multiple-t.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

od-N.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

od-x8.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

od.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

paste.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

pathchk1.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

printenv.sh

tests: avoid a FP on aarch64 when comparing env/printenv output

2015-02-03 02:19:54 +01:00

printf-cov.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

printf-hex.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

printf-surprise.sh

tests: cleanup background processes upon interruption

2015-05-11 23:02:16 +01:00

printf.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

ptx-overrun.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

ptx.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

pwd-long.sh

tests: avoid side effects of $SHELL environment variable

2015-07-03 13:02:21 +01:00

pwd-option.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

readlink-fp-loop.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

readlink-root.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

realpath.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

runcon-no-reorder.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

selinux.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

seq-long-double.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

seq-precision.sh

seq: handle exponents more consistently

2015-06-24 17:04:01 +01:00

seq.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sha1sum-vec.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sha1sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sha224sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sha256sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sha384sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sha512sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

shred-exact.sh

doc,maint: fix use of "i.e." in documentation and comments

2015-01-31 17:39:04 +01:00

shred-passes.sh

shred: fix pattern selection for certain iteration counts

2015-07-07 03:26:58 +01:00

shred-remove.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

shred-size.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

shuf-reservoir.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

shuf.sh

maint: clean up some test issues identified with shellcheck

2015-01-10 21:18:33 +00:00

sort-benchmark-random.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-compress-hang.sh

tests: avoid side effects of $SHELL environment variable

2015-07-03 13:02:21 +01:00

sort-compress-proc.sh

tests: avoid side effects of $SHELL environment variable

2015-07-03 13:02:21 +01:00

sort-compress.sh

tests: avoid side effects of $SHELL environment variable

2015-07-03 13:02:21 +01:00

sort-continue.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-debug-keys.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-debug-warn.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-discrim.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-exit-early.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

sort-files0-from.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-float.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-merge-fdlimit.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-merge.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-month.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-NaN-infloop.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-rand.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-spinlock-abuse.sh

tests: cleanup background processes upon interruption

2015-05-11 23:02:16 +01:00

sort-stale-thread-mem.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-u-FMR.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-unique-segv.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-unique.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort-version.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sort.pl

doc,maint: fix use of "i.e." in documentation and comments

2015-01-31 17:39:04 +01:00

stat-birthtime.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stat-fmt.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stat-hyphen.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

stat-mount.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stat-nanoseconds.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stat-printf.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stat-slash.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

stdbuf.sh

tests: cleanup background processes upon interruption

2015-05-11 23:02:16 +01:00

stty-invalid.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

stty-pairs.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stty-row-col.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

stty.sh

tests: avoid false failure on FreeBSD systems

2015-07-01 12:27:29 +01:00

sum-sysv.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sum.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

sync.sh

tests: avoid false failure when running as root

2015-06-25 14:10:47 +01:00

tac-2-nonseekable.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

tac-continue.sh

tests: cleanup background processes upon interruption

2015-05-11 23:02:16 +01:00

tac.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

tail.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

tee.sh

tee: generalize the --write-error option to --output-error

2015-03-04 13:24:21 +00:00

test-diag.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

test.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

timeout-blocked.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

timeout-group.sh

tests: avoid side effects of $SHELL environment variable

2015-07-03 13:02:21 +01:00

timeout-parameters.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

timeout.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

tr-case-class.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

tr.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

truncate-dangling-symlink.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

truncate-dir-fail.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

truncate-fail-diag.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

truncate-fifo.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

truncate-no-create-missing.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

truncate-overflow.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

truncate-owned-by-other.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

truncate-parameters.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

truncate-relative.sh

tests: add extra protection against unexpected exits

2015-01-14 12:20:32 +00:00

tsort.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

tty-eof.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

unexpand.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

uniq-perf.sh

tests: fix false failure on loaded systems

2015-06-01 15:38:23 +01:00

uniq.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

wc-files0-from.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

wc-files0.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

wc-parallel.sh

tests: fix false failure in recent test adjustment

2015-06-06 14:27:54 +01:00

wc-proc.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

wc.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

xattr.sh

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

xstrtol.pl

maint: update all copyright year number ranges

2015-01-01 04:52:17 +00:00

yes.sh

yes: improve efficiency when all args aren't buffered

2015-03-10 12:30:33 +00:00