/* Copyright (c) 2017-2022, Arvid Norberg Copyright (c) 2017, Steven Siloti Copyright (c) 2018, Alden Torres Copyright (c) 2018, d-komarov All rights reserved. You may use, distribute and modify this code under the terms of the BSD license, see LICENSE file. */ #include "libtorrent/session.hpp" #include "libtorrent/session_params.hpp" #include "libtorrent/torrent_handle.hpp" #include "libtorrent/torrent_status.hpp" #include "libtorrent/session_settings.hpp" #include "libtorrent/torrent_info.hpp" #include "libtorrent/ip_filter.hpp" #include "libtorrent/add_torrent_params.hpp" #include "libtorrent/aux_/path.hpp" #include "test.hpp" #include "test_utils.hpp" #include "setup_transfer.hpp" #include "settings.hpp" #include #include #include using namespace libtorrent; namespace lt = libtorrent; using std::ignore; namespace { enum test_case { complete_download, partial_download, mid_download, double_remove, }; void test_remove_torrent(remove_flags_t const remove_options , test_case const test = complete_download) { // this allows shutting down the sessions in parallel std::vector sp; settings_pack pack = settings(); pack.set_str(settings_pack::listen_interfaces, test_listen_interface()); lt::session ses1(pack); pack.set_str(settings_pack::listen_interfaces, test_listen_interface()); lt::session ses2(pack); torrent_handle tor1; torrent_handle tor2; int const num_pieces = (test == mid_download) ? 500 : 100; error_code ec; remove_all("tmp1_remove", ec); remove_all("tmp2_remove", ec); create_directory("tmp1_remove", ec); std::ofstream file("tmp1_remove/temporary"); add_torrent_params atp = ::create_torrent(&file, "temporary" , 8 * 1024, num_pieces, false, create_torrent::v1_only); file.close(); wait_for_listen(ses1, "ses1"); wait_for_listen(ses2, "ses2"); // test using piece sizes smaller than 16kB std::tie(tor1, tor2, ignore) = setup_transfer(&ses1, &ses2, nullptr , true, false, true, "_remove", 8 * 1024, &atp, false, true, false, nullptr , create_torrent::v1_only); if (test == partial_download) { std::vector priorities(std::size_t(num_pieces), low_priority); // set half of the pieces to priority 0 std::fill(priorities.begin(), priorities.begin() + (num_pieces / 2), dont_download); tor2.prioritize_pieces(priorities); } else if (test == mid_download) { tor1.set_upload_limit(static_cast(atp.ti->total_size())); tor2.set_download_limit(static_cast(atp.ti->total_size())); } torrent_status st1; torrent_status st2; for (int i = 0; i < 200; ++i) { print_alerts(ses1, "ses1", true, true); print_alerts(ses2, "ses2", true, true); st1 = tor1.status(); std::cout << "st1.total_payload_upload: " << st1.total_payload_upload << '\n'; std::cout << "st2.num_pieces: " << st2.num_pieces << '\n'; st2 = tor2.status(); if (test == mid_download && st2.num_pieces > 1) { TEST_CHECK(st2.is_finished == false); break; } if (st2.is_finished) break; TEST_CHECK(st1.state == torrent_status::seeding || st1.state == torrent_status::checking_resume_data || st1.state == torrent_status::checking_files); TEST_CHECK(st2.state == torrent_status::downloading || st2.state == torrent_status::checking_resume_data); // if nothing is being transferred after 4 seconds, we're failing the test if (st1.total_payload_upload == 0 && i > 40) { TEST_ERROR("no transfer"); return; } std::this_thread::sleep_for(lt::milliseconds(100)); } TEST_CHECK(st1.num_pieces > 0); TEST_CHECK(st2.num_pieces > 0); ses2.remove_torrent(tor2, remove_options); ses1.remove_torrent(tor1, remove_options); if (test == double_remove) { ses2.remove_torrent(tor2, remove_options); ses1.remove_torrent(tor1, remove_options); } std::cerr << "removed" << std::endl; for (int i = 0; tor2.is_valid() || tor1.is_valid(); ++i) { std::this_thread::sleep_for(lt::milliseconds(100)); if (++i > 400) { std::cerr << "torrent handle(s) still valid: " << (tor1.is_valid() ? "tor1 " : "") << (tor2.is_valid() ? "tor2 " : "") << std::endl; TEST_ERROR("handle did not become invalid"); return; } } if (remove_options & session::delete_files) { TEST_CHECK(!exists("tmp1_remove/temporary")); TEST_CHECK(!exists("tmp2_remove/temporary")); } sp.push_back(ses1.abort()); sp.push_back(ses2.abort()); } } // anonymous namespace TORRENT_TEST(remove_torrent) { test_remove_torrent({}); } TORRENT_TEST(remove_torrent_and_files) { test_remove_torrent(session::delete_files); } TORRENT_TEST(remove_torrent_files_and_partfile) { test_remove_torrent(session::delete_files | session::delete_partfile); } TORRENT_TEST(remove_torrent_and_just_partfile) { test_remove_torrent(session::delete_partfile); } TORRENT_TEST(remove_torrent_partial) { test_remove_torrent({}, partial_download); } TORRENT_TEST(remove_torrent_and_files_partial) { test_remove_torrent(session::delete_files, partial_download); } TORRENT_TEST(remove_torrent_mid_download) { test_remove_torrent({}, mid_download); } TORRENT_TEST(remove_torrent_and_files_mid_download) { test_remove_torrent(session::delete_files, mid_download); } TORRENT_TEST(remove_torrent_twice) { test_remove_torrent({}, double_remove); } TORRENT_TEST(remove_torrent_and_files_twice) { test_remove_torrent(session::delete_files, double_remove); } // Cover the race fixed in commit "fix race when removing an auto managed // torrent": an auto-managed torrent must not be re-inserted into any of // session_impl::m_torrent_lists once abort() has started, otherwise the // list is left with a dangling pointer when the torrent destructs. // Tight active_* limits make auto-manage actively shuffle torrents, // widening the window where the bug used to trigger. A regression will // fire the new TORRENT_ASSERT(!l.in_list()) in ~torrent() under debug // builds, or surface as a use-after-free under sanitizers. TORRENT_TEST(remove_auto_managed_torrent) { settings_pack pack = settings(); pack.set_str(settings_pack::listen_interfaces, test_listen_interface()); pack.set_int(settings_pack::active_downloads, 1); pack.set_int(settings_pack::active_seeds, 1); pack.set_int(settings_pack::active_limit, 1); lt::session ses(pack); error_code ec; remove_all("tmp_auto_remove", ec); create_directory("tmp_auto_remove", ec); std::ofstream file("tmp_auto_remove/temporary"); add_torrent_params atp = ::create_torrent(&file, "temporary", 8 * 1024, 4, false, create_torrent::v1_only); file.close(); atp.save_path = "tmp_auto_remove"; atp.flags |= torrent_flags::auto_managed; atp.flags &= ~torrent_flags::paused; torrent_handle h = ses.add_torrent(atp); // let the auto-manager pick it up and place it in one of the // torrent_lists (downloading/seeding/checking) for (int i = 0; i < 20; ++i) { print_alerts(ses, "ses", true, true); std::this_thread::sleep_for(lt::milliseconds(50)); } ses.remove_torrent(h); for (int i = 0; h.is_valid() && i < 100; ++i) { print_alerts(ses, "ses", true, true); std::this_thread::sleep_for(lt::milliseconds(50)); } TEST_CHECK(!h.is_valid()); session_proxy sp = ses.abort(); }