mirror of
https://github.com/postgres/postgres.git
synced 2026-06-08 08:34:03 -04:00
1d2fe56e42
PL/Python failed if a PL/Python function was invoked recursively via SPI, since arguments are passed to the function in its global dictionary (a horrible decision that's far too ancient to undo) and it would delete those dictionary entries on function exit, leaving the outer recursion level(s) without any arguments. Not deleting them would be little better, since the outer levels would then see the innermost level's arguments. Since PL/Python uses ValuePerCall mode for evaluating set-returning functions, it's possible for multiple executions of the same SRF to be interleaved within a query. PL/Python failed in such a case, because it stored only one iterator per function, directly in the function's PLyProcedure struct. Moreover, one interleaved instance of the SRF would see argument values that should belong to another. Hence, invent code for saving and restoring the argument entries. To fix the recursion case, we only need to save at recursive entry and restore at recursive exit, so the overhead in non-recursive cases is negligible. To fix the SRF case, we have to save when suspending a SRF and restore when resuming it, which is potentially not negligible; but fortunately this is mostly a matter of manipulating Python object refcounts and should not involve much physical data copying. Also, store the Python iterator and saved argument values in a structure associated with the SRF call site rather than the function itself. This requires adding a memory context deletion callback to ensure that the SRF state is cleaned up if the calling query exits before running the SRF to completion. Without that we'd leak a refcount to the iterator object in such a case, resulting in session-lifespan memory leakage. (In the pre-existing code, there was no memory leak because there was only one iterator pointer, but what would happen is that the previous iterator would be resumed by the next query attempting to use the SRF. Hardly the semantics we want.) We can buy back some of whatever overhead we've added by getting rid of PLy_function_delete_args(), which seems a useless activity: there is no need to delete argument entries from the global dictionary on exit, since the next time anyone would see the global dict is on the next fresh call of the PL/Python function, at which time we'd overwrite those entries with new arg values anyway. Also clean up some really ugly coding in the SRF implementation, including such gems as returning directly out of a PG_TRY block. (The only reason that failed to crash hard was that all existing call sites immediately exited their own PG_TRY blocks, popping the dangling longjmp pointer before there was any chance of it being used.) In principle this is a bug fix; but it seems a bit too invasive relative to its value for a back-patch, and besides the fix depends on memory context callbacks so it could not go back further than 9.5 anyway. Alexey Grishchenko and Tom Lane
547 lines
14 KiB
C
547 lines
14 KiB
C
/*
|
|
* Python procedure manipulation for plpython
|
|
*
|
|
* src/pl/plpython/plpy_procedure.c
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
#include "access/htup_details.h"
|
|
#include "access/transam.h"
|
|
#include "funcapi.h"
|
|
#include "catalog/pg_proc.h"
|
|
#include "catalog/pg_proc_fn.h"
|
|
#include "catalog/pg_type.h"
|
|
#include "utils/builtins.h"
|
|
#include "utils/hsearch.h"
|
|
#include "utils/inval.h"
|
|
#include "utils/memutils.h"
|
|
#include "utils/syscache.h"
|
|
|
|
#include "plpython.h"
|
|
|
|
#include "plpy_procedure.h"
|
|
|
|
#include "plpy_elog.h"
|
|
#include "plpy_main.h"
|
|
|
|
|
|
static HTAB *PLy_procedure_cache = NULL;
|
|
|
|
static PLyProcedure *PLy_procedure_create(HeapTuple procTup, Oid fn_oid, bool is_trigger);
|
|
static bool PLy_procedure_argument_valid(PLyTypeInfo *arg);
|
|
static bool PLy_procedure_valid(PLyProcedure *proc, HeapTuple procTup);
|
|
static char *PLy_procedure_munge_source(const char *name, const char *src);
|
|
|
|
|
|
void
|
|
init_procedure_caches(void)
|
|
{
|
|
HASHCTL hash_ctl;
|
|
|
|
memset(&hash_ctl, 0, sizeof(hash_ctl));
|
|
hash_ctl.keysize = sizeof(PLyProcedureKey);
|
|
hash_ctl.entrysize = sizeof(PLyProcedureEntry);
|
|
PLy_procedure_cache = hash_create("PL/Python procedures", 32, &hash_ctl,
|
|
HASH_ELEM | HASH_BLOBS);
|
|
}
|
|
|
|
/*
|
|
* Get the name of the last procedure called by the backend (the
|
|
* innermost, if a plpython procedure call calls the backend and the
|
|
* backend calls another plpython procedure).
|
|
*
|
|
* NB: this returns the SQL name, not the internal Python procedure name
|
|
*/
|
|
char *
|
|
PLy_procedure_name(PLyProcedure *proc)
|
|
{
|
|
if (proc == NULL)
|
|
return "<unknown procedure>";
|
|
return proc->proname;
|
|
}
|
|
|
|
/*
|
|
* PLy_procedure_get: returns a cached PLyProcedure, or creates, stores and
|
|
* returns a new PLyProcedure.
|
|
*
|
|
* fn_oid is the OID of the function requested
|
|
* fn_rel is InvalidOid or the relation this function triggers on
|
|
* is_trigger denotes whether the function is a trigger function
|
|
*
|
|
* The reason that both fn_rel and is_trigger need to be passed is that when
|
|
* trigger functions get validated we don't know which relation(s) they'll
|
|
* be used with, so no sensible fn_rel can be passed.
|
|
*/
|
|
PLyProcedure *
|
|
PLy_procedure_get(Oid fn_oid, Oid fn_rel, bool is_trigger)
|
|
{
|
|
bool use_cache = !(is_trigger && fn_rel == InvalidOid);
|
|
HeapTuple procTup;
|
|
PLyProcedureKey key;
|
|
PLyProcedureEntry *volatile entry = NULL;
|
|
PLyProcedure *volatile proc = NULL;
|
|
bool found = false;
|
|
|
|
procTup = SearchSysCache1(PROCOID, ObjectIdGetDatum(fn_oid));
|
|
if (!HeapTupleIsValid(procTup))
|
|
elog(ERROR, "cache lookup failed for function %u", fn_oid);
|
|
|
|
/*
|
|
* Look for the function in the cache, unless we don't have the necessary
|
|
* information (e.g. during validation). In that case we just don't cache
|
|
* anything.
|
|
*/
|
|
if (use_cache)
|
|
{
|
|
key.fn_oid = fn_oid;
|
|
key.fn_rel = fn_rel;
|
|
entry = hash_search(PLy_procedure_cache, &key, HASH_ENTER, &found);
|
|
proc = entry->proc;
|
|
}
|
|
|
|
PG_TRY();
|
|
{
|
|
if (!found)
|
|
{
|
|
/* Haven't found it, create a new procedure */
|
|
proc = PLy_procedure_create(procTup, fn_oid, is_trigger);
|
|
if (use_cache)
|
|
entry->proc = proc;
|
|
}
|
|
else if (!PLy_procedure_valid(proc, procTup))
|
|
{
|
|
/* Found it, but it's invalid, free and reuse the cache entry */
|
|
entry->proc = NULL;
|
|
if (proc)
|
|
PLy_procedure_delete(proc);
|
|
proc = PLy_procedure_create(procTup, fn_oid, is_trigger);
|
|
entry->proc = proc;
|
|
}
|
|
/* Found it and it's valid, it's fine to use it */
|
|
}
|
|
PG_CATCH();
|
|
{
|
|
/* Do not leave an uninitialised entry in the cache */
|
|
if (use_cache)
|
|
hash_search(PLy_procedure_cache, &key, HASH_REMOVE, NULL);
|
|
PG_RE_THROW();
|
|
}
|
|
PG_END_TRY();
|
|
|
|
ReleaseSysCache(procTup);
|
|
|
|
return proc;
|
|
}
|
|
|
|
/*
|
|
* Create a new PLyProcedure structure
|
|
*/
|
|
static PLyProcedure *
|
|
PLy_procedure_create(HeapTuple procTup, Oid fn_oid, bool is_trigger)
|
|
{
|
|
char procName[NAMEDATALEN + 256];
|
|
Form_pg_proc procStruct;
|
|
PLyProcedure *volatile proc;
|
|
MemoryContext cxt;
|
|
MemoryContext oldcxt;
|
|
int rv;
|
|
char *ptr;
|
|
|
|
procStruct = (Form_pg_proc) GETSTRUCT(procTup);
|
|
rv = snprintf(procName, sizeof(procName),
|
|
"__plpython_procedure_%s_%u",
|
|
NameStr(procStruct->proname),
|
|
fn_oid);
|
|
if (rv >= sizeof(procName) || rv < 0)
|
|
elog(ERROR, "procedure name would overrun buffer");
|
|
|
|
/* Replace any not-legal-in-Python-names characters with '_' */
|
|
for (ptr = procName; *ptr; ptr++)
|
|
{
|
|
if (!((*ptr >= 'A' && *ptr <= 'Z') ||
|
|
(*ptr >= 'a' && *ptr <= 'z') ||
|
|
(*ptr >= '0' && *ptr <= '9')))
|
|
*ptr = '_';
|
|
}
|
|
|
|
cxt = AllocSetContextCreate(TopMemoryContext,
|
|
procName,
|
|
ALLOCSET_DEFAULT_MINSIZE,
|
|
ALLOCSET_DEFAULT_INITSIZE,
|
|
ALLOCSET_DEFAULT_MAXSIZE);
|
|
|
|
oldcxt = MemoryContextSwitchTo(cxt);
|
|
|
|
proc = (PLyProcedure *) palloc0(sizeof(PLyProcedure));
|
|
proc->mcxt = cxt;
|
|
|
|
PG_TRY();
|
|
{
|
|
Datum protrftypes_datum;
|
|
Datum prosrcdatum;
|
|
bool isnull;
|
|
char *procSource;
|
|
int i;
|
|
|
|
proc->proname = pstrdup(NameStr(procStruct->proname));
|
|
proc->pyname = pstrdup(procName);
|
|
proc->fn_xmin = HeapTupleHeaderGetRawXmin(procTup->t_data);
|
|
proc->fn_tid = procTup->t_self;
|
|
proc->fn_readonly = (procStruct->provolatile != PROVOLATILE_VOLATILE);
|
|
proc->is_setof = procStruct->proretset;
|
|
PLy_typeinfo_init(&proc->result, proc->mcxt);
|
|
proc->src = NULL;
|
|
proc->argnames = NULL;
|
|
for (i = 0; i < FUNC_MAX_ARGS; i++)
|
|
PLy_typeinfo_init(&proc->args[i], proc->mcxt);
|
|
proc->nargs = 0;
|
|
proc->langid = procStruct->prolang;
|
|
protrftypes_datum = SysCacheGetAttr(PROCOID, procTup,
|
|
Anum_pg_proc_protrftypes,
|
|
&isnull);
|
|
proc->trftypes = isnull ? NIL : oid_array_to_list(protrftypes_datum);
|
|
proc->code = NULL;
|
|
proc->statics = NULL;
|
|
proc->globals = NULL;
|
|
proc->calldepth = 0;
|
|
proc->argstack = NULL;
|
|
|
|
/*
|
|
* get information required for output conversion of the return value,
|
|
* but only if this isn't a trigger.
|
|
*/
|
|
if (!is_trigger)
|
|
{
|
|
HeapTuple rvTypeTup;
|
|
Form_pg_type rvTypeStruct;
|
|
|
|
rvTypeTup = SearchSysCache1(TYPEOID,
|
|
ObjectIdGetDatum(procStruct->prorettype));
|
|
if (!HeapTupleIsValid(rvTypeTup))
|
|
elog(ERROR, "cache lookup failed for type %u",
|
|
procStruct->prorettype);
|
|
rvTypeStruct = (Form_pg_type) GETSTRUCT(rvTypeTup);
|
|
|
|
/* Disallow pseudotype result, except for void or record */
|
|
if (rvTypeStruct->typtype == TYPTYPE_PSEUDO)
|
|
{
|
|
if (procStruct->prorettype == TRIGGEROID)
|
|
ereport(ERROR,
|
|
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
|
|
errmsg("trigger functions can only be called as triggers")));
|
|
else if (procStruct->prorettype != VOIDOID &&
|
|
procStruct->prorettype != RECORDOID)
|
|
ereport(ERROR,
|
|
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
|
|
errmsg("PL/Python functions cannot return type %s",
|
|
format_type_be(procStruct->prorettype))));
|
|
}
|
|
|
|
if (rvTypeStruct->typtype == TYPTYPE_COMPOSITE ||
|
|
procStruct->prorettype == RECORDOID)
|
|
{
|
|
/*
|
|
* Tuple: set up later, during first call to
|
|
* PLy_function_handler
|
|
*/
|
|
proc->result.out.d.typoid = procStruct->prorettype;
|
|
proc->result.out.d.typmod = -1;
|
|
proc->result.is_rowtype = 2;
|
|
}
|
|
else
|
|
{
|
|
/* do the real work */
|
|
PLy_output_datum_func(&proc->result, rvTypeTup, proc->langid, proc->trftypes);
|
|
}
|
|
|
|
ReleaseSysCache(rvTypeTup);
|
|
}
|
|
|
|
/*
|
|
* Now get information required for input conversion of the
|
|
* procedure's arguments. Note that we ignore output arguments here.
|
|
* If the function returns record, those I/O functions will be set up
|
|
* when the function is first called.
|
|
*/
|
|
if (procStruct->pronargs)
|
|
{
|
|
Oid *types;
|
|
char **names,
|
|
*modes;
|
|
int pos,
|
|
total;
|
|
|
|
/* extract argument type info from the pg_proc tuple */
|
|
total = get_func_arg_info(procTup, &types, &names, &modes);
|
|
|
|
/* count number of in+inout args into proc->nargs */
|
|
if (modes == NULL)
|
|
proc->nargs = total;
|
|
else
|
|
{
|
|
/* proc->nargs was initialized to 0 above */
|
|
for (i = 0; i < total; i++)
|
|
{
|
|
if (modes[i] != PROARGMODE_OUT &&
|
|
modes[i] != PROARGMODE_TABLE)
|
|
(proc->nargs)++;
|
|
}
|
|
}
|
|
|
|
proc->argnames = (char **) palloc0(sizeof(char *) * proc->nargs);
|
|
for (i = pos = 0; i < total; i++)
|
|
{
|
|
HeapTuple argTypeTup;
|
|
Form_pg_type argTypeStruct;
|
|
|
|
if (modes &&
|
|
(modes[i] == PROARGMODE_OUT ||
|
|
modes[i] == PROARGMODE_TABLE))
|
|
continue; /* skip OUT arguments */
|
|
|
|
Assert(types[i] == procStruct->proargtypes.values[pos]);
|
|
|
|
argTypeTup = SearchSysCache1(TYPEOID,
|
|
ObjectIdGetDatum(types[i]));
|
|
if (!HeapTupleIsValid(argTypeTup))
|
|
elog(ERROR, "cache lookup failed for type %u", types[i]);
|
|
argTypeStruct = (Form_pg_type) GETSTRUCT(argTypeTup);
|
|
|
|
/* check argument type is OK, set up I/O function info */
|
|
switch (argTypeStruct->typtype)
|
|
{
|
|
case TYPTYPE_PSEUDO:
|
|
/* Disallow pseudotype argument */
|
|
ereport(ERROR,
|
|
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
|
|
errmsg("PL/Python functions cannot accept type %s",
|
|
format_type_be(types[i]))));
|
|
break;
|
|
case TYPTYPE_COMPOSITE:
|
|
/* we'll set IO funcs at first call */
|
|
proc->args[pos].is_rowtype = 2;
|
|
break;
|
|
default:
|
|
PLy_input_datum_func(&(proc->args[pos]),
|
|
types[i],
|
|
argTypeTup,
|
|
proc->langid,
|
|
proc->trftypes);
|
|
break;
|
|
}
|
|
|
|
/* get argument name */
|
|
proc->argnames[pos] = names ? pstrdup(names[i]) : NULL;
|
|
|
|
ReleaseSysCache(argTypeTup);
|
|
|
|
pos++;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* get the text of the function.
|
|
*/
|
|
prosrcdatum = SysCacheGetAttr(PROCOID, procTup,
|
|
Anum_pg_proc_prosrc, &isnull);
|
|
if (isnull)
|
|
elog(ERROR, "null prosrc");
|
|
procSource = TextDatumGetCString(prosrcdatum);
|
|
|
|
PLy_procedure_compile(proc, procSource);
|
|
|
|
pfree(procSource);
|
|
}
|
|
PG_CATCH();
|
|
{
|
|
MemoryContextSwitchTo(oldcxt);
|
|
PLy_procedure_delete(proc);
|
|
PG_RE_THROW();
|
|
}
|
|
PG_END_TRY();
|
|
|
|
MemoryContextSwitchTo(oldcxt);
|
|
return proc;
|
|
}
|
|
|
|
/*
|
|
* Insert the procedure into the Python interpreter
|
|
*/
|
|
void
|
|
PLy_procedure_compile(PLyProcedure *proc, const char *src)
|
|
{
|
|
PyObject *crv = NULL;
|
|
char *msrc;
|
|
|
|
proc->globals = PyDict_Copy(PLy_interp_globals);
|
|
|
|
/*
|
|
* SD is private preserved data between calls. GD is global data shared by
|
|
* all functions
|
|
*/
|
|
proc->statics = PyDict_New();
|
|
PyDict_SetItemString(proc->globals, "SD", proc->statics);
|
|
|
|
/*
|
|
* insert the function code into the interpreter
|
|
*/
|
|
msrc = PLy_procedure_munge_source(proc->pyname, src);
|
|
/* Save the mangled source for later inclusion in tracebacks */
|
|
proc->src = MemoryContextStrdup(proc->mcxt, msrc);
|
|
crv = PyRun_String(msrc, Py_file_input, proc->globals, NULL);
|
|
pfree(msrc);
|
|
|
|
if (crv != NULL)
|
|
{
|
|
int clen;
|
|
char call[NAMEDATALEN + 256];
|
|
|
|
Py_DECREF(crv);
|
|
|
|
/*
|
|
* compile a call to the function
|
|
*/
|
|
clen = snprintf(call, sizeof(call), "%s()", proc->pyname);
|
|
if (clen < 0 || clen >= sizeof(call))
|
|
elog(ERROR, "string would overflow buffer");
|
|
proc->code = Py_CompileString(call, "<string>", Py_eval_input);
|
|
if (proc->code != NULL)
|
|
return;
|
|
}
|
|
|
|
if (proc->proname)
|
|
PLy_elog(ERROR, "could not compile PL/Python function \"%s\"",
|
|
proc->proname);
|
|
else
|
|
PLy_elog(ERROR, "could not compile anonymous PL/Python code block");
|
|
}
|
|
|
|
void
|
|
PLy_procedure_delete(PLyProcedure *proc)
|
|
{
|
|
Py_XDECREF(proc->code);
|
|
Py_XDECREF(proc->statics);
|
|
Py_XDECREF(proc->globals);
|
|
MemoryContextDelete(proc->mcxt);
|
|
}
|
|
|
|
/*
|
|
* Check if our cached information about a datatype is still valid
|
|
*/
|
|
static bool
|
|
PLy_procedure_argument_valid(PLyTypeInfo *arg)
|
|
{
|
|
HeapTuple relTup;
|
|
bool valid;
|
|
|
|
/* Nothing to cache unless type is composite */
|
|
if (arg->is_rowtype != 1)
|
|
return true;
|
|
|
|
/*
|
|
* Zero typ_relid means that we got called on an output argument of a
|
|
* function returning an unnamed record type; the info for it can't
|
|
* change.
|
|
*/
|
|
if (!OidIsValid(arg->typ_relid))
|
|
return true;
|
|
|
|
/* Else we should have some cached data */
|
|
Assert(TransactionIdIsValid(arg->typrel_xmin));
|
|
Assert(ItemPointerIsValid(&arg->typrel_tid));
|
|
|
|
/* Get the pg_class tuple for the data type */
|
|
relTup = SearchSysCache1(RELOID, ObjectIdGetDatum(arg->typ_relid));
|
|
if (!HeapTupleIsValid(relTup))
|
|
elog(ERROR, "cache lookup failed for relation %u", arg->typ_relid);
|
|
|
|
/* If it has changed, the cached data is not valid */
|
|
valid = (arg->typrel_xmin == HeapTupleHeaderGetRawXmin(relTup->t_data) &&
|
|
ItemPointerEquals(&arg->typrel_tid, &relTup->t_self));
|
|
|
|
ReleaseSysCache(relTup);
|
|
|
|
return valid;
|
|
}
|
|
|
|
/*
|
|
* Decide whether a cached PLyProcedure struct is still valid
|
|
*/
|
|
static bool
|
|
PLy_procedure_valid(PLyProcedure *proc, HeapTuple procTup)
|
|
{
|
|
int i;
|
|
bool valid;
|
|
|
|
if (proc == NULL)
|
|
return false;
|
|
|
|
/* If the pg_proc tuple has changed, it's not valid */
|
|
if (!(proc->fn_xmin == HeapTupleHeaderGetRawXmin(procTup->t_data) &&
|
|
ItemPointerEquals(&proc->fn_tid, &procTup->t_self)))
|
|
return false;
|
|
|
|
/* Else check the input argument datatypes */
|
|
valid = true;
|
|
for (i = 0; i < proc->nargs; i++)
|
|
{
|
|
valid = PLy_procedure_argument_valid(&proc->args[i]);
|
|
|
|
/* Short-circuit on first changed argument */
|
|
if (!valid)
|
|
break;
|
|
}
|
|
|
|
/* if the output type is composite, it might have changed */
|
|
if (valid)
|
|
valid = PLy_procedure_argument_valid(&proc->result);
|
|
|
|
return valid;
|
|
}
|
|
|
|
static char *
|
|
PLy_procedure_munge_source(const char *name, const char *src)
|
|
{
|
|
char *mrc,
|
|
*mp;
|
|
const char *sp;
|
|
size_t mlen;
|
|
int plen;
|
|
|
|
/*
|
|
* room for function source and the def statement
|
|
*/
|
|
mlen = (strlen(src) * 2) + strlen(name) + 16;
|
|
|
|
mrc = palloc(mlen);
|
|
plen = snprintf(mrc, mlen, "def %s():\n\t", name);
|
|
Assert(plen >= 0 && plen < mlen);
|
|
|
|
sp = src;
|
|
mp = mrc + plen;
|
|
|
|
while (*sp != '\0')
|
|
{
|
|
if (*sp == '\r' && *(sp + 1) == '\n')
|
|
sp++;
|
|
|
|
if (*sp == '\n' || *sp == '\r')
|
|
{
|
|
*mp++ = '\n';
|
|
*mp++ = '\t';
|
|
sp++;
|
|
}
|
|
else
|
|
*mp++ = *sp++;
|
|
}
|
|
*mp++ = '\n';
|
|
*mp++ = '\n';
|
|
*mp = '\0';
|
|
|
|
if (mp > (mrc + mlen))
|
|
elog(FATAL, "buffer overrun in PLy_munge_source");
|
|
|
|
return mrc;
|
|
}
|