sqlalchemy

mirror of https://github.com/sqlalchemy/sqlalchemy.git synced 2026-05-13 12:17:28 -04:00

Files

T

Mike Bayer 6221c53ca8 catch all BaseException in pool and revert failed checkouts

Fixed a long-standing race condition in the connection pool which could
occur under eventlet/gevent monkeypatching schemes in conjunction with the
use of eventlet/gevent ``Timeout`` conditions, where a connection pool
checkout that's interrupted due to the timeout would fail to clean up the
failed state, causing the underlying connection record and sometimes the
database connection itself to "leak", leaving the pool in an invalid state
with unreachable entries. This issue was first identified and fixed in
SQLAlchemy 1.2 for 🎫`4225`, however the failure modes detected in
that fix failed to accommodate for ``BaseException``, rather than
``Exception``, which prevented eventlet/gevent ``Timeout`` from being
caught. In addition, a block within initial pool connect has also been
identified and hardened with a ``BaseException`` -> "clean failed connect"
block to accommodate for the same condition in this location.
Big thanks to Github user @niklaus for their tenacious efforts in
identifying and describing this intricate issue.

Fixes: #8974
Change-Id: I95a0e1f080d0cee6f1a66977432a586fdf87f686

2022-12-13 09:45:22 -05:00

__init__.py

…

test_ddlevents.py

Revert automatic set of sequence start to 1

2022-10-17 15:36:25 -04:00

test_deprecations.py

ensure pool.reset event always called for reset

2022-10-30 15:43:19 -04:00

test_execute.py

Try running pyupgrade on the code

2022-11-16 23:03:04 +01:00