PublicArchive/supabase
2
0
Fork 0
mirror of https://github.com/supabase/supabase.git synced 2026-05-06 08:56:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(edge functions secrets): allow read-only role to read secrets metadata (#40667)

Browse Source 
According to our API permissions model, the read-only role can also read
secrets metadata (the actual secret itself is not viewable by anybdoy).
Updating the frontend UI to match.
This commit is contained in:
Charis
2025-11-21 10:57:34 -05:00
committed by GitHub
parent 25dc1efb9f
commit 11aa71bc2a
4 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/studio/components/interfaces/Functions/EdgeFunctionSecrets/EdgeFunctionSecrets.tsx
+14 -9
View File
@@ -18,22 +18,25 @@ import AddNewSecretForm from './AddNewSecretForm'
import EdgeFunctionSecret from './EdgeFunctionSecret'
import { EditSecretSheet } from './EditSecretSheet'
const EdgeFunctionSecrets = () => {
export const EdgeFunctionSecrets = () => {
const { ref: projectRef } = useParams()
const [searchString, setSearchString] = useState('')
// Track the ID being deleted to exclude it from error checking
const deletingSecretNameRef = useRef<string | null>(null)
const { can: canReadSecrets, isLoading: isLoadingPermissions } = useAsyncCheckPermissions(
PermissionAction.SECRETS_READ,
const { can: canReadSecrets, isLoading: isLoadingSecretsPermissions } = useAsyncCheckPermissions(
PermissionAction.FUNCTIONS_SECRET_READ,
'*'
)
const { can: canUpdateSecrets } = useAsyncCheckPermissions(PermissionAction.SECRETS_WRITE, '*')
const { data, error, isLoading, isSuccess, isError } = useSecretsQuery({
projectRef: projectRef,
})
const { data, error, isLoading, isSuccess, isError } = useSecretsQuery(
{
projectRef: projectRef,
},
{ enabled: canReadSecrets }
)
const { setValue: setSelectedSecretToEdit, value: selectedSecretToEdit } =
useQueryStateWithSelect({
@@ -82,10 +85,14 @@ const EdgeFunctionSecrets = () => {
<TableHead key="actions" />,
]
const showLoadingState = isLoadingSecretsPermissions || (canReadSecrets && isLoading)
return (
<>
{isLoading || isLoadingPermissions ? (
{showLoadingState ? (
<GenericSkeletonLoader />
) : !canReadSecrets ? (
<NoPermission resourceText="view this project's edge function secrets" />
) : (
<>
{isError && <AlertError error={error} subject="Failed to retrieve project secrets" />}
@@ -187,5 +194,3 @@ const EdgeFunctionSecrets = () => {
</>
)
}
export default EdgeFunctionSecrets
apps/studio/package.json
+1 -1
View File
@@ -62,7 +62,7 @@
"@supabase/mcp-utils": "^0.2.0",
"@supabase/pg-meta": "workspace:*",
"@supabase/realtime-js": "catalog:",
"@supabase/shared-types": "0.1.80",
"@supabase/shared-types": "0.1.83",
"@supabase/sql-to-rest": "^0.1.6",
"@supabase/supabase-js": "catalog:",
"@tanstack/react-query": "^4.42.0",
apps/studio/pages/project/[ref]/functions/secrets.tsx
+1 -1
View File
@@ -1,4 +1,4 @@
import EdgeFunctionSecrets from 'components/interfaces/Functions/EdgeFunctionSecrets/EdgeFunctionSecrets'
import { EdgeFunctionSecrets } from 'components/interfaces/Functions/EdgeFunctionSecrets/EdgeFunctionSecrets'
import { FunctionsSecretsEmptyStateLocal } from 'components/interfaces/Functions/FunctionsEmptyState'
import DefaultLayout from 'components/layouts/DefaultLayout'
import EdgeFunctionsLayout from 'components/layouts/EdgeFunctionsLayout/EdgeFunctionsLayout'
pnpm-lock.yaml
Generated
+5 -5
View File
@@ -859,8 +859,8 @@ importers:
specifier: 'catalog:'
version: 2.83.0
'@supabase/shared-types':
specifier: 0.1.80
version: 0.1.80
specifier: 0.1.83
version: 0.1.83
'@supabase/sql-to-rest':
specifier: ^0.1.6
version: 0.1.6(encoding@0.1.13)(supports-color@8.1.1)
@@ -8856,8 +8856,8 @@ packages:
resolution: {integrity: sha512-mT+QeXAD2gLoqNeQFLjTloDM62VR+VFV8OVdF8RscYpXZriBhabTLE2Auff5lkEJetFFclP1B8j+YtgrWqSmeA==}
engines: {node: '>=20.0.0'}
'@supabase/shared-types@0.1.80':
resolution: {integrity: sha512-U2ACit34Up5OzB53dthb50YVGcAUzkuWn0Wq9fXWDdfl4Wlp+euWKSSVUMUIQo+bf2phu3V/PmVHEWR6dpls1g==}
'@supabase/shared-types@0.1.83':
resolution: {integrity: sha512-hKXExQKLU9FvUCpDsMKtP/EN+qma5SL+pxd44D06OmwV1UnOUqBwgUvO0nUyF2vV32jKRNaWsf2o+IDJ3pATJA==}
'@supabase/sql-to-rest@0.1.6':
resolution: {integrity: sha512-06KgjeINtc6405XQvfnchBE1azEsU8G2NElfadmvVHKmHa5l2bFzjbtFbpaYgpgTzccHlcDmBaCgedVf2Gyl8Q==}
@@ -28456,7 +28456,7 @@ snapshots:
- bufferutil
- utf-8-validate
'@supabase/shared-types@0.1.80': {}
'@supabase/shared-types@0.1.83': {}
'@supabase/sql-to-rest@0.1.6(encoding@0.1.13)(supports-color@8.1.1)':
dependencies: