mirror of
https://github.com/supabase/supabase.git
synced 2026-05-08 09:50:33 -04:00
45ffa97240
Splits the Edge Function secrets page into two sections so reserved Supabase env vars are always visible, even on new projects without any user secrets created. <img width="1605" height="1006" alt="Screenshot 2026-04-29 at 12 20 43 PM" src="https://github.com/user-attachments/assets/fc74f10e-557d-45bb-b0f0-66a706a9facb" /> **Added:** - `DefaultEdgeFunctionSecrets` component — a read-only reference list (Name + Description) of every `SUPABASE_*`, `SB_*`, and `DENO_*` env var available in every project, sourced from [the docs](https://supabase.com/docs/guides/functions/secrets#default-secrets) - `isInternalEdgeFunctionSecret` helper used to filter the custom secrets table **Changed:** - The custom secrets section now renders first (more actionable), with the educational default secrets section below it - Custom secrets table now filters out anything matching `SUPABASE_*` or any of the hardcoded default names **Removed:** - `isReservedSecret` regex check + its tooltip branches in `EdgeFunctionSecret.tsx` — dead code now that the custom table never receives an internal secret Addresses [FE-3096](https://linear.app/supabase/issue/FE-3096/split-edge-function-secrets-into-internal-and-user-defined-views). ## To test - Open `/project/_/functions/secrets` on a fresh project (no custom secrets) - "Default secrets" section is visible and lists all 9 env vars with descriptions - "Custom secrets" section shows the empty state - Create a custom secret — appears in the Custom section, not the Default section - Edit/delete dropdown still works on custom secrets - Search input only filters the custom secrets table <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a "Default secrets" section showing built-in edge-function secrets with names, descriptions, and a "Deprecated" badge where applicable. * Secret names are clickable to copy to clipboard with a success notification; secret names/values use inline code styling. * UI now separates "Custom secrets" and "Default secrets" with distinct empty states. * **Bug Fixes** * Edit/Delete controls reflect actual permission state (no longer disabled for default/reserved secrets). * **Tests** * Added tests for default-secret detection and visibility rules. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com> Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
71 lines
1.7 KiB
TypeScript
71 lines
1.7 KiB
TypeScript
import { toast } from 'sonner'
|
|
import {
|
|
Badge,
|
|
Card,
|
|
copyToClipboard,
|
|
Table,
|
|
TableBody,
|
|
TableCell,
|
|
TableHead,
|
|
TableHeader,
|
|
TableRow,
|
|
Tooltip,
|
|
TooltipContent,
|
|
TooltipTrigger,
|
|
} from 'ui'
|
|
|
|
import type { DefaultEdgeFunctionSecret } from './DefaultEdgeFunctionSecrets.utils'
|
|
|
|
interface DefaultEdgeFunctionSecretsProps {
|
|
secrets: DefaultEdgeFunctionSecret[]
|
|
}
|
|
|
|
export const DefaultEdgeFunctionSecrets = ({ secrets }: DefaultEdgeFunctionSecretsProps) => {
|
|
return (
|
|
<Card>
|
|
<Table>
|
|
<TableHeader>
|
|
<TableRow>
|
|
<TableHead>Name</TableHead>
|
|
<TableHead>Description</TableHead>
|
|
</TableRow>
|
|
</TableHeader>
|
|
<TableBody>
|
|
{secrets.map((secret) => (
|
|
<SecretRow key={secret.name} secret={secret} />
|
|
))}
|
|
</TableBody>
|
|
</Table>
|
|
</Card>
|
|
)
|
|
}
|
|
|
|
const SecretRow = ({ secret }: { secret: DefaultEdgeFunctionSecret }) => {
|
|
return (
|
|
<TableRow key={secret.name}>
|
|
<TableCell>
|
|
<div className="flex items-center gap-x-2 py-1">
|
|
<Tooltip>
|
|
<TooltipTrigger
|
|
onClick={() => {
|
|
copyToClipboard(secret.name)
|
|
toast.success(`Copied ${secret.name}`)
|
|
}}
|
|
>
|
|
<p className="truncate">
|
|
<code className="text-code-inline">{secret.name}</code>
|
|
</p>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="bottom">Click to copy</TooltipContent>
|
|
</Tooltip>
|
|
|
|
{secret.isDeprecated && <Badge variant="warning">Deprecated</Badge>}
|
|
</div>
|
|
</TableCell>
|
|
<TableCell>
|
|
<p className="text-sm text-foreground-light">{secret.description}</p>
|
|
</TableCell>
|
|
</TableRow>
|
|
)
|
|
}
|