mirror of
https://github.com/supabase/supabase.git
synced 2026-06-29 11:57:37 -04:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
53 lines
1.6 KiB
TypeScript
53 lines
1.6 KiB
TypeScript
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { useMemo } from 'react'
|
|
|
|
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
|
|
import { useDatabaseExtensionsQuery } from '@/data/database-extensions/database-extensions-query'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
|
|
|
|
const WRAPPER_REQUIRED_EXTENSION_NAMES = ['wrappers', 'supabase_vault']
|
|
|
|
interface AddWrapperButtonProps {
|
|
variant?: 'default' | 'primary' | 'outline'
|
|
onClick: () => void
|
|
}
|
|
|
|
export const AddWrapperButton = ({ variant = 'default', onClick }: AddWrapperButtonProps) => {
|
|
const { can: canCreateWrapper } = useAsyncCheckPermissions(
|
|
PermissionAction.TENANT_SQL_ADMIN_WRITE,
|
|
'wrappers'
|
|
)
|
|
|
|
const { data: project } = useSelectedProjectQuery()
|
|
const { data: extensions } = useDatabaseExtensionsQuery({
|
|
projectRef: project?.ref,
|
|
connectionString: project?.connectionString,
|
|
})
|
|
|
|
const needsExtensions = useMemo(
|
|
() =>
|
|
WRAPPER_REQUIRED_EXTENSION_NAMES.some(
|
|
(name) => !extensions?.find((ext) => ext.name === name)?.installed_version
|
|
),
|
|
[extensions]
|
|
)
|
|
|
|
return (
|
|
<ButtonTooltip
|
|
variant={variant}
|
|
onClick={onClick}
|
|
disabled={!canCreateWrapper}
|
|
tooltip={{
|
|
content: {
|
|
text: !canCreateWrapper
|
|
? 'You need additional permissions to create a foreign data wrapper'
|
|
: undefined,
|
|
},
|
|
}}
|
|
>
|
|
{needsExtensions ? 'Install wrapper' : 'Add new wrapper'}
|
|
</ButtonTooltip>
|
|
)
|
|
}
|