mirror of
https://github.com/supabase/supabase.git
synced 2026-05-08 01:40:13 -04:00
7f8ae81d64
## Context Resolves FE-3126 Just cleaning up the table editor header with a bit of refactors (pre-req to investigating collapsing filter bar and table editor header actions into a single row) ## Non-visual changes involved - Break down components within `GridHeaderActions` into smaller ones - `IndexAdvisorPopover` - `SecurityDefinerViewPopover` - `RealtimeToggle` - Deprecate use of `useUrlState` in `GridHeaderActions` to use `useQueryState` instead - Improve types for `TwoOptionToggle` ## Visual changes involved - Collapse realtime button toggle into a button icon, with no text (just tooltip) - Adjust layout of buttons a little ### Before <img width="796" height="118" alt="image" src="https://github.com/user-attachments/assets/436bca94-4d91-471a-a184-487c6f78dc04" /> ### After <img width="731" height="132" alt="image" src="https://github.com/user-attachments/assets/5fd30982-a1fc-4f92-a590-146d1e69d52a" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Index Advisor popover with recommendations. * Realtime toggle to manage realtime table publication. * Security Definer view popover with optional autofix. * Insert menu for adding rows/columns and CSV import. * **Bug Fixes** * Adjusted filter bar input sizing for improved readability. * **Refactor** * Header layout updated and insert/import actions moved into dedicated components. * **Tests** * Updated end-to-end selectors for the Insert row menu item. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
157 lines
6.3 KiB
TypeScript
157 lines
6.3 KiB
TypeScript
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { useParams } from 'common'
|
|
import { ArrowUp, ChevronDown, FileText } from 'lucide-react'
|
|
import {
|
|
Button,
|
|
cn,
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from 'ui'
|
|
|
|
import { ShortcutBadge } from '@/components/ui/ShortcutBadge'
|
|
import { useSendEventMutation } from '@/data/telemetry/send-event-mutation'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useSelectedOrganizationQuery } from '@/hooks/misc/useSelectedOrganization'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
import { useTableEditorStateSnapshot } from '@/state/table-editor'
|
|
import { useTableEditorTableStateSnapshot } from '@/state/table-editor-table'
|
|
|
|
export const InsertButton = () => {
|
|
const { ref: projectRef } = useParams()
|
|
const { data: org } = useSelectedOrganizationQuery()
|
|
|
|
const snap = useTableEditorTableStateSnapshot()
|
|
const tableEditorSnap = useTableEditorStateSnapshot()
|
|
const { can: canCreateColumns } = useAsyncCheckPermissions(
|
|
PermissionAction.TENANT_SQL_ADMIN_WRITE,
|
|
'columns'
|
|
)
|
|
const { mutate: sendEvent } = useSendEventMutation()
|
|
|
|
const onAddRow =
|
|
snap.editable && (snap.table.columns ?? []).length > 0 ? tableEditorSnap.onAddRow : undefined
|
|
const onAddColumn = snap.editable ? tableEditorSnap.onAddColumn : undefined
|
|
const onImportData = snap.editable ? tableEditorSnap.onImportData : undefined
|
|
|
|
const canAddNew = onAddRow !== undefined || onAddColumn !== undefined
|
|
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW, () => onAddRow?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddRow !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN, () => onAddColumn?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddColumn !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV, () => onImportData?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onImportData !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
|
|
if (!canAddNew || !canCreateColumns) return null
|
|
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
data-testid="table-editor-insert-new-row"
|
|
type="primary"
|
|
size="tiny"
|
|
icon={<ChevronDown strokeWidth={1.5} />}
|
|
>
|
|
Insert
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent side="bottom" align="end">
|
|
{[
|
|
...(onAddRow !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="add-row"
|
|
className="flex items-center group gap-x-3"
|
|
onClick={onAddRow}
|
|
>
|
|
<div className="shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px]" />
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px] my-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[15px] h-[4px] translate-x-0.5',
|
|
'transition duration-200 group-data-highlighted:border-brand group-data-highlighted:translate-x-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert row</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onAddColumn !== undefined
|
|
? [
|
|
<DropdownMenuItem key="add-column" className="group gap-x-3" onClick={onAddColumn}>
|
|
<div className="flex shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px]" />
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px] mx-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[4px] h-[15px] -translate-y-0.5',
|
|
'transition duration-200 group-data-highlighted:border-brand group-data-highlighted:translate-y-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert column</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onImportData !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="import-data"
|
|
className="group gap-x-3"
|
|
onClick={() => {
|
|
onImportData()
|
|
sendEvent({
|
|
action: 'import_data_button_clicked',
|
|
properties: { tableType: 'Existing Table' },
|
|
groups: {
|
|
project: projectRef ?? 'Unknown',
|
|
organization: org?.slug ?? 'Unknown',
|
|
},
|
|
})
|
|
}}
|
|
>
|
|
<div className="relative shrink-0 w-4">
|
|
<FileText size={18} strokeWidth={1.5} className="translate-x-[-2px]" />
|
|
<ArrowUp
|
|
className={cn(
|
|
'transition duration-200 absolute bottom-0 right-0 translate-y-1 opacity-0 bg-brand-400 rounded-full',
|
|
'group-data-highlighted:translate-y-0 group-data-highlighted:text-brand group-data-highlighted:opacity-100'
|
|
)}
|
|
strokeWidth={3}
|
|
size={12}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Import data from CSV</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
]}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
)
|
|
}
|