mirror of
https://github.com/supabase/supabase.git
synced 2026-07-04 15:20:56 -04:00
Gildas Garcia
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
70 lines
1.8 KiB
TypeScript
70 lines
1.8 KiB
TypeScript
import {
|
|
Button,
|
|
cn,
|
|
Dialog,
|
|
DialogClose,
|
|
DialogContent,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogSection,
|
|
DialogSectionSeparator,
|
|
DialogTitle,
|
|
} from 'ui'
|
|
import { CodeBlock } from 'ui-patterns/CodeBlock'
|
|
|
|
interface ErrorDetailsDialogProps {
|
|
open: boolean
|
|
onOpenChange: (open: boolean) => void
|
|
tableName: string
|
|
reason: string
|
|
solution?: string
|
|
}
|
|
|
|
export const ErrorDetailsDialog = ({
|
|
open,
|
|
onOpenChange,
|
|
tableName,
|
|
reason,
|
|
solution,
|
|
}: ErrorDetailsDialogProps) => {
|
|
return (
|
|
<Dialog open={open} onOpenChange={onOpenChange}>
|
|
<DialogContent size="xlarge" aria-describedby={undefined}>
|
|
<DialogHeader>
|
|
<DialogTitle>
|
|
Replication error on <code className="text-code-inline">{tableName}</code>
|
|
</DialogTitle>
|
|
</DialogHeader>
|
|
<DialogSectionSeparator />
|
|
<DialogSection className="p-0!">
|
|
<div className="px-4 py-3">
|
|
<p className="text-sm text-foreground-light">
|
|
The following error occurred during replication:
|
|
</p>
|
|
</div>
|
|
<CodeBlock
|
|
hideLineNumbers
|
|
wrapLines={false}
|
|
wrapperClassName={cn(
|
|
'[&_pre]:px-4 [&_pre]:py-3 [&>pre]:border-x-0 [&>pre]:rounded-none'
|
|
)}
|
|
language="bash"
|
|
value={reason}
|
|
className="[&_code]:text-xs [&_code]:text-foreground [&_span]:text-foreground!"
|
|
/>
|
|
{solution && (
|
|
<div className="px-4 py-3">
|
|
<p className="text-sm">{solution}</p>
|
|
</div>
|
|
)}
|
|
</DialogSection>
|
|
<DialogFooter>
|
|
<DialogClose>
|
|
<Button variant="default">Close</Button>
|
|
</DialogClose>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|