mirror of
https://github.com/supabase/supabase.git
synced 2026-07-24 08:30:05 -04:00
Charis
5cb81123ae
## What
PR 5 of a stacked refactor. Moves *when to save* out of a module-load
`subscribe` and into an injectable **scheduler** armed by a headless
**provider**, splits the save queue, and adds an unsaved-close warning.
### Scheduler (`sql-editor-save-scheduler.ts`)
`createSaveScheduler({ state, saveMechanism, notify, getSaveMode })`
owns the save *policy*:
- **auto** mode drains the dirty snippet queue as edits land; **manual**
mode (the seam for a future opt-in; defaults to `auto`) leaves snippets
queued until `requestSave`. Folder saves always drain.
- `start()` returns an unsubscribe; `requestSave(id)` is the
explicit-save entry.
### Provider (`sql-editor-save-coordinator.tsx`)
Headless `SqlEditorSaveCoordinatorProvider` instantiates the mechanism
(invalidation via the **React Query client from context**, not the
global `getQueryClient`) + scheduler, `start()`s it in an effect
(start/stop with the provider), and exposes `requestSave` via
`useSqlEditorSaveCoordinator()`. Mounted in `ProjectContext` (under the
app's QueryClientProvider). Cmd+S and the SavingIndicator Retry now go
through `requestSave`.
### Queue split
`needsSaving` (snippets) and `pendingFolderSaves` (folders) are separate
queues, drained independently — the old snippet-vs-folder `if/else` is
gone.
### Unsaved-close warning
A `beforeunload` guard triggers the browser's native "Leave site?"
prompt while any snippet's `status !== 'saved'` (failed / in-flight /
never-saved).
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved SQL editor saving with a centralized save flow, including
automatic/manual save handling and immediate “Save Query” requests.
* Added unsaved-change detection so the app can warn before closing or
reloading when edits are still pending.
* **Bug Fixes**
* Retry actions now use the updated save flow for more reliable
re-saving.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
29 lines
1.2 KiB
TypeScript
29 lines
1.2 KiB
TypeScript
import { PropsWithChildren } from 'react'
|
|
|
|
import { DatabaseSelectorStateContextProvider } from '@/state/database-selector'
|
|
import { RoleImpersonationStateContextProvider } from '@/state/role-impersonation-state'
|
|
import { SqlEditorSaveCoordinatorProvider } from '@/state/sql-editor/sql-editor-save-coordinator'
|
|
import { TableEditorStateContextProvider } from '@/state/table-editor'
|
|
import { TabsStateContextProvider } from '@/state/tabs'
|
|
|
|
type ProjectContextProviderProps = {
|
|
projectRef: string | undefined
|
|
}
|
|
|
|
export const ProjectContextProvider = ({
|
|
projectRef,
|
|
children,
|
|
}: PropsWithChildren<ProjectContextProviderProps>) => {
|
|
return (
|
|
<TableEditorStateContextProvider key={`table-editor-state-${projectRef}`}>
|
|
<TabsStateContextProvider key={`tabs-state-${projectRef}`}>
|
|
<DatabaseSelectorStateContextProvider key={`database-selector-state-${projectRef}`}>
|
|
<RoleImpersonationStateContextProvider key={`role-impersonation-state-${projectRef}`}>
|
|
<SqlEditorSaveCoordinatorProvider>{children}</SqlEditorSaveCoordinatorProvider>
|
|
</RoleImpersonationStateContextProvider>
|
|
</DatabaseSelectorStateContextProvider>
|
|
</TabsStateContextProvider>
|
|
</TableEditorStateContextProvider>
|
|
)
|
|
}
|