mirror of
https://github.com/supabase/supabase.git
synced 2026-07-03 22:24:28 -04:00
Gildas Garcia
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
27 lines
813 B
TypeScript
27 lines
813 B
TypeScript
import { X } from 'lucide-react'
|
|
import { Button } from 'ui'
|
|
|
|
import { useDataTable } from './providers/DataTableProvider'
|
|
import { ShortcutTooltip } from '@/components/ui/ShortcutTooltip'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
|
|
export function DataTableResetButton() {
|
|
const { table } = useDataTable()
|
|
useShortcut(SHORTCUT_IDS.DATA_TABLE_RESET_FILTERS, () => table.resetColumnFilters(), {
|
|
registerInCommandMenu: true,
|
|
})
|
|
|
|
return (
|
|
<ShortcutTooltip
|
|
shortcutId={SHORTCUT_IDS.DATA_TABLE_RESET_FILTERS}
|
|
label="Reset filters"
|
|
side="left"
|
|
>
|
|
<Button variant="default" size="tiny" onClick={() => table.resetColumnFilters()} icon={<X />}>
|
|
Reset
|
|
</Button>
|
|
</ShortcutTooltip>
|
|
)
|
|
}
|