diff --git a/.config/typos.toml b/.config/typos.toml index c935778db..1d64ba27c 100644 --- a/.config/typos.toml +++ b/.config/typos.toml @@ -16,6 +16,12 @@ smove = "smove" Parth = "Parth" # seems like the spellchecker does not like it is similar to "Path" nd = "nd" +[default] +extend-ignore-re = [ + "SELECTed", + "WATCHed", +] + [type.c] extend-ignore-re = [ "BA3E2571", # sha1.c @@ -53,6 +59,7 @@ arange = "arange" fo = "fo" frst = "frst" limite = "limite" +pathc = "pathc" pn = "pn" seeked = "seeked" tre = "tre" diff --git a/.github/workflows/auto-author-assign.yml b/.github/workflows/auto-author-assign.yml index 3f70e63e5..70a135d21 100644 --- a/.github/workflows/auto-author-assign.yml +++ b/.github/workflows/auto-author-assign.yml @@ -11,4 +11,4 @@ jobs: assign-author: runs-on: ubuntu-latest steps: - - uses: toshimaru/auto-author-assign@16f0022cf3d7970c106d8d1105f75a1165edb516 # v2.1.1 + - uses: toshimaru/auto-author-assign@4d585cc37690897bd9015942ed6e766aa7cdb97f # v3.0.1 diff --git a/.github/workflows/benchmark-on-label.yml b/.github/workflows/benchmark-on-label.yml index dcc62587c..0f8723251 100644 --- a/.github/workflows/benchmark-on-label.yml +++ b/.github/workflows/benchmark-on-label.yml @@ -24,7 +24,7 @@ jobs: github.event.action == 'labeled' && github.event.label.name == 'run-benchmark' steps: - name: Checkout valkey - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: path: valkey fetch-depth: 0 @@ -32,7 +32,7 @@ jobs: persist-credentials: false - name: Checkout valkey-perf-benchmark - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ github.repository_owner }}/valkey-perf-benchmark path: valkey-perf-benchmark @@ -40,7 +40,7 @@ jobs: persist-credentials: false - name: Set up Python - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5 + uses: kishaningithub/setup-python-amazon-linux@a326cdc792983fe0fbd04c81d3d62b59b6123a6c # v1.1.0 with: python-version: "3.10" cache: "pip" @@ -85,7 +85,7 @@ jobs: - name: Upload artifacts if: always() continue-on-error: true - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0 + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: benchmark-results path: | @@ -94,7 +94,7 @@ jobs: comparison.md - name: Comment PR with results - uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7 + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -127,7 +127,7 @@ jobs: - name: Remove ${{ github.event.label.name }} label if: always() && github.event.label.name == 'run-benchmark' - uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7 + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | diff --git a/.github/workflows/benchmark-release.yml b/.github/workflows/benchmark-release.yml index 739c1af68..4d9cd99e5 100644 --- a/.github/workflows/benchmark-release.yml +++ b/.github/workflows/benchmark-release.yml @@ -53,14 +53,50 @@ jobs: exit 1 fi - - name: Checkout valkey (latest) - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + # Validate runs is a positive number + if ! [[ "${{ github.event.inputs.runs }}" =~ ^[1-9][0-9]*$ ]]; then + echo "Error: Runs must be a positive number" + exit 1 + fi + + - name: Checkout valkey for latest benchmark. + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ github.repository_owner }}/valkey path: valkey_latest fetch-depth: 0 persist-credentials: false + - name: Checkout valkey + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + with: + path: valkey + + - name: Checkout valkey-perf-benchmark + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + with: + repository: ${{ github.repository_owner }}/valkey-perf-benchmark + path: valkey-perf-benchmark + fetch-depth: 1 + persist-credentials: false + + - name: Set up Python + uses: kishaningithub/setup-python-amazon-linux@a326cdc792983fe0fbd04c81d3d62b59b6123a6c # v1.1.0 + with: + python-version: "3.10" + cache: "pip" + + - name: Install dependencies + working-directory: valkey-perf-benchmark + run: | + sudo dnf groupinstall "Development Tools" -y + sudo dnf install -y gcc gcc-c++ make \ + python3-devel \ + openssl-devel \ + bzip2-devel \ + libffi-devel + pip install -r requirements.txt + - name: Build latest valkey_latest working-directory: valkey_latest run: | @@ -191,15 +227,58 @@ jobs: - name: Upload artifacts if: always() continue-on-error: true - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0 + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: benchmark-results-${{ github.event.inputs.issue_id }} path: | ./valkey-perf-benchmark/results/*/metrics.json comparison.md - - name: Comment on issue with results - uses: actions/github-script@5c56fde4671bc2d3592fb0f2c5b5bab9ddae03b1 # v7 + - name: Cleanup any running valkey processes and files + if: always() + continue-on-error: true + run: | + pkill -f valkey || echo "No valkey processes found to kill" + rm -rf * + + combine-results: + needs: benchmark + runs-on: ubuntu-latest + steps: + - name: Download all artifacts + uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0 + with: + path: artifacts + + - name: Combine results and create comprehensive report + run: | + echo "# Multi-Architecture Benchmark Comparison: ${{ github.event.inputs.version1 }} vs ${{ github.event.inputs.version2 }}" > combined_report.md + echo "" >> combined_report.md + echo "**Versions Compared:**" >> combined_report.md + echo "- Version 1: \`${{ github.event.inputs.version1 }}\`" >> combined_report.md + echo "- Version 2: \`${{ github.event.inputs.version2 }}\`" >> combined_report.md + echo "" >> combined_report.md + echo "**Runs:** ${{ github.event.inputs.runs }} per configuration" >> combined_report.md + echo "**Workflow Run:** [View Details](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})" >> combined_report.md + echo "" >> combined_report.md + echo "---" >> combined_report.md + echo "" >> combined_report.md + + # Process each architecture's results + for arch in x86 arm64; do + artifact_dir="artifacts/benchmark-results-${arch}-${{ github.event.inputs.issue_id }}" + if [[ -d "$artifact_dir" && -f "$artifact_dir/comparison.md" ]]; then + echo "## ${arch^^} Architecture Results" >> combined_report.md + echo "" >> combined_report.md + cat "$artifact_dir/comparison.md" >> combined_report.md + echo "" >> combined_report.md + echo "---" >> combined_report.md + echo "" >> combined_report.md + fi + done + + - name: Comment on issue with combined results + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6fc52994d..70c628494 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: test-ubuntu-latest: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make # Fail build if there are warnings # build with TLS just for compilation coverage @@ -54,7 +54,7 @@ jobs: - {version: "8.0.6", file: "valkey-8.0.6-noble-x86_64.tar.gz"} - {version: "8.1.4", file: "valkey-8.1.4-noble-x86_64.tar.gz"} steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make # Fail build if there are warnings # build with TLS just for compilation coverage @@ -81,7 +81,7 @@ jobs: test-ubuntu-latest-cmake: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: cmake and make run: | sudo apt-get install -y cmake libssl-dev @@ -106,7 +106,7 @@ jobs: test-sanitizer-address: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make # build with TLS module just for compilation coverage run: make -j4 all-with-unit-tests SANITIZER=address SERVER_CFLAGS='-Werror' BUILD_TLS=module @@ -122,7 +122,7 @@ jobs: test-rdma: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: prepare-development-libraries run: sudo apt-get install librdmacm-dev libibverbs-dev - name: make-rdma-module @@ -147,7 +147,7 @@ jobs: runs-on: ubuntu-latest container: debian:bullseye steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make run: | apt-get update && apt-get install -y build-essential @@ -156,7 +156,7 @@ jobs: build-macos-latest: runs-on: macos-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make # Build with additional upcoming features run: make -j3 all-with-unit-tests SERVER_CFLAGS='-Werror' USE_FAST_FLOAT=yes @@ -164,7 +164,7 @@ jobs: build-32bit: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make # Fast float requires C++ 32-bit libraries to compile on 64-bit ubuntu # machine i.e. "-cross" suffixed version. Cross-compiling c++ to 32-bit @@ -182,7 +182,7 @@ jobs: build-libc-malloc: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make run: make -j4 SERVER_CFLAGS='-Werror' MALLOC=libc USE_FAST_FLOAT=yes @@ -190,7 +190,7 @@ jobs: runs-on: ubuntu-latest container: almalinux:8 steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: make run: | @@ -201,10 +201,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout code - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Set up Go - uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 + uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0 with: go-version: "1.22.4" diff --git a/.github/workflows/clang-format.yml b/.github/workflows/clang-format.yml index e1d2f6c3d..5a69bec5a 100644 --- a/.github/workflows/clang-format.yml +++ b/.github/workflows/clang-format.yml @@ -22,7 +22,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Set up Clang run: | diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index 5ddf1cffd..3a38023b8 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -24,7 +24,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Install lcov and run test run: | @@ -32,7 +32,7 @@ jobs: make lcov - name: Upload code coverage - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2 with: token: ${{ secrets.CODECOV_TOKEN }} file: ./src/valkey.info diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index b9a7e1e66..8da72f66c 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -37,15 +37,15 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Initialize CodeQL - uses: github/codeql-action/init@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9 + uses: github/codeql-action/init@b5ebac6f4c00c8ccddb7cdcd45fdb248329f808a # v3.32.2 with: languages: ${{ matrix.language }} - name: Autobuild - uses: github/codeql-action/autobuild@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9 + uses: github/codeql-action/autobuild@b5ebac6f4c00c8ccddb7cdcd45fdb248329f808a # v3.32.2 - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9 + uses: github/codeql-action/analyze@b5ebac6f4c00c8ccddb7cdcd45fdb248329f808a # v3.32.2 diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml index 2561e4ceb..3b3622d55 100644 --- a/.github/workflows/coverity.yml +++ b/.github/workflows/coverity.yml @@ -19,7 +19,7 @@ jobs: if: github.repository == 'valkey-io/valkey' runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Download and extract the Coverity Build Tool run: | wget -q https://scan.coverity.com/download/cxx/linux64 --post-data "token=${{ secrets.COVERITY_SCAN_TOKEN }}&project=valkey-io%2Fvalkey" -O cov-analysis-linux64.tar.gz diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index f82cd7f82..b977b0a88 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -59,7 +59,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -127,7 +127,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -170,7 +170,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -215,7 +215,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -254,7 +254,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -293,7 +293,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -339,7 +339,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -385,7 +385,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -431,7 +431,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -465,7 +465,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -503,7 +503,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -582,7 +582,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -614,7 +614,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -651,7 +651,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -683,7 +683,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -726,7 +726,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -782,7 +782,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -834,7 +834,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -878,7 +878,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -941,7 +941,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1007,7 +1007,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1079,7 +1079,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1129,7 +1129,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1160,7 +1160,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1188,7 +1188,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1223,7 +1223,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1244,12 +1244,12 @@ jobs: run: | echo "GITHUB_REPOSITORY=${{github.event.inputs.use_repo}}" >> $GITHUB_ENV echo "GITHUB_HEAD_REF=${{github.event.inputs.use_git_ref}}" >> $GITHUB_ENV - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: test - uses: cross-platform-actions/action@46e8d7fb25520a8d6c64fd2b7a1192611da98eda # v0.30.0 + uses: cross-platform-actions/action@39a2a80642eca0947594ad03e4355dc3d28c617a # v0.32.0 with: operating_system: freebsd environment_variables: MAKE @@ -1278,7 +1278,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1319,7 +1319,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1360,7 +1360,7 @@ jobs: echo "skiptests: ${{github.event.inputs.skiptests}}" echo "test_args: ${{github.event.inputs.test_args}}" echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}" - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 with: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} @@ -1441,7 +1441,7 @@ jobs: echo "STATUS=success" >> $GITHUB_ENV fi - name: Notify about results - uses: ravsamhq/notify-slack-action@v2 + uses: ravsamhq/notify-slack-action@042f29088bb3bdbda5b4ff7b4818466a277fa8f7 # v2.5.0 with: status: ${{ env.STATUS }} notify_when: "failure" diff --git a/.github/workflows/external.yml b/.github/workflows/external.yml index f96059dfb..59b4d9d87 100644 --- a/.github/workflows/external.yml +++ b/.github/workflows/external.yml @@ -27,7 +27,7 @@ jobs: if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey' timeout-minutes: 1440 steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Build run: make SERVER_CFLAGS=-Werror - name: Start valkey-server @@ -42,7 +42,7 @@ jobs: --tags -slow - name: Archive server log if: ${{ failure() }} - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0 + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: test-external-standalone-log path: external-server.log @@ -52,7 +52,7 @@ jobs: if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey' timeout-minutes: 1440 steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Build run: make SERVER_CFLAGS=-Werror - name: Start valkey-server @@ -71,7 +71,7 @@ jobs: --tags -slow - name: Archive server log if: ${{ failure() }} - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0 + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: test-external-cluster-log path: external-server.log @@ -81,7 +81,7 @@ jobs: if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey' timeout-minutes: 1440 steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Build run: make SERVER_CFLAGS=-Werror - name: Start valkey-server @@ -95,7 +95,7 @@ jobs: --tags "-slow -needs:debug" - name: Archive server log if: ${{ failure() }} - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0 + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: test-external-nodebug-log path: external-server.log diff --git a/.github/workflows/reply-schemas-linter.yml b/.github/workflows/reply-schemas-linter.yml index 1141e235f..1570c3e69 100644 --- a/.github/workflows/reply-schemas-linter.yml +++ b/.github/workflows/reply-schemas-linter.yml @@ -19,9 +19,9 @@ jobs: reply-schemas-linter: runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Setup nodejs - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 + uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0 - name: Install packages run: npm install ajv - name: linter diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 14db670b2..b39eef94a 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -23,10 +23,10 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Install typos - uses: taiki-e/install-action@fe9759bf4432218c779595708e80a1aadc85cedc # v2.46.10 + uses: taiki-e/install-action@d4422f254e595ee762a758628fe4f16ce050fa2e # v2.67.28 with: tool: typos diff --git a/.github/workflows/trigger-build-release.yml b/.github/workflows/trigger-build-release.yml index 0f6a3d1f7..4e70230af 100644 --- a/.github/workflows/trigger-build-release.yml +++ b/.github/workflows/trigger-build-release.yml @@ -38,7 +38,7 @@ jobs: echo "environment=$ENVIRONMENT" >> $GITHUB_OUTPUT - name: Trigger build - uses: peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0 # Version 3 + uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v4.0.1 with: token: ${{ secrets.AUTOMATION_PAT }} repository: ${{ github.repository_owner }}/valkey-release-automation diff --git a/src/crcspeed.c b/src/crcspeed.c index eb8042b30..fdd1b4b7e 100644 --- a/src/crcspeed.c +++ b/src/crcspeed.c @@ -234,7 +234,7 @@ uint64_t crcspeed64little(uint64_t little_table[8][256], uint64_t crc1, MERGE_END(next2, 2); } /* We fall through here to handle our = 8) { diff --git a/src/lua/engine_lua.c b/src/lua/engine_lua.c index f680d0eff..b466a86e8 100644 --- a/src/lua/engine_lua.c +++ b/src/lua/engine_lua.c @@ -126,7 +126,7 @@ static void initializeEvalLuaState(lua_State *lua) { lua_setglobal(lua, "server"); - /* Duplicate the function with __server__err__hanler and + /* Duplicate the function with __server__err__handler and * __redis__err_handler name for backwards compatibility. */ lua_pushstring(lua, REGISTRY_ERROR_HANDLER_NAME); lua_gettable(lua, LUA_REGISTRYINDEX); diff --git a/src/networking.c b/src/networking.c index 95bc5bdf5..b72523de8 100644 --- a/src/networking.c +++ b/src/networking.c @@ -965,10 +965,10 @@ void addReplyErrorSdsSafe(client *c, sds err) { /* Internal function used by addReplyErrorFormat, addReplyErrorFormatEx and RM_ReplyWithErrorFormat. * Refer to afterErrorReply for more information about the flags. */ void addReplyErrorFormatInternal(client *c, int flags, const char *fmt, va_list ap) { - va_list cpy; - va_copy(cpy, ap); - sds s = sdscatvprintf(sdsempty(), fmt, cpy); - va_end(cpy); + va_list copy; + va_copy(copy, ap); + sds s = sdscatvprintf(sdsempty(), fmt, copy); + va_end(copy); /* Trim any newlines at the end (ones will be added by addReplyErrorLength) */ s = sdstrim(s, "\r\n"); /* Make sure there are no newlines in the middle of the string, otherwise diff --git a/src/script.c b/src/script.c index 3661bccce..f85afe6cc 100644 --- a/src/script.c +++ b/src/script.c @@ -82,7 +82,7 @@ client *scriptGetCaller(void) { int scriptInterrupt(scriptRunCtx *run_ctx) { if (run_ctx->flags & SCRIPT_TIMEDOUT) { /* script already timedout - we just need to precess some events and return */ + we just need to process some events and return */ processEventsWhileBlocked(); return (run_ctx->flags & SCRIPT_KILLED) ? SCRIPT_KILL : SCRIPT_CONTINUE; } diff --git a/src/sds.c b/src/sds.c index 0ebfbdd0f..f9b3f7845 100644 --- a/src/sds.c +++ b/src/sds.c @@ -585,7 +585,7 @@ sds sdsfromlonglong(long long value) { /* Like sdscatprintf() but gets va_list instead of being variadic. */ sds sdscatvprintf(sds s, const char *fmt, va_list ap) { - va_list cpy; + va_list copy; char staticbuf[1024], *buf = staticbuf, *t; size_t buflen = strlen(fmt) * 2; int bufstrlen; @@ -602,9 +602,9 @@ sds sdscatvprintf(sds s, const char *fmt, va_list ap) { /* Alloc enough space for buffer and \0 after failing to * fit the string in the current buffer size. */ while (1) { - va_copy(cpy, ap); - bufstrlen = vsnprintf(buf, buflen, fmt, cpy); - va_end(cpy); + va_copy(copy, ap); + bufstrlen = vsnprintf(buf, buflen, fmt, copy); + va_end(copy); if (bufstrlen < 0) { if (buf != staticbuf) s_free(buf); return NULL; diff --git a/src/t_string.c b/src/t_string.c index a8c46a8a9..a2f29837a 100644 --- a/src/t_string.c +++ b/src/t_string.c @@ -46,7 +46,7 @@ static int checkStringLength(client *c, long long size, long long append) { if (mustObeyClient(c)) return C_OK; /* 'uint64_t' cast is there just to prevent undefined behavior on overflow */ long long total = (uint64_t)size + append; - /* Test configured max-bulk-len represending a limit of the biggest string object, + /* Test configured max-bulk-len representing a limit of the biggest string object, * and also test for overflow. */ if (total > server.proto_max_bulk_len || total < size || total < append) { addReplyError(c, "string exceeds maximum allowed size (proto-max-bulk-len)"); diff --git a/src/unit/test_files.h b/src/unit/test_files.h index ca557984b..68004786b 100644 --- a/src/unit/test_files.h +++ b/src/unit/test_files.h @@ -59,9 +59,9 @@ int test_listpackCreateIntList(int argc, char **argv, int flags); int test_listpackCreateList(int argc, char **argv, int flags); int test_listpackLpPrepend(int argc, char **argv, int flags); int test_listpackLpPrependInteger(int argc, char **argv, int flags); -int test_listpackGetELementAtIndex(int argc, char **argv, int flags); +int test_listpackGetElementAtIndex(int argc, char **argv, int flags); int test_listpackPop(int argc, char **argv, int flags); -int test_listpackGetELementAtIndex2(int argc, char **argv, int flags); +int test_listpackGetElementAtIndex2(int argc, char **argv, int flags); int test_listpackIterate0toEnd(int argc, char **argv, int flags); int test_listpackIterate1toEnd(int argc, char **argv, int flags); int test_listpackIterate2toEnd(int argc, char **argv, int flags); @@ -264,7 +264,7 @@ unitTest __test_entry_c[] = {{"test_entryCreate", test_entryCreate}, {"test_entr unitTest __test_hashtable_c[] = {{"test_cursor", test_cursor}, {"test_set_hash_function_seed", test_set_hash_function_seed}, {"test_add_find_delete", test_add_find_delete}, {"test_add_find_delete_avoid_resize", test_add_find_delete_avoid_resize}, {"test_instant_rehashing", test_instant_rehashing}, {"test_bucket_chain_length", test_bucket_chain_length}, {"test_two_phase_insert_and_pop", test_two_phase_insert_and_pop}, {"test_replace_reallocated_entry", test_replace_reallocated_entry}, {"test_incremental_find", test_incremental_find}, {"test_scan", test_scan}, {"test_iterator", test_iterator}, {"test_safe_iterator", test_safe_iterator}, {"test_compact_bucket_chain", test_compact_bucket_chain}, {"test_random_entry", test_random_entry}, {"test_random_entry_with_long_chain", test_random_entry_with_long_chain}, {"test_random_entry_sparse_table", test_random_entry_sparse_table}, {NULL, NULL}}; unitTest __test_intset_c[] = {{"test_intsetValueEncodings", test_intsetValueEncodings}, {"test_intsetBasicAdding", test_intsetBasicAdding}, {"test_intsetLargeNumberRandomAdd", test_intsetLargeNumberRandomAdd}, {"test_intsetUpgradeFromint16Toint32", test_intsetUpgradeFromint16Toint32}, {"test_intsetUpgradeFromint16Toint64", test_intsetUpgradeFromint16Toint64}, {"test_intsetUpgradeFromint32Toint64", test_intsetUpgradeFromint32Toint64}, {"test_intsetStressLookups", test_intsetStressLookups}, {"test_intsetStressAddDelete", test_intsetStressAddDelete}, {NULL, NULL}}; unitTest __test_kvstore_c[] = {{"test_kvstoreAdd16Keys", test_kvstoreAdd16Keys}, {"test_kvstoreIteratorRemoveAllKeysNoDeleteEmptyHashtable", test_kvstoreIteratorRemoveAllKeysNoDeleteEmptyHashtable}, {"test_kvstoreIteratorRemoveAllKeysDeleteEmptyHashtable", test_kvstoreIteratorRemoveAllKeysDeleteEmptyHashtable}, {"test_kvstoreHashtableIteratorRemoveAllKeysNoDeleteEmptyHashtable", test_kvstoreHashtableIteratorRemoveAllKeysNoDeleteEmptyHashtable}, {"test_kvstoreHashtableIteratorRemoveAllKeysDeleteEmptyHashtable", test_kvstoreHashtableIteratorRemoveAllKeysDeleteEmptyHashtable}, {"test_kvstoreHashtableExpand", test_kvstoreHashtableExpand}, {NULL, NULL}}; -unitTest __test_listpack_c[] = {{"test_listpackCreateIntList", test_listpackCreateIntList}, {"test_listpackCreateList", test_listpackCreateList}, {"test_listpackLpPrepend", test_listpackLpPrepend}, {"test_listpackLpPrependInteger", test_listpackLpPrependInteger}, {"test_listpackGetELementAtIndex", test_listpackGetELementAtIndex}, {"test_listpackPop", test_listpackPop}, {"test_listpackGetELementAtIndex2", test_listpackGetELementAtIndex2}, {"test_listpackIterate0toEnd", test_listpackIterate0toEnd}, {"test_listpackIterate1toEnd", test_listpackIterate1toEnd}, {"test_listpackIterate2toEnd", test_listpackIterate2toEnd}, {"test_listpackIterateBackToFront", test_listpackIterateBackToFront}, {"test_listpackIterateBackToFrontWithDelete", test_listpackIterateBackToFrontWithDelete}, {"test_listpackDeleteWhenNumIsMinusOne", test_listpackDeleteWhenNumIsMinusOne}, {"test_listpackDeleteWithNegativeIndex", test_listpackDeleteWithNegativeIndex}, {"test_listpackDeleteInclusiveRange0_0", test_listpackDeleteInclusiveRange0_0}, {"test_listpackDeleteInclusiveRange0_1", test_listpackDeleteInclusiveRange0_1}, {"test_listpackDeleteInclusiveRange1_2", test_listpackDeleteInclusiveRange1_2}, {"test_listpackDeleteWitStartIndexOutOfRange", test_listpackDeleteWitStartIndexOutOfRange}, {"test_listpackDeleteWitNumOverflow", test_listpackDeleteWitNumOverflow}, {"test_listpackBatchDelete", test_listpackBatchDelete}, {"test_listpackDeleteFooWhileIterating", test_listpackDeleteFooWhileIterating}, {"test_listpackReplaceWithSameSize", test_listpackReplaceWithSameSize}, {"test_listpackReplaceWithDifferentSize", test_listpackReplaceWithDifferentSize}, {"test_listpackRegressionGt255Bytes", test_listpackRegressionGt255Bytes}, {"test_listpackCreateLongListAndCheckIndices", test_listpackCreateLongListAndCheckIndices}, {"test_listpackCompareStrsWithLpEntries", test_listpackCompareStrsWithLpEntries}, {"test_listpackLpMergeEmptyLps", test_listpackLpMergeEmptyLps}, {"test_listpackLpMergeLp1Larger", test_listpackLpMergeLp1Larger}, {"test_listpackLpMergeLp2Larger", test_listpackLpMergeLp2Larger}, {"test_listpackLpNextRandom", test_listpackLpNextRandom}, {"test_listpackLpNextRandomCC", test_listpackLpNextRandomCC}, {"test_listpackRandomPairWithOneElement", test_listpackRandomPairWithOneElement}, {"test_listpackRandomPairWithManyElements", test_listpackRandomPairWithManyElements}, {"test_listpackRandomPairsWithOneElement", test_listpackRandomPairsWithOneElement}, {"test_listpackRandomPairsWithManyElements", test_listpackRandomPairsWithManyElements}, {"test_listpackRandomPairsUniqueWithOneElement", test_listpackRandomPairsUniqueWithOneElement}, {"test_listpackRandomPairsUniqueWithManyElements", test_listpackRandomPairsUniqueWithManyElements}, {"test_listpackPushVariousEncodings", test_listpackPushVariousEncodings}, {"test_listpackLpFind", test_listpackLpFind}, {"test_listpackLpValidateIntegrity", test_listpackLpValidateIntegrity}, {"test_listpackNumberOfElementsExceedsLP_HDR_NUMELE_UNKNOWN", test_listpackNumberOfElementsExceedsLP_HDR_NUMELE_UNKNOWN}, {"test_listpackStressWithRandom", test_listpackStressWithRandom}, {"test_listpackSTressWithVariableSize", test_listpackSTressWithVariableSize}, {"test_listpackBenchmarkInit", test_listpackBenchmarkInit}, {"test_listpackBenchmarkLpAppend", test_listpackBenchmarkLpAppend}, {"test_listpackBenchmarkLpFindString", test_listpackBenchmarkLpFindString}, {"test_listpackBenchmarkLpFindNumber", test_listpackBenchmarkLpFindNumber}, {"test_listpackBenchmarkLpSeek", test_listpackBenchmarkLpSeek}, {"test_listpackBenchmarkLpValidateIntegrity", test_listpackBenchmarkLpValidateIntegrity}, {"test_listpackBenchmarkLpCompareWithString", test_listpackBenchmarkLpCompareWithString}, {"test_listpackBenchmarkLpCompareWithNumber", test_listpackBenchmarkLpCompareWithNumber}, {"test_listpackBenchmarkFree", test_listpackBenchmarkFree}, {NULL, NULL}}; +unitTest __test_listpack_c[] = {{"test_listpackCreateIntList", test_listpackCreateIntList}, {"test_listpackCreateList", test_listpackCreateList}, {"test_listpackLpPrepend", test_listpackLpPrepend}, {"test_listpackLpPrependInteger", test_listpackLpPrependInteger}, {"test_listpackGetElementAtIndex", test_listpackGetElementAtIndex}, {"test_listpackPop", test_listpackPop}, {"test_listpackGetElementAtIndex2", test_listpackGetElementAtIndex2}, {"test_listpackIterate0toEnd", test_listpackIterate0toEnd}, {"test_listpackIterate1toEnd", test_listpackIterate1toEnd}, {"test_listpackIterate2toEnd", test_listpackIterate2toEnd}, {"test_listpackIterateBackToFront", test_listpackIterateBackToFront}, {"test_listpackIterateBackToFrontWithDelete", test_listpackIterateBackToFrontWithDelete}, {"test_listpackDeleteWhenNumIsMinusOne", test_listpackDeleteWhenNumIsMinusOne}, {"test_listpackDeleteWithNegativeIndex", test_listpackDeleteWithNegativeIndex}, {"test_listpackDeleteInclusiveRange0_0", test_listpackDeleteInclusiveRange0_0}, {"test_listpackDeleteInclusiveRange0_1", test_listpackDeleteInclusiveRange0_1}, {"test_listpackDeleteInclusiveRange1_2", test_listpackDeleteInclusiveRange1_2}, {"test_listpackDeleteWitStartIndexOutOfRange", test_listpackDeleteWitStartIndexOutOfRange}, {"test_listpackDeleteWitNumOverflow", test_listpackDeleteWitNumOverflow}, {"test_listpackBatchDelete", test_listpackBatchDelete}, {"test_listpackDeleteFooWhileIterating", test_listpackDeleteFooWhileIterating}, {"test_listpackReplaceWithSameSize", test_listpackReplaceWithSameSize}, {"test_listpackReplaceWithDifferentSize", test_listpackReplaceWithDifferentSize}, {"test_listpackRegressionGt255Bytes", test_listpackRegressionGt255Bytes}, {"test_listpackCreateLongListAndCheckIndices", test_listpackCreateLongListAndCheckIndices}, {"test_listpackCompareStrsWithLpEntries", test_listpackCompareStrsWithLpEntries}, {"test_listpackLpMergeEmptyLps", test_listpackLpMergeEmptyLps}, {"test_listpackLpMergeLp1Larger", test_listpackLpMergeLp1Larger}, {"test_listpackLpMergeLp2Larger", test_listpackLpMergeLp2Larger}, {"test_listpackLpNextRandom", test_listpackLpNextRandom}, {"test_listpackLpNextRandomCC", test_listpackLpNextRandomCC}, {"test_listpackRandomPairWithOneElement", test_listpackRandomPairWithOneElement}, {"test_listpackRandomPairWithManyElements", test_listpackRandomPairWithManyElements}, {"test_listpackRandomPairsWithOneElement", test_listpackRandomPairsWithOneElement}, {"test_listpackRandomPairsWithManyElements", test_listpackRandomPairsWithManyElements}, {"test_listpackRandomPairsUniqueWithOneElement", test_listpackRandomPairsUniqueWithOneElement}, {"test_listpackRandomPairsUniqueWithManyElements", test_listpackRandomPairsUniqueWithManyElements}, {"test_listpackPushVariousEncodings", test_listpackPushVariousEncodings}, {"test_listpackLpFind", test_listpackLpFind}, {"test_listpackLpValidateIntegrity", test_listpackLpValidateIntegrity}, {"test_listpackNumberOfElementsExceedsLP_HDR_NUMELE_UNKNOWN", test_listpackNumberOfElementsExceedsLP_HDR_NUMELE_UNKNOWN}, {"test_listpackStressWithRandom", test_listpackStressWithRandom}, {"test_listpackSTressWithVariableSize", test_listpackSTressWithVariableSize}, {"test_listpackBenchmarkInit", test_listpackBenchmarkInit}, {"test_listpackBenchmarkLpAppend", test_listpackBenchmarkLpAppend}, {"test_listpackBenchmarkLpFindString", test_listpackBenchmarkLpFindString}, {"test_listpackBenchmarkLpFindNumber", test_listpackBenchmarkLpFindNumber}, {"test_listpackBenchmarkLpSeek", test_listpackBenchmarkLpSeek}, {"test_listpackBenchmarkLpValidateIntegrity", test_listpackBenchmarkLpValidateIntegrity}, {"test_listpackBenchmarkLpCompareWithString", test_listpackBenchmarkLpCompareWithString}, {"test_listpackBenchmarkLpCompareWithNumber", test_listpackBenchmarkLpCompareWithNumber}, {"test_listpackBenchmarkFree", test_listpackBenchmarkFree}, {NULL, NULL}}; unitTest __test_networking_c[] = {{"test_writeToReplica", test_writeToReplica}, {"test_postWriteToReplica", test_postWriteToReplica}, {"test_backupAndUpdateClientArgv", test_backupAndUpdateClientArgv}, {"test_rewriteClientCommandArgument", test_rewriteClientCommandArgument}, {"test_addRepliesWithOffloadsToBuffer", test_addRepliesWithOffloadsToBuffer}, {"test_addRepliesWithOffloadsToList", test_addRepliesWithOffloadsToList}, {"test_addBufferToReplyIOV", test_addBufferToReplyIOV}, {NULL, NULL}}; unitTest __test_object_c[] = {{"test_object_with_key", test_object_with_key}, {"test_embedded_string_with_key", test_embedded_string_with_key}, {NULL, NULL}}; unitTest __test_quicklist_c[] = {{"test_quicklistCreateList", test_quicklistCreateList}, {"test_quicklistAddToTailOfEmptyList", test_quicklistAddToTailOfEmptyList}, {"test_quicklistAddToHeadOfEmptyList", test_quicklistAddToHeadOfEmptyList}, {"test_quicklistAddToTail5xAtCompress", test_quicklistAddToTail5xAtCompress}, {"test_quicklistAddToHead5xAtCompress", test_quicklistAddToHead5xAtCompress}, {"test_quicklistAddToTail500xAtCompress", test_quicklistAddToTail500xAtCompress}, {"test_quicklistAddToHead500xAtCompress", test_quicklistAddToHead500xAtCompress}, {"test_quicklistRotateEmpty", test_quicklistRotateEmpty}, {"test_quicklistComprassionPlainNode", test_quicklistComprassionPlainNode}, {"test_quicklistNextPlainNode", test_quicklistNextPlainNode}, {"test_quicklistRotatePlainNode", test_quicklistRotatePlainNode}, {"test_quicklistRotateOneValOnce", test_quicklistRotateOneValOnce}, {"test_quicklistRotate500Val5000TimesAtCompress", test_quicklistRotate500Val5000TimesAtCompress}, {"test_quicklistPopEmpty", test_quicklistPopEmpty}, {"test_quicklistPop1StringFrom1", test_quicklistPop1StringFrom1}, {"test_quicklistPopHead1NumberFrom1", test_quicklistPopHead1NumberFrom1}, {"test_quicklistPopHead500From500", test_quicklistPopHead500From500}, {"test_quicklistPopHead5000From500", test_quicklistPopHead5000From500}, {"test_quicklistIterateForwardOver500List", test_quicklistIterateForwardOver500List}, {"test_quicklistIterateReverseOver500List", test_quicklistIterateReverseOver500List}, {"test_quicklistInsertAfter1Element", test_quicklistInsertAfter1Element}, {"test_quicklistInsertBefore1Element", test_quicklistInsertBefore1Element}, {"test_quicklistInsertHeadWhileHeadNodeIsFull", test_quicklistInsertHeadWhileHeadNodeIsFull}, {"test_quicklistInsertTailWhileTailNodeIsFull", test_quicklistInsertTailWhileTailNodeIsFull}, {"test_quicklistInsertOnceInElementsWhileIteratingAtCompress", test_quicklistInsertOnceInElementsWhileIteratingAtCompress}, {"test_quicklistInsertBefore250NewInMiddleOf500ElementsAtCompress", test_quicklistInsertBefore250NewInMiddleOf500ElementsAtCompress}, {"test_quicklistInsertAfter250NewInMiddleOf500ElementsAtCompress", test_quicklistInsertAfter250NewInMiddleOf500ElementsAtCompress}, {"test_quicklistDuplicateEmptyList", test_quicklistDuplicateEmptyList}, {"test_quicklistDuplicateListOf1Element", test_quicklistDuplicateListOf1Element}, {"test_quicklistDuplicateListOf500", test_quicklistDuplicateListOf500}, {"test_quicklistIndex1200From500ListAtFill", test_quicklistIndex1200From500ListAtFill}, {"test_quicklistIndex12From500ListAtFill", test_quicklistIndex12From500ListAtFill}, {"test_quicklistIndex100From500ListAtFill", test_quicklistIndex100From500ListAtFill}, {"test_quicklistIndexTooBig1From50ListAtFill", test_quicklistIndexTooBig1From50ListAtFill}, {"test_quicklistDeleteRangeEmptyList", test_quicklistDeleteRangeEmptyList}, {"test_quicklistDeleteRangeOfEntireNodeInListOfOneNode", test_quicklistDeleteRangeOfEntireNodeInListOfOneNode}, {"test_quicklistDeleteRangeOfEntireNodeWithOverflowCounts", test_quicklistDeleteRangeOfEntireNodeWithOverflowCounts}, {"test_quicklistDeleteMiddle100Of500List", test_quicklistDeleteMiddle100Of500List}, {"test_quicklistDeleteLessThanFillButAcrossNodes", test_quicklistDeleteLessThanFillButAcrossNodes}, {"test_quicklistDeleteNegative1From500List", test_quicklistDeleteNegative1From500List}, {"test_quicklistDeleteNegative1From500ListWithOverflowCounts", test_quicklistDeleteNegative1From500ListWithOverflowCounts}, {"test_quicklistDeleteNegative100From500List", test_quicklistDeleteNegative100From500List}, {"test_quicklistDelete10Count5From50List", test_quicklistDelete10Count5From50List}, {"test_quicklistNumbersOnlyListRead", test_quicklistNumbersOnlyListRead}, {"test_quicklistNumbersLargerListRead", test_quicklistNumbersLargerListRead}, {"test_quicklistNumbersLargerListReadB", test_quicklistNumbersLargerListReadB}, {"test_quicklistLremTestAtCompress", test_quicklistLremTestAtCompress}, {"test_quicklistIterateReverseDeleteAtCompress", test_quicklistIterateReverseDeleteAtCompress}, {"test_quicklistIteratorAtIndexTestAtCompress", test_quicklistIteratorAtIndexTestAtCompress}, {"test_quicklistLtrimTestAAtCompress", test_quicklistLtrimTestAAtCompress}, {"test_quicklistLtrimTestBAtCompress", test_quicklistLtrimTestBAtCompress}, {"test_quicklistLtrimTestCAtCompress", test_quicklistLtrimTestCAtCompress}, {"test_quicklistLtrimTestDAtCompress", test_quicklistLtrimTestDAtCompress}, {"test_quicklistVerifySpecificCompressionOfInteriorNodes", test_quicklistVerifySpecificCompressionOfInteriorNodes}, {"test_quicklistBookmarkGetUpdatedToNextItem", test_quicklistBookmarkGetUpdatedToNextItem}, {"test_quicklistBookmarkLimit", test_quicklistBookmarkLimit}, {"test_quicklistCompressAndDecompressQuicklistListpackNode", test_quicklistCompressAndDecompressQuicklistListpackNode}, {"test_quicklistCompressAndDecomressQuicklistPlainNodeLargeThanUINT32MAX", test_quicklistCompressAndDecomressQuicklistPlainNodeLargeThanUINT32MAX}, {NULL, NULL}}; diff --git a/src/unit/test_listpack.c b/src/unit/test_listpack.c index d8918326e..8b6106a56 100644 --- a/src/unit/test_listpack.c +++ b/src/unit/test_listpack.c @@ -196,7 +196,7 @@ int test_listpackLpPrependInteger(int argc, char **argv, int flags) { return 0; } -int test_listpackGetELementAtIndex(int argc, char **argv, int flags) { +int test_listpackGetElementAtIndex(int argc, char **argv, int flags) { /* Get element at index */ UNUSED(argc); UNUSED(argv); @@ -236,7 +236,7 @@ int test_listpackPop(int argc, char **argv, int flags) { return 0; } -int test_listpackGetELementAtIndex2(int argc, char **argv, int flags) { +int test_listpackGetElementAtIndex2(int argc, char **argv, int flags) { /* Get element at index */ UNUSED(argc); UNUSED(argv); diff --git a/src/unit/test_rax.c b/src/unit/test_rax.c index 23fc3286c..706d461a5 100644 --- a/src/unit/test_rax.c +++ b/src/unit/test_rax.c @@ -170,7 +170,7 @@ static uint32_t int2int(uint32_t input) { /* Turn an uint32_t integer into an alphanumerical key and return its * length. This function is used in order to generate keys that have - * a large charset, so that the radix tree can be testsed with many + * a large charset, so that the radix tree can be tested with many * children per node. */ static size_t int2alphakey(char *s, size_t maxlen, uint32_t i) { const char *set = "ABCDEFGHIJKLMNOPQRSTUVWXYZ" diff --git a/src/unit/test_sds.c b/src/unit/test_sds.c index d90d14565..1a4d21aff 100644 --- a/src/unit/test_sds.c +++ b/src/unit/test_sds.c @@ -216,37 +216,37 @@ int test_sds(int argc, char **argv, int flags) { /* Test sdsResize - extend */ x = sdsnew("1234567890123456789012345678901234567890"); x = sdsResize(x, 200, 1); - TEST_ASSERT_MESSAGE("sdsReszie() expand type", x[-1] == SDS_TYPE_8); - TEST_ASSERT_MESSAGE("sdsReszie() expand len", sdslen(x) == 40); - TEST_ASSERT_MESSAGE("sdsReszie() expand strlen", strlen(x) == 40); + TEST_ASSERT_MESSAGE("sdsResize() expand type", x[-1] == SDS_TYPE_8); + TEST_ASSERT_MESSAGE("sdsResize() expand len", sdslen(x) == 40); + TEST_ASSERT_MESSAGE("sdsResize() expand strlen", strlen(x) == 40); /* Different allocator allocates at least as large as requested size, * to confirm the allocator won't waste too much, * we add a largest size checker here. */ - TEST_ASSERT_MESSAGE("sdsReszie() expand alloc", sdsalloc(x) >= 200 && sdsalloc(x) < 400); + TEST_ASSERT_MESSAGE("sdsResize() expand alloc", sdsalloc(x) >= 200 && sdsalloc(x) < 400); /* Test sdsResize - trim free space */ x = sdsResize(x, 80, 1); - TEST_ASSERT_MESSAGE("sdsReszie() shrink type", x[-1] == SDS_TYPE_8); - TEST_ASSERT_MESSAGE("sdsReszie() shrink len", sdslen(x) == 40); - TEST_ASSERT_MESSAGE("sdsReszie() shrink strlen", strlen(x) == 40); - TEST_ASSERT_MESSAGE("sdsReszie() shrink alloc", sdsalloc(x) >= 80); + TEST_ASSERT_MESSAGE("sdsResize() shrink type", x[-1] == SDS_TYPE_8); + TEST_ASSERT_MESSAGE("sdsResize() shrink len", sdslen(x) == 40); + TEST_ASSERT_MESSAGE("sdsResize() shrink strlen", strlen(x) == 40); + TEST_ASSERT_MESSAGE("sdsResize() shrink alloc", sdsalloc(x) >= 80); /* Test sdsResize - crop used space */ x = sdsResize(x, 30, 1); - TEST_ASSERT_MESSAGE("sdsReszie() crop type", x[-1] == SDS_TYPE_8); - TEST_ASSERT_MESSAGE("sdsReszie() crop len", sdslen(x) == 30); - TEST_ASSERT_MESSAGE("sdsReszie() crop strlen", strlen(x) == 30); - TEST_ASSERT_MESSAGE("sdsReszie() crop alloc", sdsalloc(x) >= 30); + TEST_ASSERT_MESSAGE("sdsResize() crop type", x[-1] == SDS_TYPE_8); + TEST_ASSERT_MESSAGE("sdsResize() crop len", sdslen(x) == 30); + TEST_ASSERT_MESSAGE("sdsResize() crop strlen", strlen(x) == 30); + TEST_ASSERT_MESSAGE("sdsResize() crop alloc", sdsalloc(x) >= 30); /* Test sdsResize - extend to different class */ x = sdsResize(x, 400, 1); - TEST_ASSERT_MESSAGE("sdsReszie() expand type", x[-1] == SDS_TYPE_16); - TEST_ASSERT_MESSAGE("sdsReszie() expand len", sdslen(x) == 30); - TEST_ASSERT_MESSAGE("sdsReszie() expand strlen", strlen(x) == 30); - TEST_ASSERT_MESSAGE("sdsReszie() expand alloc", sdsalloc(x) >= 400); + TEST_ASSERT_MESSAGE("sdsResize() expand type", x[-1] == SDS_TYPE_16); + TEST_ASSERT_MESSAGE("sdsResize() expand len", sdslen(x) == 30); + TEST_ASSERT_MESSAGE("sdsResize() expand strlen", strlen(x) == 30); + TEST_ASSERT_MESSAGE("sdsResize() expand alloc", sdsalloc(x) >= 400); /* Test sdsResize - shrink to different class */ x = sdsResize(x, 4, 1); - TEST_ASSERT_MESSAGE("sdsReszie() crop type", x[-1] == SDS_TYPE_8); - TEST_ASSERT_MESSAGE("sdsReszie() crop len", sdslen(x) == 4); - TEST_ASSERT_MESSAGE("sdsReszie() crop strlen", strlen(x) == 4); - TEST_ASSERT_MESSAGE("sdsReszie() crop alloc", sdsalloc(x) >= 4); + TEST_ASSERT_MESSAGE("sdsResize() crop type", x[-1] == SDS_TYPE_8); + TEST_ASSERT_MESSAGE("sdsResize() crop len", sdslen(x) == 4); + TEST_ASSERT_MESSAGE("sdsResize() crop strlen", strlen(x) == 4); + TEST_ASSERT_MESSAGE("sdsResize() crop alloc", sdsalloc(x) >= 4); sdsfree(x); return 0; diff --git a/src/valkey-check-aof.c b/src/valkey-check-aof.c index a6e4b97c6..5839bcb34 100644 --- a/src/valkey-check-aof.c +++ b/src/valkey-check-aof.c @@ -477,10 +477,10 @@ void checkMultiPartAof(char *dirpath, char *manifest_filepath, int fix) { sds aof_filename = am->base_aof_info->file_name; sds aof_filepath = makePath(dirpath, aof_filename); last_file = ++aof_num == total_num; - int aof_preable = fileIsRDB(aof_filepath); + int aof_preamble = fileIsRDB(aof_filepath); - printf("Start to check BASE AOF (%s format).\n", aof_preable ? "RDB" : "RESP"); - ret = checkSingleAof(aof_filename, aof_filepath, last_file, fix, aof_preable); + printf("Start to check BASE AOF (%s format).\n", aof_preamble ? "RDB" : "RESP"); + ret = checkSingleAof(aof_filename, aof_filepath, last_file, fix, aof_preamble); printAofStyle(ret, aof_filename, (char *)"BASE AOF"); sdsfree(aof_filepath); } diff --git a/tests/unit/cluster/links.tcl b/tests/unit/cluster/links.tcl index 1f840fd96..68b07048c 100644 --- a/tests/unit/cluster/links.tcl +++ b/tests/unit/cluster/links.tcl @@ -259,7 +259,7 @@ start_cluster 3 0 {tags {external:skip cluster}} { set link_mem_after_pubs [getInfoProperty $res mem_cluster_links] # We expect the memory to have increased by more than - # the culmulative size of the publish messages + # the cumulative size of the publish messages set mem_diff_floor [expr $msg_size * $num_msgs] set mem_diff [expr $link_mem_after_pubs - $link_mem_before_pubs] assert {$mem_diff > $mem_diff_floor} diff --git a/tests/unit/cluster/slave-selection.tcl b/tests/unit/cluster/slave-selection.tcl index cbc237c6e..faabd9ec2 100644 --- a/tests/unit/cluster/slave-selection.tcl +++ b/tests/unit/cluster/slave-selection.tcl @@ -119,7 +119,7 @@ test "Node #10 should eventually replicate node #5" { } ;# start_cluster # Create a cluster with 3 master and 15 slaves, so that we have 5 -# slaves for eatch master. +# slaves for each master. start_cluster 3 15 {tags {external:skip cluster}} { test "Cluster is up" { diff --git a/tests/unit/cluster/slot-stats.tcl b/tests/unit/cluster/slot-stats.tcl index ee5d2c28d..066cfd3c6 100644 --- a/tests/unit/cluster/slot-stats.tcl +++ b/tests/unit/cluster/slot-stats.tcl @@ -474,8 +474,8 @@ start_cluster 1 1 {tags {external:skip cluster} overrides {cluster-slot-stats-en set slot [R 0 cluster keyslot $channel] set primary [Rn 0] set replica [Rn 1] - set replica_subcriber [valkey_deferring_client -1] - $replica_subcriber SSUBSCRIBE $channel + set replica_subscriber [valkey_deferring_client -1] + $replica_subscriber SSUBSCRIBE $channel # *2\r\n$10\r\nssubscribe\r\n$7\r\nchannel\r\n --> 34 bytes. $primary SPUBLISH $channel hello # *3\r\n$8\r\nspublish\r\n$7\r\nchannel\r\n$5\r\nhello\r\n --> 42 bytes. diff --git a/tests/unit/introspection.tcl b/tests/unit/introspection.tcl index 11ebb8b32..f7ae954df 100644 --- a/tests/unit/introspection.tcl +++ b/tests/unit/introspection.tcl @@ -1372,7 +1372,7 @@ start_server {tags {"introspection"}} { lappend backups $c [lindex [r config get $c] 1] } - # multi config set and veirfy + # multi config set and verify assert_equal [eval "r config set $some_configs"] "OK" dict for {c val} $some_configs { assert_equal [lindex [r config get $c] 1] $val