Apply suggestions from code review

JenkinsEnv.json

@@ -10,7 +10,7 @@
 				"DockerImage": "gserver-v2",
 				"Tag": "",
 				"Dockerfile": "docker/gserver-x86_64-linux-musl.dockerfile",
-				"BuildIfSuccessful": "both",
+				"BuildIfSuccessful": "image",
 				"BuildEnv": "--build-arg NPCSERVER=on"
 			}
 		},
@@ -24,7 +24,7 @@
 				"DockerImage": "gserver-v2",
 				"Tag": "-no-npcserver",
 				"Dockerfile": "docker/gserver-x86_64-linux-musl.dockerfile",
-				"BuildIfSuccessful": "both",
+				"BuildIfSuccessful": "image",
 				"BuildEnv": "--build-arg NPCSERVER=off"
 			}
 		},

Jenkinsfile

@@ -196,7 +196,7 @@ def buildStepDocker(DOCKER_ROOT, DOCKERIMAGE, DOCKERTAG, DOCKERFILE, BUILD_NEXT,
 											release_type_tag = 'nightly';
 										}
 
-										def files = sh(returnStdout: true, script: 'find . -name "*.zip" -o -name "*.tar.gz"'); //findFiles(glob: './dist/*');
+										def files = sh(returnStdout: true, script: 'find . -name "*.zip" -o -name "*.tar.gz"');
 										files = sh (script: "basename ${files}",returnStdout:true).trim()
 
 										echo "${files}"

bin/changelog.txt

@@ -6,7 +6,14 @@
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 * Update gs2compiler - fix getangle and getdir
 + Update gs2compiler - added gs2 support for arraylen/sarraylen functions
++ Added `public function` for serverside scripting, to access functions on an npc from another npc
++ Added ability to get/set tiles on serverside scripting via `level.tiles[index]`
++ Added arrow drop class, so if there's a class named `darts` it will drop this npc instead of the default item. Might change in a future release
 * Fixed shoot2 for v6 clients
+* Fixed updateboard request causing illegal packet disconnection
+* Fixed so player.platform is correctly set when connecting with a v4+ client
+
+
 
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   Changelog for:

my.rc.in

@@ -11,9 +11,9 @@ BEGIN
       VALUE "FileDescription", "${PROJECT_DESCRIPTION}"
       VALUE "FileVersion", "${VER_X}.${VER_Y}${VER_Z}"
       VALUE "InternalName", "${PROJECT_NAME_CLEAN}"
-      VALUE "LegalCopyright", "Copyright © 2005-${VER_YEAR} ${CPACK_PACKAGE_VENDOR}"
+      VALUE "LegalCopyright", "Copyright © 2005-${VER_YEAR} ${CPACK_PACKAGE_VENDOR}"
       VALUE "OriginalFilename", "${PROJECT_NAME}.exe"
-      VALUE "ProductName", "${PROJECT_NAME_CLEAN}"
+      VALUE "ProductName", "${PROJECT_NAME}"
       VALUE "ProductVersion", "${VER_X}.${VER_YZ}"
     END
   END

server/include/Scripting/v8/V8ScriptWrappers.h

@@ -10,6 +10,7 @@
 
 const std::regex word_regex(R"((public[\s]+function[\s]+){1}(\w+)[\s]*\()");
 
+//TODO: Move to CPP-file
 inline std::string getPublicFunctions(const std::string_view& code)
 {
 	std::vector<std::string> eventList;

server/src/TLevel/TLevel.cpp

@@ -1142,6 +1142,7 @@ bool TLevel::addItem(float pX, float pY, LevelItemType pItem)
 		return false;
 	}
 
+	//TODO: Make a super-class to handle all drops?
 	if (LevelItemType::DARTS == pItem)
 	{
 		if (server->getClass("darts") == nullptr)