mirror of
git://git.sv.gnu.org/coreutils
synced 2026-05-14 10:57:22 -04:00
maint: clarify df's use of device IDs from /proc/self/mountinfo
* src/df.c (filter_mount_list): Clarify why we still stat even though devices IDs may already be available. Note using /proc/self/mountinfo is still an advantage to get filtered items with accurate device patchs in chroots and with bind mounts. I.E. on older setups with static /etc/mtab, df will now bypass that to get the more accuracte and dynamic info.
This commit is contained in:
@@ -623,10 +623,8 @@ filter_mount_list (bool devices_only)
|
||||
struct mount_entry *discard_me = NULL;
|
||||
|
||||
/* Avoid stating remote file systems as that may hang.
|
||||
TODO: On Linux we might avoid this stat() and another in get_dev()
|
||||
by using the device IDs available from /proc/self/mountinfo.
|
||||
read_file_system_list() could populate me_dev from those
|
||||
for efficiency and accuracy. */
|
||||
On Linux we probably have me_dev populated from /proc/self/mountinfo,
|
||||
however we still stat() in case another device was mounted later. */
|
||||
if ((me->me_remote && show_local_fs)
|
||||
|| -1 == stat (me->me_mountdir, &buf))
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user