Michael Paquier
73dab12719
An out-of-memory failure while initializing the type cache hash tables would issue an ERROR and leave a backend in a partially inconsistent state. Without assertions, the server would crash with a NULL pointer dereference on initialization re-entry when doing a type lookup due to one or both hash tables missing. An assertion would trigger if these are enabled in the build. This commit changes the ordering of the type cache initialization to become more robust on re-entry after an in-flight allocation failure: - The two hash tables are initialized first, and can only be initialized once. - The initialization is considered as done once the in-progress list is allocated in the CacheMemoryContext. This is now the last allocation step. - Last, the callbacks are registered. These can only fail with a FATAL error, taking down the process so leaving the process in a non-complete state is fine. This is in the same spirit asb85f9c00fband29fb598b9c, where random allocation failures can make the backend go crazy in the code paths fixed due to the static states becoming inconsistent. Like the other fixes, this is unlikely going to show up in practice, so no backpatch is done. Reported-by: Alexander Lakhin <exclusion@gmail.com> Author: Michael Paquier <michael@paquier.xyz> Reviewed-by: Matthias van de Meent <boekewurm+postgres@gmail.com> Discussion: https://postgr.es/m/e77acaac-a1b3-40b3-99ee-5769b4e453e4@gmail.com
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.