Fix debuginfo compression in bootstrap
Found through https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/weird.20code.20in.20fill_target_compiler/with/604588655.
This PR solves a few issues with debuginfo compression in bootstrap.
The main issue was that debuginfo compression through the `-gz` flag wasn't enabled, by mistake.
When `cc-rs` checks if a compiler flag is supported, it tries to read `out_dir` to generate the source file in. However, when this option is not set, then the check silently fails and the flag is considered to be unsupported. Since we didn't set `out_dir`, all such added flags were simply ignored.
Normally, it reads `OUT_DIR`, which is fine if `cc-rs` is used within a build script. But if it is used elsewhere, then this is a pretty gnarly footgun in `cc-rs`, because the failure is [completely silent](https://github.com/rust-lang/cc-rs/blob/main/src/lib.rs#L1483). CC @madsmtm or @NobodyXu in case you have thoughts on that :)
After that was fixed, I had to change the used compression flag from `-gz` to `--compress-debug-sections`, to support both BFD and LLD linkers.
And to solve it properly, and allow `dist` CI jobs to configure debuginfo compression for all targets that they build, I added a new bootstrap option to configure debuginfo compression.
I wanted the flag to be configurable both globally and per target. At the same time, the flag applies both to C/C++ and Rust. We currently don't have such config area in `bootstrap.toml`, and `[build]` didn't seem like the right place, so I shoved it into `[rust]` (while documenting that it also applies to C/C++).
r? @bjorn3
try-job: dist-x86_64-msvc
try-job: dist-x86_64-apple
try-job: dist-x86_64-linux
try-job: dist-various-1
try-job: dist-various-2
Cleanup attribute docs and add links to other mentioned attributes
It's always nicer to be able to jump to the item being mentioned directly without having to go through search.
Also, cleaned up a few small things like `rust` attribute in codeblocks which is the default, so it's redundant.
Add missing generic test coverage for ```#[splat]```
This PR adds missing test coverage for `#[splat]` that was marked as FIXME in `splat-generics-everywhere.rs`:
- Add generic parameter to `BarTrait` (`BarTrait<T>`)
- Add `generic_in_tuple` , tests generics inside the splatted tuple
- Add `generic_tuple_assoc` , tests assoc functions with splatted generic tuple traits
- Add `trait_generic_in_tuple` , tests generics inside splatted tuple on trait methods
- Add `trait_generic_tuple` , tests splatted generic tuple trait bounds on trait methods
Removes the resolved FIXME comments:
- also add generics to the trait
- also add assoc/method with splatted generic tuple traits
- also add generics inside the splatted tuple
CC:- @teor2345
r? @teor2345
Remove unnecessary `Hash` derives from MIR types
This starts with `StatementKind` and `TerminatorKind`; they don't need hashing. That then allows the removal of the `Hash` impl of various other types.
r? @dingxiangfei2009
Avoid ICE for `NonZero<char>` in improper_ctypes
Fixesrust-lang/rust#158511
This pr enables `get_nullable_type` to return `char` as the carrier for `NonZero<char>` and replaces the raw `unwrap()` with an `expect()` message.
Add extra splat tests
This PR is part of the splat lang experiment rust-lang/rust#153629.
It adds a bunch of tests for existing splat functionality, but doesn't make any compiler code changes.
Edit: split off from PR rust-lang/rust#158645
@rustbot label +F-splat +T-compiler
library: Polish transmute's `split_at_stdlib` example
Splitting assembling the return value over multiple let-bindings enables pedagogic discussion of each named let-binding.
The `slice` arg was renamed to remove any chance of visual confusion with use of `core::slice` functions or "slice" per se.
Remove `src/tools/test-float-parse/Cargo.lock`
This tool is part of the main workspace, so its own lock file is unused,
and the file is clearly outdated for its current dependencies anyway.
hir_ty_lowering: avoid self type lookup for inherent aliases
fixesrust-lang/rust#158512
the crash happens while building the unsatisfied-bounds diagnostic for an inherent associated alias. that path was calling `self_ty()` directly, so an empty args list could panic under the global next solver.
imo the guard belongs in the diagnostic code. it keeps the existing span label when the inherent alias still has a self arg, and only skips that label when the args are already malformed.
Improve diagnostic for too many super keywords
Fixesrust-lang/rust#158275
When resolving a path with too many leading `super` segments inside a nested module,
include the current module path in the diagnostic. This makes it easier to see where
the `super` chain started, especially for generated code or code included from
another location.
The overflowing `super` label now also explains that it would go above the crate root.
Example:
```text
error[E0433]: too many leading `super` keywords within `crate::outer::inner`
--> tests/ui/resolve/too-many-super-issue-158275.rs:5:38
|
LL | struct Example(super::super::super::Impl);
| ^^^^^ this `super` would go above the crate root
```
Tests:
```text
x.py --build x86_64-pc-windows-gnu --host x86_64-pc-windows-gnu check compiler/rustc_resolve --stage 1
x.py --build x86_64-pc-windows-gnu --host x86_64-pc-windows-gnu test tidy
```
Add `riscv32imfc-unknown-none-elf` bare-metal target
This adds a new tier 3 bare-metal target for RV32IMFC cores: RISC-V 32-bit with
the `M`, `F` (hardware single-precision float, `ilp32f` ABI) and `C` extensions,
but **no** atomic (`A`) extension.
## Why a new builtin target
No builtin target pairs **hardware single-float** with **no atomics** today:
- `riscv32imafc-unknown-none-elf` (tier 2) has hard-float but *requires* `A`.
- `riscv32imc-unknown-none-elf` has no atomics but is **soft-float** (`ilp32`).
Cores that have an `F` unit but no `A` extension (a common shape for the
application core of low-power Wi-Fi/BT SoCs, where vendor-supplied closed binary
blobs are compiled with the `ilp32f` ABI, so the soft-float ABI is incompatible)
currently have to ship a custom JSON target spec and build `core` with
`-Zbuild-std` on nightly. There is **no stable path today**: custom target specs
are nightly-only, and the spec drifts with each nightly. A builtin target lets
these users stay on stable with a precompiled `core`. The motivating hardware
includes the application core of SoCs such as the HiSilicon WS63/BS2X family, but
the target itself is vendor-neutral.
A working nightly + `-Zbuild-std` proof of concept (builds `core`/`alloc`,
confirms hard-float `fmul.s`/`fadd.s`, and that atomics lower to plain `lw`/`sw`
with zero `amo*`/`lr.w`/`sc.w`): https://github.com/hispark-rs/hisi-riscv-imfc-poc
## How it is defined
It is `riscv32imafc-unknown-none-elf` minus the `A` extension, handled exactly the
way the existing `riscv32imc-unknown-none-elf` handles a no-`a` core:
- `features = "+m,+f,+c,+forced-atomics"`, `llvm_abiname = ilp32f`
- `atomic_cas = false`: `lr.w`/`sc.w`/`amo*` are never emitted, so the target does
not trap on a core without `A`. `+forced-atomics` lowers atomic load/store to
plain load/store (sound on a single hart); compare-and-swap and other RMW
atomics are off, so downstream crates use a critical-section polyfill (e.g.
`portable-atomic`'s `critical-section` feature) for those.
## Changes
- New target spec `riscv32imfc_unknown_none_elf.rs` + registration in `spec/mod.rs`.
- Added to the `tests/assembly-llvm/targets/targets-elf.rs` sanity test (satisfies
the `target_policy` and `target_specific_tests` tidy checks).
- Documented on the shared `riscv32-unknown-none-elf` platform-support page and
listed in `platform-support.md`.
## Verification
- `./x test tidy` — passes.
- `./x test tests/assembly-llvm/targets/targets-elf.rs` — passes (262 passed,
0 failed); satisfies the "must be able to produce assembly" requirement.
## Tier 3 target policy
Acknowledgement of each [tier 3 target policy](https://doc.rust-lang.org/rustc/target-tier-policy.html#tier-3-target-policy) requirement:
> A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)
Ack. @sanchuanhehe will maintain the target; recorded on the
`riscv32-unknown-none-elf` platform-support page.
> Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
>
> Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.
>
> If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.
Ack. The target is named `riscv32imfc-unknown-none-elf`, fitting the existing
`riscv32im{,a,c,fc,ac,afc}-unknown-none-elf` family: standard RISC-V ISA-extension
letters (`imfc`) and the `unknown-none-elf` triple shared by the other bare-metal
RISC-V targets. The name uses only letters, numbers and dashes.
> Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.
>
> The target must not introduce license incompatibilities.
>
> Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0).
>
> The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy.
>
> Compiling, linking, and emitting functional binaries, libraries, or other code for the target must not depend on proprietary (non-FOSS) libraries.
Ack. Everything added is under `MIT OR Apache-2.0`. The change is a purely
additive target spec plus docs and a test; it introduces no new dependency and no
proprietary component. Code generation uses the in-tree LLVM RISC-V backend only.
> Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
Ack.
> Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.
Ack. This is a bare-metal `no_std` target (`std: false`). `core` and `alloc`
build for it, the same as the sibling `riscv32imc` / `riscv32imafc` targets; `std`
is not applicable as there is no operating system layer.
> The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.
Ack. Documented on the shared `riscv32-unknown-none-elf` platform-support page
(cross-compiled, `rust-lld`, linker-script requirement). Like the other bare-metal
RISC-V targets, the Rust test suite cannot be run on it; it must be run in a
simulator or on hardware.
> Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
Ack.
> Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target. In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.
Ack. The change is additive only and touches no code shared with other targets;
`./x test tidy` and the `targets-elf` assembly test pass. No unconditional use of
any feature is introduced that would affect other RISC-V target variations.
> Tier 3 targets must be able to produce assembly using at least one of rustc's supported backends from any host target. (Having support in a fork of the backend is not sufficient, it must be upstream.)
Ack. Covered by the new `tests/assembly-llvm/targets/targets-elf.rs` revision,
which passes using the upstream LLVM backend.
> If a tier 3 target stops meeting these requirements [...] we may post a PR to remove it; any such PR will be CCed to the target maintainers [...] to check potential interest in improving the situation.
Ack.
Simplify option-iterator flattening in the compiler
In many cases where we are flattening `option::IntoIter<I>`, we can use
`Option::into_flat_iter()` instead for a simpler implementation. A few
other cases have more direct constructs available.
use ProjectionPredicate instead of AliasRelate
part of https://github.com/rust-lang/rust/issues/155345
this PR is split into three commits:
- refactoring `super_combine_{tys,consts}`, should not change behavior at all, just reorganizing code
- convert to use ProjectionPredicate instead of AliasRelate in super_combine_tys and generalization (this is the important change for this PR)
- deleting the now-dead AliasRelate predicate
r? @lcnr
Improve E0277 diagnostics for conditionally implemented traits
Fixesrust-lang/rust#158423.
The diagnostic previously reported that a trait was "implemented" even when the matching impl could not apply because its where-clause requirements were not satisfied, which was misleading.
This change:
- reports that the trait is "conditionally implemented" when a matching impl is rejected due to unsatisfied where-clause requirements;
- highlights the unsatisfied requirement in the impl and includes the corresponding predicate in the diagnostic;
- preserves the existing diagnostic flow while making it clearer why the candidate impl was rejected.
Emit retags in codegen to support BorrowSanitizer (part 4)
Tracking issue: https://github.com/rust-lang/rust/issues/154760
[Zulip Thread](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Staging.20for.20emitting.20retags.20in.20codegen/with/593004012)
This is one of several PRs that add experimental support for emitting retags as function calls in codegen.
This PR emits our retag intrinsics based on the structure of a `RetagPlan`. The feature works end-to-end now! But, it has two limitations:
* We do not track interior mutable or pinned ranges precisely. This will come in the next PR, which should be the last one that we need to complete this feature (excluding documentation and compile tests).
* We recurse into `repr(simd)` types when building a `RetagPlan`, but we do not emit retags for their fields. We would need `BuilderMethods::insert_element`, which isn't available. I'm not sure what the best workaround would be for this.
Related: rust-lang/rust#157825, rust-lang/rust#156210, rust-lang/rust#156208
Cc: @RalfJung
r? @saethlin
Mirror kernel archives in `ci-mirrors` to not depend on currently unavailable kernel mirror sources
## Summary
(Tempoarily) closesrust-lang/rust#158718.
See [#t-infra > kernel.org is borked](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/kernel.2Eorg.20is.20borked/with/608182062).
Currently rust-lang/rust CI is borked because:
1. `armhf-gnu` directly tries to download kernel v4.x artifacts from kernel.org mirror, and
2. certain `dist-*` jobs tries to download kernel v3.x and v4.x artifacts from kernel.org mirror indirectly via crosstools-ng ("CT-NG") [^1].
[^1]: Add v5.x but those are already recovered.
However, kernel.org mirror sync infra has an active incident (ref: https://status.linuxfoundation.org/incidents/3y1k8b4ky71t) where not all files are available. In particular, v3.x and v4.x kernel artifacts are not recovered yet as of time of writing (check <https://mirrors.edge.kernel.org/pub/linux/kernel/>).
### Mitigation
This PR tries to mitigate this by using our own mirrored kernel artifacts from `ci-mirrors` (see https://github.com/rust-lang/ci-mirrors/pull/41, https://github.com/rust-lang/ci-mirrors/pull/42, https://github.com/rust-lang/ci-mirrors/pull/43), such that `linux-$A.$B.$C.tar.gz` artifacts become available as search locations to CT-NG.
We carry a patch to CT-NG to use our own `ci-mirrors` artifact SHA256 checksums, the checksum mismatches are as far as we know due to compression setting differences (`ci-mirrors` source archives from <https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/snapshot/>).
## Notes
- `armhf-gnu` still has artifacts from third-party mirrors/sources (busybox, ubuntu-base-22.04.2). Not in scope of this PR.
- It looks like `3.*` kernel series are considered obselete by CT-NG, and need `CT_OBSOLETE=y` config.
- CT-NG checks for known-good kernel versions and checksums against the provided mirror.
### CT-NG known good versions
Re. latest kernel versions in each release versus what CT-NG 1.28.0 considers a known good version w/ checksum:
Kernel LTS release series | Last release in the series | CT-NG 1.28.0 known good kernel version w/ checksum
-- | -- | --
3.2.* | 3.2.102 | **3.2.101**
3.10.* | 3.10.108 | 3.10.108
4.4.* | 4.4.302 | 4.4.302
4.19.* | 4.19.325 | 4.19.325
4.20.* | 4.20.17 | 4.20.17
5.19.* | 5.19.17 | **5.19.16**
(**Bold** CT-NG known good version indicates not latest in release series.)
### `ci-mirrors` kernal tarball SHA256 checksums
Refer to https://github.com/rust-lang/ci-mirrors/blob/b474b4bb35108dab668907172c858854f209c809/files/rustc/kernel.toml:
| **Kernel Version** | **SHA256** |
| ------------------ | ------------------------------------------------------------------ |
| 3.2.101 | `93e8391e029f131d5ba4b7ad76cc34b12f2c2244059604042f2297c4bde093f7` |
| 3.10.108 | `b1711610cf3faf7194156dacdb98c63c1b7ffd02377269d7f75df63d823ccbba` |
| 4.4.302 | `a22ceab143d40f511203265e5a70d6cc5ec39163cd54fa281346d19176f64451` |
| 4.19.325 | `8753443636e475b506e08abd40059ec9b84904a115d206014f0c856dfe13a25e` |
| 4.20.17 | `313b7bebb46084efbfcaf75f4ea6faf2e14c8cbc1711fcba483dc0a036c9acc1` |
| 5.19.16 | `bbf0ead65559250e0784c13d4f9716b7f917a1d3a4e00f671f3994cc6990bb02` |
---
try-job: armhf-gnu
try-job: dist-armhf-linux
try-job: dist-arm-linux-gnueabi
try-job: dist-powerpc64le-linux-musl
try-job: dist-loongarch64-musl
try-job: dist-riscv64-linux
try-job: dist-powerpc64le-linux-gnu
try-job: dist-powerpc64-linux-musl
try-job: dist-armv7-linux
try-job: dist-powerpc-linux
try-job: dist-loongarch64-linux
try-job: dist-s390x-linux
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-powerpc64-linux-gnu
These removed fields are never set, and thus are always `None`. Once
they are removed, several `make_*` methods can be simplified, or
entirely removed (giving the default `MacResult` behaviour).
Note also that `self.impl_items` was being returned for both
`make_impl_items` and `make_trait_impl_items`, which clearly wasn't
correct.
bors