Commit Graph

9920 Commits

Author SHA1 Message Date
Mike Bayer 8ac2bec029 - Liberalized an assertion that was added as part of 🎫3347
to protect against unknown conditions when splicing inner joins
together within joined eager loads with ``innerjoin=True``; if
some of the joins use a "secondary" table, the assertion needs to
unwrap further joins in order to pass.
fixes #3412
2015-05-02 11:33:54 -04:00
Mike Bayer 77db0ef6ac - Fixed bug in enhanced constraint-attachment logic introduced in
🎫`3341` where in the unusual case of a constraint that refers
to a mixture of :class:`.Column` objects and string column names
at the same time, the auto-attach-on-column-attach logic will be
skipped; for the constraint to be auto-attached in this case,
all columns must be assembled on the target table up front.
Added a new section to the migration document regarding the
original feature as well as this change.
fixes #3411
2015-05-02 10:27:03 -04:00
Mike Bayer b2196dd953 - start qualifying some regressions as "unexpected use"
regressions; regressions where we didn't know an API even worked
in a particular way or that anyone were using it in such a way
hence had no tests for such case.
2015-05-02 10:08:11 -04:00
Mike Bayer 5d8a608722 - update 3.4 callcounts 2015-05-01 17:59:11 -04:00
Mike Bayer 2ef1c56436 - move away from explicit raises of SkipTest, instead call a
function patched onto config.  nose/pytest backends now fill
in their exception class here only when loaded
- use more public seeming api to get at py.test Skipped
exception
2015-05-01 13:15:51 -04:00
Mike Bayer 95949db715 - Repair _reinstall_default_lookups to also flip the _extended flag
off again so that test fixtures setup/teardown instrumentation as
expected
- clean up test_extendedattr.py and fix it to no longer leak
itself outside by ensuring _reinstall_default_lookups is always called,
part of #3408
- Fixed bug where when using extended attribute instrumentation system,
the correct exception would not be raised when :func:`.class_mapper`
were called with an invalid input that also happened to not
be weak referencable, such as an integer.
fixes #3408
2015-05-01 12:33:45 -04:00
Mike Bayer 635f06c3eb - turn sessions in ResultTest to autocommit=True just to get them
to clean up automatically.  references #3407
2015-05-01 10:00:23 -04:00
Mike Bayer 088666e8f3 - Fixed an import that prevented "pypy setup.py test" from working
correctly.
fixes #3406
2015-05-01 09:38:21 -04:00
Mike Bayer 24d6ea362e - Repaired / added to tests yet more expressions that were reported
as failing with the new 'entity' key value added to
:attr:`.Query.column_descriptions`, the logic to discover the "from"
clause is again reworked to accommodate columns from aliased classes,
as well as to report the correct value for the "aliased" flag in these
cases.
fixes #3409
2015-05-01 09:20:10 -04:00
Mike Bayer 3cfda0a3c9 1.0.3 rel_1_0_3 2015-04-30 21:33:26 -04:00
Mike Bayer 681276b5b4 - Fixed regression from 0.9.10 prior to release due to 🎫3349
where the check for query state on :meth:`.Query.update` or
:meth:`.Query.delete` compared the empty tuple to itself using ``is``,
which fails on Pypy to produce ``True`` in this case; this would
erronously emit a warning in 0.9 and raise an exception in 1.0.
fixes #3405
2015-04-30 21:26:48 -04:00
Mike Bayer 4992aafecc - revise the last commit with a more traditional approach
using descriptors; ensure that mock.patch() honors descriptor setters
2015-04-30 20:20:02 -04:00
Mike Bayer e0f9b279f4 - work the wrapping of the "creator" to be as resilient to
old / new style, direct access, and ad-hoc patching and
unpatching as possible
2015-04-30 19:55:28 -04:00
Mike Bayer 0e98795ff2 - New features added to support engine/pool plugins with advanced
functionality.   Added a new "soft invalidate" feature to the
connection pool at the level of the checked out connection wrapper
as well as the :class:`._ConnectionRecord`.  This works similarly
to a modern pool invalidation in that connections aren't actively
closed, but are recycled only on next checkout; this is essentially
a per-connection version of that feature.  A new event
:class:`.PoolEvents.soft_invalidate` is added to complement it.
fixes #3379

- Added new flag
:attr:`.ExceptionContext.invalidate_pool_on_disconnect`.
Allows an error handler within :meth:`.ConnectionEvents.handle_error`
to maintain a "disconnect" condition, but to handle calling invalidate
on individual connections in a specific manner within the event.

- Added new event :class:`.DialectEvents.do_connect`, which allows
interception / replacement of when the :meth:`.Dialect.connect`
hook is called to create a DBAPI connection.  Also added
dialect plugin hooks :meth:`.Dialect.get_dialect_cls` and
:meth:`.Dialect.engine_created` which allow external plugins to
add events to existing dialects using entry points.
fixes #3355
2015-04-30 17:51:14 -04:00
Mike Bayer 20e3df6028 - Fixed regression from as yet unreleased 0.9.10 where the new addition
of ``entity`` to the :attr:`.Query.column_descriptions` accessor
would fail if the target entity was produced from a core selectable
such as a :class:`.Table` or :class:`.CTE` object.
fixes #3403  references #3320
2015-04-30 12:53:27 -04:00
Mike Bayer 606a9b02e5 - Added a placeholder method :meth:.TypeEngine.compare_against_backend
which is now consumed by Alembic migrations as of 0.7.6.  User-defined
types can implement this method to assist in the comparison of
a type against one reflected from the database.
2015-04-30 11:38:24 -04:00
Mike Bayer b0be9211c9 - Fixed regression within the flush process when an attribute were
set to a SQL expression for an UPDATE, and the SQL expression when
compared to the previous value of the attribute would produce a SQL
comparison other than ``==`` or ``!=``, the exception "Boolean value
of this clause is not defined" would raise.   The fix ensures that
the unit of work will not interpret the SQL expression in this way.
fixes #3402
2015-04-29 14:00:16 -04:00
Mike Bayer 93b5eae984 - add boldface for "viable" plus a note describing that this
refers to the table having a primary key.  fixes #3398
2015-04-29 00:05:25 -04:00
Mike Bayer 4f6e9ccae9 - Fixed bug in association proxy where an any()/has()
on an relationship->scalar non-object attribute comparison would fail,
e.g.
``filter(Parent.some_collection_to_attribute.any(Child.attr == 'foo'))``
fixes #3397
2015-04-28 19:20:01 -04:00
Mike Bayer ac52239b32 - Fixed bug where the truncation of long labels in SQL could produce
a label that overlapped another label that is not truncated; this
because the length threshhold for truncation was greater than
the portion of the label that remains after truncation.  These
two values have now been made the same; label_length - 6.
The effect here is that shorter column labels will be "truncated"
where they would not have been truncated before.
fixes #3396
2015-04-28 16:02:59 -04:00
mike bayer 0783cb9337 Merge pull request #170 from eronisko/fix_typo
Fix typo in 'Relationships API' docs
2015-04-28 10:10:40 -04:00
Ernest Walzel da327d0349 Fix typo in 'Relationships API' docs
exprssed -> expressed
2015-04-28 12:27:00 +01:00
Mike Bayer 34f98a63b5 - altered part of the use contract first set up in #2992; we
now skip textual label references when copying ORDER BY elements
to the joined-eager-load subquery, as we can't know that these
expressions are compatible with this placement;  either because
they are meant for text(), or because they refer to label names
already stated and aren't bound to a table. fixes #3392
2015-04-27 17:40:41 -04:00
Mike Bayer e5c20fce93 - replace old crufty ddl event test fixture with mock 2015-04-27 15:21:18 -04:00
Mike Bayer e25ef01fbb - Fixed regression due to 🎫3282 where the `tables` collection
passed as a keyword argument to the :meth:`.DDLEvents.before_create`,
:meth:`.DDLEvents.after_create`, :meth:`.DDLEvents.before_drop`, and
:meth:`.DDLEvents.after_drop` events would no longer be a list
of tables, but instead a list of tuples which contained a second
entry with foreign keys to be added or dropped.  As the ``tables``
collection, while documented as not necessarily stable, has come
to be relied upon, this change is considered a regression.
Additionally, in some cases for "drop", this collection would
be an iterator that would cause the operation to fail if
prematurely iterated.   The collection is now a list of table
objects in all cases and test coverage for the format of this
collection is now added.
fixes #3391
2015-04-27 15:05:41 -04:00
Mike Bayer 6c0f30db81 - Fixed a regression regarding the :meth:.MapperEvents.instrument_class
event where its invocation was moved to be after the class manager's
instrumentation of the class, which is the opposite of what the
documentation for the event explicitly states.  The rationale for the
switch was due to Declarative taking the step of setting up
the full "instrumentation manager" for a class before it was mapped
for the purpose of the new ``@declared_attr`` features
described in :ref:`feature_3150`, but the change was also made
against the classical use of :func:`.mapper` for consistency.
However, SQLSoup relies upon the instrumentation event happening
before any instrumentation under classical mapping.
The behavior is reverted in the case of classical and declarative
mapping, the latter implemented by using a simple memoization
without using class manager.
fixes #3388
2015-04-26 18:22:41 -04:00
Mike Bayer d48acff23b - Fixed issue in new :meth:.QueryEvents.before_compile event where
changes made to the :class:`.Query` object's collection of entities
to load within the event would render in the SQL, but would not
be reflected during the loading process.
fixes #3387
2015-04-26 12:33:17 -04:00
Mike Bayer 6833669469 - try pinning a tag here to for RTD to please build correctly 2015-04-25 10:48:54 -04:00
Mike Bayer 42c9fe1d1d 1.0.2 rel_1_0_2 2015-04-24 18:03:01 -04:00
Mike Bayer 723e07a374 - reword the notes here 2015-04-24 18:02:57 -04:00
Mike Bayer 372e0600d9 - fix link 2015-04-24 17:55:05 -04:00
Mike Bayer f58ca25df7 - tag declarative as "orm declarative" 2015-04-24 17:52:00 -04:00
Mike Bayer c71c7444ec - add a note about that resolution 2015-04-24 17:28:19 -04:00
Mike Bayer f9275198c3 - Fixed a regression that was incorrectly fixed in 1.0.0b4
(hence becoming two regressions); reports that
SELECT statements would GROUP BY a label name and fail was misconstrued
that certain backends such as SQL Server should not be emitting
ORDER BY or GROUP BY on a simple label name at all; when in fact,
we had forgotten that 0.9 was already emitting ORDER BY on a simple
label name for all backends, as described in :ref:`migration_1068`,
as 1.0 had rewritten this logic as part of 🎫`2992`.

In 1.0.2, the bug is fixed both that SQL Server, Firebird and others
will again emit ORDER BY on a simple label name when passed a
:class:`.Label` construct that is expressed in the columns clause,
and no backend will emit GROUP BY on a simple label name in this case,
as even Postgresql can't reliably do GROUP BY on a simple name
in every case.
fixes #3338, fixes #3385
2015-04-24 17:04:35 -04:00
Mike Bayer 0170075934 - add the "strict" version of this lookup for __abstract__ as well,
fixes #3383
2015-04-24 17:03:34 -04:00
Mike Bayer f7e89f887f Merge remote-tracking branch 'origin/pr/169' 2015-04-24 15:52:42 -04:00
Mike Bayer e73f735382 - Fixed regression regarding the declarative `__declare_first__`
and ``__declare_last__`` accessors where these would no longer be
called on the superclass of the declarative base.
fixes #3383
2015-04-24 13:49:09 -04:00
Gaëtan de Menten e77cf339ee micro-optimize unique_list
This makes unique_list approx 2x faster in my (simple) tests
2015-04-24 14:26:42 +02:00
Mike Bayer 0fc751e4ab 1.0.1 rel_1_0_1 2015-04-23 14:21:56 -04:00
Mike Bayer 350d002ee9 - update date
- repair category for EXISTS issue
2015-04-23 14:21:56 -04:00
Mike Bayer 846b2b835e - change/migration edits 2015-04-23 13:43:25 -04:00
Mike Bayer dd4240e43b - Fixed support for "literal_binds" mode when using limit/offset
with Firebird, so that the values are again rendered inline when
this is selected.  Related to 🎫`3034`.
fixes #3381
2015-04-23 12:07:56 -04:00
Mike Bayer 167a45a442 changelog for #3380, fixes #3380 2015-04-23 11:40:40 -04:00
effem-git ce1ab2bef3 Update base.py
Fix TypeError: Boolean value of this clause is not defined
2015-04-23 13:00:42 +02:00
Mike Bayer 39978060b0 - repair a regression caused by #3282, where we no longer were
applying any topological sort to tables on SQLite.  See the
changelog for details, but we now continue to sort
tables for SQLite on DROP, prohibit the sort from considering
alter, and only warn if we encounter an unresolvable cycle, in
which case, then we forego the ordering.  use_alter as always
is used to break such a cycle.
fixes #3378
2015-04-22 14:14:11 -04:00
Mike Bayer f704b7265a - correct migration note for #3084; doesn't apply to create/drop 2015-04-22 11:59:08 -04:00
Mike Bayer 4442eb3e1e - typo 2015-04-21 13:05:24 -04:00
Mike Bayer 732fb99fc0 - add a warning to SingletonThreadPool that it isn't for general use 2015-04-21 11:04:21 -04:00
Mike Bayer c2e3002503 - Added the string value `"none"` to those accepted by the
:paramref:`.Pool.reset_on_return` parameter as a synonym for ``None``,
so that string values can be used for all settings, allowing
.ini file utilities like :func:`.engine_from_config` to be usable
without issue.
fixes #3375
2015-04-21 10:04:02 -04:00
Mike Bayer 3e80d628bd - Fixed issue where a straight SELECT EXISTS query would fail to
assign the proper result type of Boolean to the result mapping, and
instead would leak column types from within the query into the
result map.  This issue exists in 0.9 and earlier as well, however
has less of an impact in those versions.  In 1.0, due to #918
this becomes a regression in that we now rely upon the result mapping
to be very accurate, else we can assign result-type processors to
the wrong column.   In all versions, this issue also has the effect
that a simple EXISTS will not apply the Boolean type handler, leading
to simple 1/0 values for backends without native boolean instead of
True/False.   The fix includes that an EXISTS columns argument
will be anon-labeled like other column expressions; a similar fix is
implemented for pure-boolean expressions like ``not_(True())``.
fixes #3372
2015-04-20 19:21:00 -04:00