mirror of
https://github.com/supabase/supabase.git
synced 2026-08-03 13:20:20 -04:00
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
145 lines
4.0 KiB
TypeScript
145 lines
4.0 KiB
TypeScript
import { screen } from '@testing-library/react'
|
|
import userEvent from '@testing-library/user-event'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { EdgeFunctionRenderer } from './EdgeFunctionRenderer'
|
|
import { render } from '@/tests/helpers'
|
|
|
|
const {
|
|
mockTrack,
|
|
mockUseEdgeFunctionQuery,
|
|
mockUseParams,
|
|
mockUseProjectSettingsV2Query,
|
|
mockUseSelectedOrganizationQuery,
|
|
} = vi.hoisted(() => ({
|
|
mockTrack: vi.fn(),
|
|
mockUseEdgeFunctionQuery: vi.fn(),
|
|
mockUseParams: vi.fn(),
|
|
mockUseProjectSettingsV2Query: vi.fn(),
|
|
mockUseSelectedOrganizationQuery: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('common', async () => {
|
|
const actual = await vi.importActual<typeof import('common')>('common')
|
|
|
|
return {
|
|
...actual,
|
|
useParams: mockUseParams,
|
|
}
|
|
})
|
|
|
|
vi.mock('@/data/config/project-settings-v2-query', () => ({
|
|
useProjectSettingsV2Query: mockUseProjectSettingsV2Query,
|
|
}))
|
|
|
|
vi.mock('@/data/edge-functions/edge-function-query', () => ({
|
|
useEdgeFunctionQuery: mockUseEdgeFunctionQuery,
|
|
}))
|
|
|
|
vi.mock('@/lib/telemetry/track', () => ({
|
|
useTrack: () => mockTrack,
|
|
}))
|
|
|
|
vi.mock('@/hooks/misc/useSelectedOrganization', () => ({
|
|
useSelectedOrganizationQuery: mockUseSelectedOrganizationQuery,
|
|
}))
|
|
|
|
vi.mock('../EdgeFunctionBlock/EdgeFunctionBlock', () => ({
|
|
EdgeFunctionBlock: ({
|
|
showReplaceWarning,
|
|
onCancelReplace,
|
|
onConfirmReplace,
|
|
}: {
|
|
showReplaceWarning?: boolean
|
|
onCancelReplace?: () => void
|
|
onConfirmReplace?: () => void
|
|
}) => (
|
|
<div>
|
|
{showReplaceWarning && (
|
|
<div>
|
|
<p>An edge function with this name already exists.</p>
|
|
<button tabIndex={0} onClick={onCancelReplace}>
|
|
Cancel
|
|
</button>
|
|
<button tabIndex={0} onClick={onConfirmReplace}>
|
|
Replace function
|
|
</button>
|
|
</div>
|
|
)}
|
|
</div>
|
|
),
|
|
}))
|
|
|
|
vi.mock('./ConfirmFooter', () => ({
|
|
ConfirmFooter: ({
|
|
confirmLabel,
|
|
onConfirm,
|
|
}: {
|
|
confirmLabel?: string
|
|
onConfirm?: () => void
|
|
}) => (
|
|
<button tabIndex={0} onClick={onConfirm}>
|
|
{confirmLabel ?? 'Confirm'}
|
|
</button>
|
|
),
|
|
}))
|
|
|
|
describe('EdgeFunctionRenderer', () => {
|
|
beforeEach(() => {
|
|
mockTrack.mockReset()
|
|
mockUseEdgeFunctionQuery.mockReset()
|
|
mockUseParams.mockReturnValue({ ref: 'project-ref' })
|
|
mockUseProjectSettingsV2Query.mockReturnValue({ data: undefined })
|
|
mockUseSelectedOrganizationQuery.mockReturnValue({ data: { slug: 'org-slug' } })
|
|
})
|
|
|
|
it('only deploys an existing function from the replace warning confirmation', async () => {
|
|
const user = userEvent.setup()
|
|
const onApprove = vi.fn()
|
|
|
|
mockUseEdgeFunctionQuery.mockReturnValue({ data: { slug: 'hello-world' } })
|
|
|
|
render(
|
|
<EdgeFunctionRenderer
|
|
label="Deploy Edge Function"
|
|
code="Deno.serve(() => new Response('ok'))"
|
|
functionName="hello-world"
|
|
onApprove={onApprove}
|
|
/>
|
|
)
|
|
|
|
await user.click(screen.getByRole('button', { name: 'Deploy' }))
|
|
expect(screen.getByText('An edge function with this name already exists.')).toBeInTheDocument()
|
|
expect(onApprove).not.toHaveBeenCalled()
|
|
|
|
await user.click(screen.getByRole('button', { name: 'Deploy' }))
|
|
expect(onApprove).not.toHaveBeenCalled()
|
|
expect(mockTrack).not.toHaveBeenCalled()
|
|
|
|
await user.click(screen.getByRole('button', { name: 'Replace function' }))
|
|
expect(onApprove).toHaveBeenCalledTimes(1)
|
|
expect(mockTrack).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('deploys immediately when no existing function is found', async () => {
|
|
const user = userEvent.setup()
|
|
const onApprove = vi.fn()
|
|
|
|
mockUseEdgeFunctionQuery.mockReturnValue({ data: undefined })
|
|
|
|
render(
|
|
<EdgeFunctionRenderer
|
|
label="Deploy Edge Function"
|
|
code="Deno.serve(() => new Response('ok'))"
|
|
functionName="hello-world"
|
|
onApprove={onApprove}
|
|
/>
|
|
)
|
|
|
|
await user.click(screen.getByRole('button', { name: 'Deploy' }))
|
|
|
|
expect(onApprove).toHaveBeenCalledTimes(1)
|
|
expect(mockTrack).toHaveBeenCalledTimes(1)
|
|
})
|
|
})
|