mirror of
https://github.com/supabase/supabase.git
synced 2026-07-23 16:07:00 -04:00
6f6badae51
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
81 lines
2.3 KiB
TypeScript
81 lines
2.3 KiB
TypeScript
'use client'
|
|
|
|
import Link from 'next/link'
|
|
import { useState, type PropsWithChildren } from 'react'
|
|
import { DropdownMenu, DropdownMenuContent, DropdownMenuItem, DropdownMenuTrigger } from 'ui'
|
|
import { Admonition } from 'ui-patterns/admonition'
|
|
|
|
export function CodeSampleDummy() {
|
|
return (
|
|
<Admonition type="caution" title="Local development warning">
|
|
The <code>$CodeSample</code> directive with external repos is not supported in local
|
|
development because it relies on a GitHub API key. Please check the preview site to see the
|
|
final UI.
|
|
</Admonition>
|
|
)
|
|
}
|
|
|
|
export function CodeSampleWrapper({
|
|
children,
|
|
/**
|
|
* A GitHub URL to the source code file.
|
|
*/
|
|
source: _source,
|
|
}: PropsWithChildren<{ source: string | URL | (string | URL)[] }>) {
|
|
const source = Array.isArray(_source) ? _source : [_source]
|
|
|
|
if (source.length === 1) {
|
|
return <SingleSource source={source[0]}>{children}</SingleSource>
|
|
}
|
|
|
|
if (source.length > 1) {
|
|
return <MultipleSources sources={source}>{children}</MultipleSources>
|
|
}
|
|
|
|
return <>{children}</>
|
|
}
|
|
|
|
function MultipleSources({ children, sources }: PropsWithChildren<{ sources: (string | URL)[] }>) {
|
|
return (
|
|
<>
|
|
{children}
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<button
|
|
tabIndex={0}
|
|
className="block -mt-4 mb-4 ml-auto text-foreground-lighter text-sm focus-visible:outline-hidden focus-visible:underline"
|
|
>
|
|
View sources
|
|
</button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end">
|
|
{sources.map((source) => (
|
|
<DropdownMenuItem
|
|
key={source.toString()}
|
|
onSelect={() => window.open(source.toString(), '_blank', 'noopener noreferrer')}
|
|
>
|
|
...{source.toString().split('/').slice(-2).join('/')}
|
|
</DropdownMenuItem>
|
|
))}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
</>
|
|
)
|
|
}
|
|
|
|
function SingleSource({ children, source }: PropsWithChildren<{ source: string | URL }>) {
|
|
return (
|
|
<>
|
|
{children}
|
|
<Link
|
|
href={source.toString()}
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
className="block -mt-5 mb-4 text-right no-underline text-foreground-lighter text-sm"
|
|
>
|
|
View source
|
|
</Link>
|
|
</>
|
|
)
|
|
}
|